Giter Site home page Giter Site logo

fm_store's People

Contributors

mech avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

epictetus

fm_store's Issues

Criteria hash will not reset

When we use a has_many association with the inclusion criteria such as where and want to use the association again, the criteria will be included.

@employment.payrolls.where(:work_year => 2010) # this will set the criteria
@employment.payrolls # this is where the incorrect query happens because it include the above criteria!

It will have serious bug if the following code was used:

@employment.payrolls.limit(5) # we limit to 5 records
@employment.months_by_year(2007) # we need at least 12 records here, but will get 5 only

Searching is not very useful

Consider this

@colleagues = Employer::FmContact.where("company_id" => current_user.current_company_id).exclude("status" => "dormant").search(params)

We can't really do a search on -findquery

Tests?

Did you write tests for this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.