mediawiki-bot/mediawiki-bot

[unsupported] A high-level bot framework for interacting with MediaWiki wikis

mediawiki-bot's Issues

"Odd number of elements in hash assignment"

http://www.cpantesters.org/cpan/report/dec889a8-d064-11e0-b239-b5b22220068e

t/24-purge_page.t should check we're logged in

If login fails, then the test cannot purge the page. Skip the puge tests unless we logged in successfully.

Update test for get_pages

http://code.google.com/p/perlwikipedia/issues/detail?id=133

Reported by project member mike.lifeguard, Aug 15, 2010
From TODO:

*sub get_pages
**Does not handle things like "WP:TEST" correctly - it returns a hashkey of Wikipedia:TEST but not WP:TEST. (TODO test in t_18)
**Does not handle more pages than are allowed automatically be running multiple queries using highlimits like get_pages_in_namespace does

Delete comment Comment 1 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

test upload.t fails when upgrading to 5.5.5

The message is:

t/40-upload.t .................. You tried to plan twice at t/40-upload.t line 11.
# Looks like your test exited with 255 before it could output anything.
t/40-upload.t .................. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests

Tested in perl5.14.2 (ubuntu 12.04) and perl 5.10.0 (sled11).

HTTP::Request::Common 6.03 breaks MediaWiki::Bot

New newline-handling introduced in HTTP::Request::Common 6.03 causes the page text sent to the server to be different than what we sent. The MD5 we calculated no longer matches, and the server rejects the edit.

There is already a bug open for this issue, but it looks like there is some pushback. We might need to do the same newline transformation before we take the MD5 in order to make it match correctly. For now, we will mark the test as TODO or something.

Add plugin information to useragent

http://code.google.com/p/perlwikipedia/issues/detail?id=112#makechanges

Reported by project member mike.lifeguard, Jul 21, 2010
We should perhaps include plugin information (product and version) into the useragent. That could make it quite long...

Delete comment Comment 1 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

get_pages doesn't do multiple queries when needed

If you request more data than the API will let you have, there's no mechanism to get the next set of results. We should do that automatically for the user.

Use of uninitialized value in substitution (s///) at /usr/lib/perl5/site_perl/5.8.8/MediaWiki/Bot.pm line 1588.

I've noticed in version 3.005002 that every time my bot runs it spits out this error message as it is starting up:

Use of uninitialized value in substitution (s///) at /usr/lib/perl5/site_perl/5.8.8/MediaWiki/Bot.pm line 1588.

Everything seems to work correctly, otherwise. I've been ignoring it but thought I'd post here so someone could take a look and see if it's a problem that needs fixing.

Documentation improvement: add an "overview" section for context

The documentation is good if you know exactly what you are looking for, but doesn't offer a new user context to see where all of the details fit together. It would help to add an "overview" section to the documentation describing MediaWiki::Bot's overall design, intended purpose, and the types of functions it makes available

lgusername eq username is not always the correct way

At line 256,
($res->{login}->{lgusername} eq $self->{username}) is not always the correct way to check.
The username in MediaWiki is always displayed with first character uppcased, but I can still login with the lowercased usename.

So when you do this check, lgusername would nerver eq username when I set $self->{username} as the lowercased one.

t/29-get_log.t fails with unmatched element

Install from CPAN fails.

t/29-get_log.t ................. 1/1 
#   Failed test 'The same - all the way down'
#   at t/29-get_log.t line 49.
#     Structures begin differing at:
#          $got->[0]{logpage} = '0'
#     $expected->[0]{logpage} = Does not exist
# Looks like you failed 1 test of 1.
t/29-get_log.t ................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

I'm not great in the Test area, but I tried to 'trick' the unit test by adding:

            'type' => 'delete',
            'logpage' => '0',
            'logid' => 3672

... to each of the static array elements to match up with the $got. But, that didn't seem to be enough, and the test continued to fail. It seems probable that the issues likes with the packaged testwiki.

Initial failure was on Fedora20 workstation, and was replicated on a Centos6.5 installation as well.

t/05-revert.t fails occasionally

Two of my smokers produced a fail with t/05-revert.t. With both I could not reproduce the fail. Diagnostics:

#   Failed test 'Undo was successful'
#   at t/05-revert.t line 49.
#          got: '3'
#     expected: 'section zero==A normal section header==text'
# Looks like you failed 1 test of 2.
t/05-revert.t .................. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

HTH&&Regards

t/07-unicode.t outputs "Wide character in print" warnings

Even though we've set up UTF-8 filehandles, the test can still output "Wide character in print" warnings: http://www.cpantesters.org/cpan/report/35680d64-ced6-11e0-b45e-e9ac2220068e

Add support for querying userrights

http://code.google.com/p/perlwikipedia/issues/detail?id=79

Reported by project member mike.lifeguard, Jun 7, 2010
Like it says on the tin.

I'm not sure where these should go. Bureaucrat plugin? Steward?

Delete comment Comment 1 by project member mike.lifeguard, Jul 23, 2010
(No comment was entered for this change.)
Status: New
Labels: -Priority-Medium Priority-Low

Delete comment Comment 2 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

test get_pages fails when upgrading

Hi!
If I try to upgrade the Module cia CPAN "upgrade MediaWiki::Bot", then one get_pages-test will fail. I've tested this with perl 5.10.0 (sled11) and 5.14.2 (ubuntu 12.04).

t/19-get_pages.t ............... 1/9 
#   Failed test 'Got Main Page on multi-page get'
#   at t/19-get_pages.t line 26.
#                   ':''See also: [http://test2.wikipedia.org/ test2.wikipedia.org]
# 

# __NOEDITSECTION____NOTOC__
# This is a test wiki that runs on [[mw:|the MediaWiki software]]. Changes to the software will generally appear here a few days before they appear on the rest of the Wikimedia wikis. The contents of this site may be volatile and buggy. 
# 
# 

# The current version of MediaWiki running on this wiki is {{CURRENTVERSION}}. 
# 
 
# 
# {{Wikipedia:What we do on this wiki}}
# 
# '''Please note:''' there is a new test cluster created as a replacement for prototype.wikimedia available [http://beta.wmflabs.org here], it is a clone of all production wikis, where developers and regular users can test new features before we deploy them to production wiki. In case you want to test gadgets or user scripts on any Wikimedia project, you can also use that site. test.wikipedia.org is not for testing of unreviewed software or MediaWiki, it is a last place where software is deployed before it goes to live production. New software, extensions and gadgets can be deployed immediately to the deployment cluster.
# 
# == Please read before contributing here ==
# {{Wikipedia:What Test Wiki is not}}
# 
# === Requesting Permissions ===
# {{Wikipedia:Administrators}}
# {{Wikipedia:Bureaucrats}}
# 
# == Sister projects ==
# 

# {| class="plainlinks" style="background-color: transparent; text-align: left; width: 100%;"
# | align="center" | [[File:Wikipedia-logo-v2.svg|35x35px|link=http://en.wikipedia.org|logo Wikipedia]]
# | '''[http://en.wikipedia.org Wikipedia]'''
Free encyclopedia
# | align="center" | [[File:Wiktionary-logo-en.png|35x35px|link=http://www.wiktionary.org|logo Wiktionary]]
# | '''[http://www.wiktionary.org Wiktionary]'''
Free dictionary and thesaurus
# | align="center" | [[File:Wikinews-logo.svg|35x35px|link=http://www.wikinews.org|logo Wikinews]]
# | '''[http://www.wikinews.org Wikinews]'''
Free-content news
# | align="center" | [[File:Wikiquote-logo.svg|35x35px|link=http://www.wikiquote.org|logo Wikiquote]]
# | '''[http://www.wikiquote.org Wikiquote]'''
Free collection of quotations
# |-
# | align="center" | [[File:Wikibooks-logo.svg|35x35px|link=http://www.wikibooks.org|logo Wikibooks]]
# | '''[http://www.wikibooks.org Wikibooks]'''
Free textbooks and manuals
# | align="center" | [[File:Wikispecies-logo.svg|35x35px|link=http://species.wikimedia.org|logo Wikispecies]]
# | '''[http://species.wikimedia.org Wikispecies]'''
Free directory of species
# | align="center" | [[File:Wikisource-logo.svg|35x35px|link=http://wikisource.org|logo Wikisource]]
# | '''[http://wikisource.org/ Wikisource]'''
Free-content library
# | align="center" | [[File:MediaWiki-logo.svg|35x35px|link=http://mediawiki.org|logo MediaWiki]]
# | '''[http://mediawiki.org/ MediaWiki]'''
MediaWiki software
# |-
# | align="center" | [[File:Wikiversity-logo.svg|35x35px|link=http://www.wikiversity.org|logo Wikiversity]]
# | '''[http://www.wikiversity.org Wikiversity]'''
Free learning materials and activities
# | align="center" | [[File:Commons-logo.svg|35x35px|link=http://commons.wikimedia.org|logo Commons]]
# | '''[http://commons.wikimedia.org Commons]'''
Free shared media repository
# | align="center" | [[File:Wikimedia Community Logo.svg|35x35px|link=http://meta.wikimedia.org|logo Meta-Wiki]]
# | '''[http://meta.wikimedia.org Meta-Wiki]'''
Wikimedia project coordination
# |}
# 
# {{HomePages}}
# 
# 
# [[Category:Article Feedback Pilot]]
# '
#     doesn't match '(?^:Main Page)'
t/19-get_pages.t ............... 9/9 # Looks like you failed 1 test of 9.
t/19-get_pages.t ............... Dubious, test returned 1 (wstat 256, 0x100)

Rethink editing tests

http://code.google.com/p/perlwikipedia/issues/detail?id=134

Reported by project member mike.lifeguard, Aug 16, 2010
Currently, we have errors possibly resulting from:
 * Overzealous CVN folks reverting test edits
 * Simultaneous stampeding tests running
 * ...?

To alleviate the second one at least, we should consider running editing tests on a random user subpage. The last edit we do can mark it for deletion. I wonder how enwiki would feel about us wasting admin manpower deleting such pages. I wonder if it is really necessary. It deserves more thought...

Delete comment Comment 1 by project member mike.lifeguard, Aug 16, 2010
For example, I believe the fail on t/04_revert.t from http://www.cpantesters.org/cpan/report/2c4c208e-a980-11df-9d4d-4183984c9764 was caused by stampede.
Summary: Rethink editing tests

Delete comment Comment 2 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

undef in GET reqs makes URI::Escape spew errors under warnings

.

failed build on secure login

Hi guys,

I continue to get this error when installing MediaWiki::Bot.

t/34-secure.t .................. 1/1 
#   Failed test 'Edited via secure server successfully'
#   at t/34-secure.t line 35.
#          got: undef
#     expected: '0.968291016369225'
# Looks like you failed 1 test of 1.
t/34-secure.t .................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Sincerely,

James

test t/04-edit.t fails when installing or upgrading

When I try to upgrade from 3.005002 to 3.005003 the following tests fail:

t/04-edit.t .................... 2/2 
#   Failed test 'Did section editing successfully'
#   at t/04-edit.t line 56.
#          got: '0.998982046105997
# '
#     expected: '0.998982046105997
# 
# == MediaWiki::Bot tests (t/04-edit.t) ==
# 
#0.370779786815064
# '
# Looks like you failed 1 test of 2.
t/04-edit.t .................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

(I've never been able to install MediaWiki-Bot via cpan without "force")

Namespace aliases stopped working?

http://code.google.com/p/perlwikipedia/issues/detail?id=155

Reported by project member mike.lifeguard, Yesterday (37 hours ago)
I suspect testwiki config was changed, resulting in these test failures. We should write a more robust test.

MediaWiki-Bot-3.4.0:
- x86_64-linux-ld / 5.12.4:
  - FAIL http://www.cpantesters.org/cpan/report/de794e6c-c103-11e0-bb77-2205379c8ecd

- x86_64-linux-thread-multi / 5.10.1:
  - FAIL http://www.cpantesters.org/cpan/report/f62bfe08-c0d4-11e0-82a1-eed7cd27f7d1

- x86_64-linux-thread-multi / 5.13.11:
  - FAIL http://www.cpantesters.org/cpan/report/9082be4a-c190-11e0-b473-872b9b284d6b

- x86_64-linux-thread-multi / 5.14.1:
  - FAIL http://www.cpantesters.org/cpan/report/e0b50a4e-c195-11e0-ad68-83629a870964

- x86_64-linux-thread-multi / 5.8.9:
  - FAIL http://www.cpantesters.org/cpan/report/1f8ce42e-c120-11e0-9508-9d1889fe1623

Documentation of edit function is incorrect

While learning to use the $bot->edit() function, I found the documentation to be incorrect:

https://metacpan.org/module/MediaWiki::Bot#edit

it says the function takes these arguments:

summary
minor
bot
assertion
section

It leaves off 'page' and 'text' though they are shown in the example code.

However, it appears the correct names should be:

page
text
summary
is_minor
assert
markasbot
section

It would also be helpful to mention that is_minor and markasbot are boolean need a numerical value of 1 or 0. Once I looked at the module's source code and found the correct info, I was able to get the function to work as expected, so it's only a documentation issue.

t/06-get_history.t needs UTF-8 filehandles

This test can output UTF-8 on failure; give it UTF-8 filehandles.

Consistently use constants instead of bare numbers

Bare numbers are used to represent namespaces, error codes, and responses for test_image_exists. This makes the code harder to read and to debug, and in the case of the error codes it is not very clear that they come from the MediaWiki::API constants.

It is better to die than to return in failure

http://code.google.com/p/perlwikipedia/issues/detail?id=48

Reported by project member mike.lifeguard, May 24, 2010
Lars Dieckow has suggested that we use exceptions for error-handling. In all honesty, he is right: exceptions are 
the proper way to do error-handling (Python-style preferred over Java-style). It is really too bad that Perl doesn't 
do exceptions properly (or at all, depending who you ask). Maybe when Perl6 comes around :P

I'd be happy to do this in Java or Python where I have some idea how to accomplish it. I don't have any idea how to 
do it in Perl though, so this will have to wait until someone else implements it.

To my mentioning that the 3.0 release would return undef on errors:

> Don't release that sort of half-baked interface. The reasoning against
> that is the whole chapter 13 of [Perl Best Practices]
> (http://oreilly.com/catalog/9780596001735/). Get your copy today.
>
> Use Exception::Class and Try::Tiny, that's the one modern programmers
> generally employ. Also read the first couple from
> <http://google.com/search?q=site:stackoverflow.com+perl+exceptions>.
>
> I intend to contribute code, just not immediately because a number of
> important Perl meetings and conferences are coming up and I still have to
> write my talks.

Delete comment Comment 1 by project member mike.lifeguard, Jun 28, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

Delete comment Comment 2 by project member mike.lifeguard, Mar 26, 2011
This should be a priority for the near- to mid-term future.
Status: Accepted
Labels: -Priority-Low Priority-Medium
Blockedon: 142

Add support for CentralAuth queries

http://code.google.com/p/perlwikipedia/issues/detail?id=109

Reported by project member mike.lifeguard, Jul 16, 2010
We have support for checking if an account was ever locked, but not support for other queries: Is an account /currently/ locked? hidden? What is the reason?

Delete comment Comment 1 by project member mike.lifeguard, Jul 24, 2010
(No comment was entered for this change.)
Labels: -Priority-Medium Priority-High

Delete comment Comment 2 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

Delete comment Comment 3 by project member mike.lifeguard, Mar 26, 2011
This is not currently a priority.
Status: New
Labels: -Priority-High Priority-Medium

Delete comment Comment 4 by project member mike.lifeguard, Jun 4, 2011
There are log types available, but it doesn't appear that /current/ status can be queried.

http://meta.wikimedia.org/w/api.php?action=help&querymodules=logevents

Add support for specifying which plugins to load

http://code.google.com/p/perlwikipedia/issues/detail?id=80

Reported by project member mike.lifeguard, Jun 7, 2010
Installing a plugin doesn't necessarily mean one wishes to always load it. We should provide a method to specify which plugins to load, if any. The default could remain loading them all. But I don't know how to go about doing this.

Delete comment Comment 1 by project member mike.lifeguard, Jun 28, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

Delete comment Comment 2 by project member mike.lifeguard, Jul 23, 2010
(No comment was entered for this change.)
Status: New
Cc: -EN.WP.ST47 -mike.lifeguard
Labels: -Priority-Medium Priority-Low

Delete comment Comment 3 by project member mike.lifeguard, Oct 4, 2010
Is this really a concern? Is there a performance hit from loading the plugin code?

get_images double :: required?

Documentation example uses 'File::foo'

I was not able to get any image unless I use 'File:foo'

Maybe I am not familiar with the notation, but I could not get it to work with ::

Link to repo in the default user-agent

Add the repository location to the default user-agent string to facilitate WMF traffic analysis (see https://rt.cpan.org/Ticket/Display.html?id=94885 )

Documentation improvement: link to relevant [[API]] subpages for corresponding methods

Linking to the relevant MediaWiki API documentation in the docs for the methods here would make it easier for users to understand usage of method options/parameters.

namespace cant be 0

in many functions there is something like
$hash->{...} = $ns if $ns;
and that is ugly old code. What really is meant here, is
$hash->{...} = $ns if defined $ns;

because if $ns == 0, the first condition would be false, but the second one would be true.

Test 'undo was successful' in t/04_revert.t is unreliable

http://code.google.com/p/perlwikipedia/issues/detail?id=137

Reported by project member mike.lifeguard, Aug 19, 2010
You should check if it is written correctly.

Delete comment Comment 1 by project member mike.lifeguard, Sep 19, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

Delete comment Comment 2 by project member mike.lifeguard, Feb 14, 2011
Perhaps we should set this as a SKIP (or TODO?) until it can be made more robust.

Failed test 'Secure login'

---

#   Failed test 'Secure login'
#   at t/02-login.t line 99.
#          got: undef
#     expected: '1'
# {
#   'code' => 2,
#   'details' => '301 Moved Permanently : error occurred when accessing https://secure.wikimedia.org/wikipedia/en/w/api.php after 6 attempt(s)',
#   'stacktrace' => '301 Moved Permanently : error occurred when accessing https://secure.wikimedia.org/wikipedia/en/w/api.php after 6 attempt(s) at /usr/local/share/perl/5.10.1/MediaWiki/API.pm line 417.

---

I did "force install MediaWiki::Bot" and it is working for things I need, but I guessed that it would be nice to inform you that default build is failing.

Use of rand without parentheses is ambiguous

Fix it by adding empty parens after rand.

Tests fail on Ubuntu Quantal

When I installed the latest version of MediaWiki::API from CPAN (0.39), MediaWiki::Bot could not be installed because of failing tests:

t/03-get_text.t ................ 3/6 
#   Failed test 'Section load pass/fail'
#   at t/03-get_text.t line 26.
#          got: undef
#     expected: anything else

#   Failed test 'Section loaded content correctly'
#   at t/03-get_text.t line 27.
#          got: undef
#     expected: anything else
Use of uninitialized value $section_wikitext in quotemeta at t/03-get_text.t line 28.
Use of uninitialized value $this in pattern match (m//) at t/03-get_text.t line 28.
t/03-get_text.t ................ 6/6 # Looks like you failed 2 tests of 6.

t/42-expandtemplates.t ......... 1/2 
#   Failed test '[[Template:Tlxtest]] expanded OK'
#   at t/42-expandtemplates.t line 14.
#          got: '[[:Template:Tlxtest]]'
#     expected: '<tt><nowiki>{{</nowiki>[[Template:tlxtest|tlxtest]]<nowiki>}}</nowiki></tt>'

Altogether 5 of 50 tests fail. The same happens for MediaWiki::API 0.36.

Environment:

• Perl 5.14.2
• Carp 1.26
• HTML::Entities 3.69

Bot.pm is very long, split for readability

Bot.pm is long enough that it is frustrating to look through it and see details on what methods are available without ctrl+f. Logically grouping related subroutines into several separate files would help users grasp what methods are available and look through the relevant ones without being overwhelmed by information.

install fails on Fedora 16

Attempted to install on Fedora 16. All required modules installed successfully, however MediaWiki::Bot install failed. The failure message is a bit cryptic, so I've no idea what's wrong but I've copied the output of CPAN below. Any chance of packaging this library as an RPM, so it could be installed directly via yum without resorting to building it with CPAN?

cpan[2]> install MediaWiki::Bot
Running install for module 'MediaWiki::Bot'
Running make for L/LI/LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz
Checksum for /root/.cpan/sources/authors/id/L/LI/LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz ok
Scanning cache /root/.cpan/build for sizes
............................................................................DONE

CPAN.pm: Going to build L/LI/LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz

Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'MediaWiki-Bot' version '3.005000'
Building MediaWiki-Bot
LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz
./Build -- OK
'YAML' not installed, will not store persistent state
Running Build test
t/00-compile.t ................. ok
t/00-init.t .................... 1/5 #

Thanks for using MediaWiki::Bot. If any of these

tests fail, or you need any other assistance with

the module, please email our support mailing list

at [email protected], or submit a bug

to our tracker http://goo.gl/E1wMT on github.

If you want, you can log in for editing tests.

To log in for those tests, stop the test suite now,

set the environment variables PWPUsername and

PWPPassword, and run the test suite.

t/00-init.t .................... ok
t/01-api_error.t ............... ok
t/02-login.t ................... skipped: I can't log in without credentials
t/03-get_text.t ................ ok
t/04-edit.t .................... ok
t/05-revert.t .................. 1/2 Label not found for "last SKIP" at /root/perl5/lib/perl5/Test/More.pm line 1256.

Looks like your test exited with 255 just after 2.

t/05-revert.t .................. Dubious, test returned 255 (wstat 65280, 0xff00)
All 2 subtests passed
(less 2 skipped subtests: 0 okay)
t/06-get_history.t ............. ok
t/07-unicode.t ................. ok
t/08-get_last.t ................ ok
t/09-update_rc.t ............... ok
t/10-what_links_here.t ......... ok
t/11-get_pages_in_category.t ... ok
t/12-linksearch.t .............. ok
t/13-get_namespace_names.t ..... ok
t/14-get_pages_in_namespace.t .. ok
t/15-count_contributions.t ..... ok
t/16-last_active.t ............. ok
t/17-was_blocked.t ............. ok
t/18-is_blocked.t .............. ok
t/19-get_pages.t ............... ok
t/20-assertion.t ............... ok
t/21-get_allusers.t ............ ok
t/22-get_id.t .................. ok
t/23-list_transclusions.t ...... ok
t/24-purge_page.t .............. ok
t/25-sitematrix.t .............. ok
t/26-diff.t .................... ok
t/27-prefixindex.t ............. ok
t/28-search.t .................. ok
t/29-get_log.t ................. ok
t/30-was_g_blocked.t ........... ok
t/31-is_g_blocked.t ............ ok
t/32-was_locked.t .............. ok
t/33-is_locked.t ............... ok
t/34-secure.t .................. ok
t/35-get_protection.t .......... ok
t/36-email.t ................... skipped: I can't log in without credentials
t/37-move.t .................... ok
t/38-test_image_exists.t ....... ok
t/39-image_usage.t ............. ok
t/40-upload.t .................. skipped: upload test requires login with upload permission
t/41-get_users.t ............... ok
t/42-expandtemplates.t ......... ok
t/43-recentchanges.t ........... ok
t/44-patrol.t .................. skipped: Login with patrol rights required
t/45-contributions.t ........... ok
t/46-usergroups.t .............. ok
t/47-global_image_usage.t ...... ok
t/48-get_image.t ............... skipped: Imager required

Test Summary Report

t/05-revert.t (Wstat: 65280 Tests: 2 Failed: 0)
Non-zero exit status: 255
Files=50, Tests=267, 71 wallclock secs ( 0.32 usr 0.09 sys + 8.94 cusr 1.18 csys = 10.53 CPU)
Result: FAIL
Failed 1/50 test programs. 0/267 subtests failed.
LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz
./Build test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
reports LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz
Running Build install
make test had returned bad status, won't install without force
Failed during this command:
LIFEGUARD/MediaWiki-Bot-3.005000.tar.gz : make_test NO

cpan[3]>

No capacity for handling CAPTCHAs

http://code.google.com/p/perlwikipedia/issues/detail?id=44

Reported by project member mike.lifeguard, May 23, 2010
I'm not entirely sure if this should go in MediaWiki::Bot or in client 
code...

Delete comment Comment 1 by project member mike.lifeguard, Jul 12, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard
Labels: -Type-Other Type-Defect

Delete comment Comment 2 by project member mike.lifeguard, Jul 24, 2010
(No comment was entered for this change.)
Cc: -EN.WP.ST47 -oleg.alexandrov
Labels: -Priority-Medium Priority-Low

Documentation wikibook is very out of date (pre-version 3, last updated 2010)

https://en.wikibooks.org/wiki/Perlwikibot is very out of date; consider either updating it or replacing it with a pointer to https://code.google.com/p/perlwikipedia/w/list and http://search.cpan.org/~lifeguard/MediaWiki-Bot-5.005007/lib/MediaWiki/Bot.pm?

Daily builds

http://code.google.com/p/perlwikipedia/issues/detail?id=135

Reported by project member mike.lifeguard, Aug 16, 2010
The test suite runner is going to run daily once it is updated for dzil. It should also make that daily build available online.
Delete comment Comment 1 by project member mike.lifeguard, Aug 25, 2010
Done
Status: Done

Delete comment Comment 2 by project member mike.lifeguard, Aug 27, 2010
Something broke :(
Status: Started

Delete comment Comment 3 by project member mike.lifeguard, Sep 19, 2010
I don't have plans to get this working again, but someone really should.
Status: Accepted
Owner: ---
Cc: mike.lifeguard

Use Modern Perl

http://code.google.com/p/perlwikipedia/issues/detail?id=142

Reported by project member mike.lifeguard, Jan 11, 2011
Moose is new, ever so trendy, and better than vanilla Perl5 OO. We should use it, along with a sensible exception mechanism (issue 48).

Delete comment Comment 1 by project member mike.lifeguard, Feb 9, 2011
perl5i would be delicious too!
Summary: Use Moose & perl5i
Labels: -Type-Defect Type-Enhancement

Delete comment Comment 2 by project member mike.lifeguard, Mar 26, 2011
(No comment was entered for this change.)
Blocking: 48

Make default strings localizable

http://code.google.com/p/perlwikipedia/issues/detail?id=26

Reported by project member mike.lifeguard, May 14, 2010
Currently, we set some defaults, but they're all in English. We should 
create a way for these to be localized as pywikipediabot does, and choose 
the one corresponding to the wiki we're interfaced with. Bonus points for 
having sane fallbacks when a translation doesn't exist.

Delete comment Comment 1 by project member mike.lifeguard, Jun 28, 2010
(No comment was entered for this change.)
Owner: ---
Cc: mike.lifeguard

Delete comment Comment 2 by project member mike.lifeguard, Jul 23, 2010
(No comment was entered for this change.)
Status: New
Cc: -mike.lifeguard

Delete comment Comment 3 by project member mike.lifeguard, Jul 24, 2010
(No comment was entered for this change.)
Labels: -Priority-Medium Priority-Low

26-diff.t fails test 'Diff retrieved correctly'

This problem shows up on cpantesters: http://www.cpantesters.org/cpan/report/f60f8ea4-41bb-11e1-9d6f-f6dbfa7543f5

Refactor suggestion: `get_all_pages_in_category` and `_get_ns_alias_data`

If a larger-scale refactoring happens, it would be great to get the fake state variable out of get_all_pages_in_category and to refactor the end of _get_ns_alias_data for clarity.

$VERSION is not numeric

http://code.google.com/p/perlwikipedia/issues/detail?id=154

Reported by [email protected], May 1, 2011
What steps will reproduce the problem?
1. Write 'use MediaWiki::Bot 3.3.1;'

What is the expected output? What do you see instead?
#!/usr/bin/perl -w prints out:
Argument "3.3.1" isn't numeric in subroutine entry

What version of the product are you using? On what operating system?
3.3.1@Ubuntu

Please provide any additional information below.
Change build script so that Bot.pm contains the following in line 5:
our $VERSION = 3.3.1; # VERSION

Current wrong code is:
our $VERSION = '3.3.1'; # VERSION

Please run your code at least once before you release a new version. Thanks.

Delete comment Comment 1 by project member mike.lifeguard, May 2, 2011
Please don't insult the volunteer developer if you want your problem handled. Thanks.

Use Test::LongString for comparing page text

Sometimes, page text can be very long - use Test::LongString to make things easier.

get_pages uses hardcoded namespace aliases

We should fetch and cache the data on namespace aliases instead of relying on a hardcoded hash.

upload method?

Hi,

Either the upload method is not implemented, or the docs don't describe it very well.

I get an error 'Can't locate object method "upload" via package "MediaWiki::Bot"'with the MediaWiki::Bot 3.4.0

A look at Bot.pm doesn't show any trace of an upload method, and though API.pm includes documentation about uploads, and an upload method, I don't see any way for it to be called directly through MediaWiki::Bot.

Should I add the method (if I can!) or did I miss something?

Thanks, and thanks for the module BTW, beyond the lack of upload, so far it does what it says on the box.

Error handling woes in upload method

Hi,

in Bot::upload, it looks like the last line should be

return $success || _handle_api_error();

instead of

return $sucess;

or the error message gets lost.

Also, in API::api, when an upload error occurs, the error is a bit more complex than expected:

  DB<45> x $ref
0  HASH(0xb062248)
   'error' => HASH(0xb062378)
      0 => ARRAY(0xb062448)
         0  'upload_directory_read_only'
         1  '/usr/share/mediawiki/images'
      'code' => 'internal-error'
      'info' => 'An internal error occurred'
   'servedby' => 'm4'

The useful information, namely that the image directory permissions are not right, is in the $ref->{error}->{0} array, while the info field is totally useless. I am not sure if this is a common occurence, if additional info is always in $ref->{error}->{0} or if it could be somewhere else... so I am not sure I can fix this one in the generic case.

This is with mediawiki 1.17.0 and MediaWiki::Bot 3.4.2

BTW, I know that using the wiki would have told me that, but I am seeding it from external sources, so at this point no human has touched it yet.

Thanks

Update expandtemplates to use the new prop parameter

expandtemplates has been changed on the API side: http://lists.wikimedia.org/pipermail/mediawiki-api-announce/2014-June/000058.html

It should be updated to use prop=wikitext to avoid using deprecated options.

No easy way to get a full page history

http://code.google.com/p/perlwikipedia/issues/detail?id=150

Reported by project member mike.lifeguard, Apr 15, 2011
get_history provides no way to get the whole page history. Because page history isn't offered as a list, the programmer has to extract query-continue and use it appropriately. We should do it for them, or find a way to use a list to get the data.

Delete comment Comment 1 by project member mike.lifeguard, Apr 29, 2011
Marjorie is working on this right now. Thanks so much for your effort on fixing this!
Status: Started
Owner: marjorie.seizou
Cc: mike.lifeguard

Delete comment Comment 2 by project member mike.lifeguard, Jun 4, 2011
I'll be working on fixing up Marjorie's patch.
Owner: mike.lifeguard
Cc: marjorie.seizou