meedstrom/quickroam

Fast org-roam commands

quickroam's Issues

Test this memoization

This is the function that consumes most of the time when finding nodes:

https://gist.github.com/dmgerman/1c76743aa36c5d86112123fd333566e2

The advantage of memoizing this function is that it has no impact on querying the database.

quickroam-insert inserts link at top of buffer, regardless of (point)

I expect quickroam-insert to insert in the same way org-roam-node-insert does, which is to insert the link at (point). Instead, the link is inserted on the second line of the file and anything on that line is pushed to the side.

I suspect it's because of this bit:

;; Try to strip the todo keyword, whatever counts as todo syntax
;; in the target file.  Fail silently because it matters not much.
(ignore-errors
  (org-roam-with-file
      (expand-file-name (plist-get node :file) org-roam-directory)
      nil
    (widen)
    (goto-char 1)
    (forward-line (1- (plist-get node :line-number)))
    (setq link-desc (nth 4 (org-heading-components)))))

I don't understand the purpose of this code. Is the title not an appropriate link description? What's that about stripping the TODO keyword? Does this assume something about the current buffer and/or the buffer of the node we've selected?

I restored my expected behavior by using a modified quickroam-insert:

(defun cashpw/quickroam-insert ()
  "Fast substitute for `org-roam-node-insert'."
  (interactive nil org-mode)
  (require 'org-roam)
  (when (or (hash-table-empty-p quickroam-cache)
            (not quickroam-mode))
    (quickroam-reset))
  (let* ((beg nil)
         (end nil)
         (region-text (when (region-active-p)
                        (setq beg (region-beginning))
                        (setq end (region-end))
                        (org-link-display-format
                         (buffer-substring-no-properties beg end))))
         (title (completing-read "Node: " quickroam-cache nil nil nil 'org-roam-node-history))
         (node (gethash title quickroam-cache))
         (id (plist-get node :id))
         (link-desc (or region-text title)))
    (if node
        (atomic-change-group
          (when region-text
            (delete-region beg end))
          (insert (org-link-make-string (concat "id:" id) link-desc))
          (run-hook-with-args 'org-roam-post-node-insert-hook id link-desc))
      (atomic-change-group
        (org-roam-capture-
         :node (org-roam-node-create :title title)
         :props (append
                 (when region-text
                   (list :region (cons (set-marker (make-marker) beg)
                                       (set-marker (make-marker) end))))
                 (list :link-description link-desc
                       :finalize 'insert-link)))))))

On consecutive empty nodes, jumps to the wrong heading

This appears to be a ripgrep bug, which I filed: BurntSushi/ripgrep#2779

For now, if for some reason you write several empty subtree nodes, just leave a blank line or some text between in each.

Quickroam doesn't catch org-roam alias

Aliases defined in the PROPERTIES header with :ROAM_ALIASES: are not picked up by quickroam.