meelgroup/breakid

BreakID, a CNF symmetry-breaking library and tool

breakid's Issues

Fedora review requests

I am trying to get breakid into the Fedora Linux distribution. To do so, the package has to pass a review. The reviewer asked me to make a few requests of you. None of these are mandatory, but would help us.

• Could you add license headers to files missing them, to give us more confidence that we understand the licensing situation? Files missing license headers:
  • breakidConfig.cmake.in
  • cmake/cmake_uninstall.cmake.in
  • src/breakid_c.cpp
  • src/breakid_c.h
• Could you remove files that are not needed by breakid? For example, most of the cmake/Find* files are not needed. That reduces the number of files we have to analyze for licensing purposes.
• The DEF_INSTALL_CMAKE_DIR definition in CMakeLists.txt refers to a lib directory. On RedHat-based systems like Fedora, that should be lib for 32-bit systems and lib64 for 64-bit systems. Are you willing to use LIB_INSTALL_DIR instead of a hard-coded lib?