mefellows/dockerize-compose-demo

Docker Compose demo using Dockerize to wait for dependencies

dockerize-compose-demo's Issues

Branchs dockerize and fail

Nice demo, but following your readme this project need branchs fail and dockerize and the repo don't have this branchs, i think that branch fail up compose without dockerize and branch dockerize up compose with dockerize wait..

what do you think that instead use branch, project use one Makefile with two targets?

i could make this change if you want..

docker-compose command override using dockerize results in Visual Studio error running solution "Can not find the container with the name starting with"

This works great outside of Visual Studio.

However, running a docker-compose project which tries to use command override in the docker-compose.override.yml to start the container using dockerize, Visual Studio results in Can not find the container with the name starting with 'MyProject' errors because the container does not have a status of running as dockerize is waiting to start it.

docker-compose.override.yml

command: ["./dockerize", "-wait", "tcp://mydatabase:1433", "-wait-retry-interval", "20s", "-timeout", "3m", "dotnet", "MyProject.dll"]

Visual Studio output

========== Debugging ==========
docker ps --filter "status=running" --filter "label=com.docker.compose.service" --filter "name=^/MyProject$" --format {{.ID}} -n 1

Removing the command override from the docker-compose.override.yml file and moving it to inside the Dockerfile seems to let Visual Studio work, but doesn't seem to honor the dockerize command and just goes into the dotnet cmd. Not being able to override the CMD from the docker-compose.override.yml is problematic in trying to change the name of the target to wait on per environment.

Dockerfile

COPY ["dockerize", "./"]
RUN chmod +x ./dockerize
CMD ["./dockerize", "-wait", "tcp://mydatabase:1433", "-wait-retry-interval", "20s", "-timeout", "3m", "dotnet", "MyProject.dll"]