Giter Site home page Giter Site logo

aventurine's People

Contributors

melchoyce avatar ryelle avatar szepeviktor avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

aventurine's Issues

Contrasts...

These color contrasts are not high enough:

  • 21759b on f1f1f1 in on .screen-reader-text.
  • 16a387 on ffffff in in footer.
  • ffffff on 16a387 in .site-description in footer. The .site-title passes because it's a larger font size.
  • 16a387 on ffffff in in .entry-meta.
  • 16a387 on whitesmoke keyword in in .logged-in-as
  • e74c3c on whitesmoke keyword in in .widget-title
  • ffffff text with opacity in .site-info
  • 7c94ac on ffffff in .read-more

Update readme

Begin documentation-- comment here if there's anything you want me to write up.

A11y checks

  • Headings, check in WAVE.
  • Link text must be unique and make sense out of context.
  • Controls must be buttons (menu toggle)
  • Keyboard nav focus states must be visible
  • Contrast must be within the level AA contrast ratio (4.5:1).
  • Skip link must be first focusable element
  • Forms must have labels: comment, search, password.
  • Check with larger default font size

CodeSniffer issues

FILE: /srv/www/wordpress-trunk/wp-content/themes/aventurine/build/archive.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 51 | ERROR | No space before closing parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
--------------------------------------------------------------------------------


FILE: ...srv/www/wordpress-trunk/wp-content/themes/aventurine/build/comments.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 26 | ERROR | No space after opening parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
 26 | ERROR | No space before closing parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
--------------------------------------------------------------------------------


FILE: ...www/wordpress-trunk/wp-content/themes/aventurine/build/content-page.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 12 | ERROR | No space after opening parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
 12 | ERROR | No space before closing parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
--------------------------------------------------------------------------------


FILE: ...w/wordpress-trunk/wp-content/themes/aventurine/build/content-single.php
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
 10 | ERROR | No space after opening parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
 10 | ERROR | No space before closing parenthesis of function  prohibited
    |       | (WordPress.Functions.FunctionCallSignature)
 43 | ERROR | Blank line found after control structure
    |       | (WordPress.WhiteSpace.ControlStructureSpacing)
 51 | ERROR | Blank line found after control structure
    |       | (WordPress.WhiteSpace.ControlStructureSpacing)
--------------------------------------------------------------------------------


FILE: ...w/wordpress-trunk/wp-content/themes/aventurine/build/inc/customizer.php
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 37 | ERROR | No space after opening parenthesis of function definition
    |       | prohibited (WordPress.Functions.FunctionCallSignature)
 37 | ERROR | No space before closing parenthesis of function definition
    |       | prohibited (WordPress.Functions.FunctionCallSignature)
 41 | ERROR | No space before closing parenthesis of function definition
    |       | prohibited (WordPress.Functions.FunctionCallSignature)
--------------------------------------------------------------------------------


FILE: ...ordpress-trunk/wp-content/themes/aventurine/build/inc/template-tags.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 140 | ERROR | Disabling pagination is prohibited in VIP context, do not set
     |       | `numberposts` to `-1` ever.
     |       | (WordPress.VIP.PostsPerPage.posts_per_page)
 145 | ERROR | Each line in an array declaration must end in a comma
     |       | (WordPress.Arrays.ArrayDeclaration)
--------------------------------------------------------------------------------

iPhone->Chrome issues

  • Menu needs some additional padding-bottom
  • Site title needs more margin-top
  • Reduce horizontal padding inside content area
  • Footer needs padding
  • Footer widgets totally fucked
  • Name and email fields should stack
  • Less padding-left in form fields
  • Alignleft and alignright need to be unfloated
  • Responsive tables…?
  • Any way to reduce code indenting a bit?
  • Youtube videos strettttttched

Test on Android

Close the monster "Browser Test" issue, only Android remains.

Browser testing!

  • Windows/Firefox
  • Windows/Chrome
  • Windows XP/IE8
  • Windows 7/IE9
  • Windows 7/IE10
  • Windows 8/IE9
  • Windows 8/IE10
  • Windows 8/IE11
  • Mac/Firefox
  • Mac/Chrome
  • Mac/Safari
  • iPhone/Safari
  • iPhone/Chrome
  • Android/whatever that is

Search navigation

From review:

The archive post navigation looks different on search pages. It's not styled like others, and may be broken

Infinite scroll...?

This might be a setting thing on my WP, just noting it here. This button is ugly.

screen shot 2014-09-23 at 12 55 47 pm

Kelly's todos

  • Header menu should work (2 levels)
  • Featured image should be full-width
  • Meta should match format in PSD
  • Comments
  • Background color

Comments?

Did you want to do anything fancy with comments for this theme, or let them be as they are? They do match the mockup right now, just wanted to check.

iOS dropdown

Clicking dropdown on iOS goes straight to the top-level item, doesn't trigger the dropdown (can't navigate to submenu pages)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.