melissa-cruz/tufts-gnha

work related to GNHA

Tufts-GNHA

tufts-gnha's Issues

Avoid modifying global variables

This jumped out during my review:

Tufts-GNHA/20210213_WHO.py

Lines 117 to 120 in 1571498

	# map the correct indicator text name to the results
	indReqDF.rename(columns={'WHOSex': 'sexVal', 'IndicatorCodeDS': 'indCode'}, inplace=True)
	# print(indReqDF.columns)
	df2 = indReqDF[["sexVal","indCode","IndicatorName"]]

indReqDF is defined as a global:

Tufts-GNHA/20210213_WHO.py

Lines 15 to 16 in 1571498

	# import requested indicator list
	indReqDF = pd.read_csv("requestedIndicators.csv")

Renaming the columns in the middle of this loop will carry through to subsequent loops. It's probably harmless here, but in general, modifying global variables could cause unexpected side-effects, so it's best to avoid that. In this case, since you only need to do it once, I'd suggest doing it when you load the CSV.