mellanox/ibdump

ibdump's Issues

ibdump: builds are not reproducible

gcc -g -O2 -fdebug-prefix-map=/.autodirect/sysgwork/tzafrirc/upstream/ibdump/ibdump-subtree=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -W  -g -MP -MD -DPACKAGE_VERSION
_STR=\"3.0.0-7\" -DWITH_MSTFLINT -DMST_UL -I/usr/include/mstflint -DUPSTREAM_KERNEL '-DBLD_VER_STR="devel"' -Wdate-time -D_FORTIFY_SOURCE=2  -c -o ibdump.o ibdump.c
In file included from ibdump.c:64:0:
tools_version.h: In function ‘get_version_string’:
tools_version.h:66:19: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                   __DATE__,
                   ^~~~~~~~
tools_version.h:67:19: warning: macro "__TIME__" might prevent reproducible builds [-Wdate-time]
                   __TIME__,
                   ^~~~~~~~

See also https://reproducible-builds.org/docs/timestamps/

Inconsistent version of ibdump

So which is the correct version (on current master branch):

$ git tag
ibdump-6_0_0
ibdump-6_1_0

(Also https://github.com/Mellanox/ibdump/releases which are made from the tags)

$ make
gcc -Wall -W  -g -MP -MD -DPACKAGE_VERSION_STR=\"3.0.0-7\" -DWITH_MFT -DIBDUMP_A0_MODE  -I/usr/include/mft/ '-DBLD_VER_STR="devel"'   -c -o ibdump.o ibdump.c
...

Seems to say the version is 3.0.0-7. Comes from:

$ git grep VERSION Makefile
Makefile:VERSION    = 3.0.0-7
Makefile:CFLAGS    += -MP -MD -DPACKAGE_VERSION_STR=\"$(VERSION)\"