mellowplace/minacl

A forms library with no components! Purely design driven

minacl's Issues

Empty textarea tag breaks forms

view templates in charsets other than UTF-8 may be causing issues

Specifically an error happened in cp1252

Errors in views

If you have a view template like:

The warning/fatal seems to be passed into SimpleXMLElement, so all you get is an XML parsing error.

Validators firing

All validators, apart from phRequiredValidator, should not fire if the value is empty

phForm::__toString throwing exceptions

__toString methods if they throw exceptions mask the actual error that occurred because PHP rethrows something like:

Fatal error: Method phForm::__toString() must not throw an exception in /home/rob/html-forms/test/unit/phViewTest.php on line 433

This will occur when you try "echo $form;" and for some reason an exception is thrown.

It would be better to trigger an error with the original exception type, code & message.

Bug: checkbox array values

If a set of checkboxes is defined on the form as an array fieldName[] for example, then minacl throws an error if none of them are checked (even without a validator being applied).

Message: Trying to bind a value that is not an array to interest
#0 C:\wamp\www\xxx\application\models\form\phForm.php(173): phSimpleArrayDataItem->bind(NULL)
#1 C:\wamp\www\xxx\application\models\form\phForm.php(252): phForm->bind(Array)

Unit Tests on Windows

Unit tests fail on windows machines in phRenderingTest, whilst trying to download the DTD.

See http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic/

Could do with providing a local copy of the DTD in the tests

Conditional validator

A decorator type validator that fires another validator if a condition is met e.g. if a field equals another value could be very useful.

It would cover off various scenario's such as firing different post/zip code validators depending on a chosen country.

Might be possible to abstract phCompareValidator and extend from it as it has alot of this equals, greater equals etc type behavior.

Consider including docs in github repo now domain has lapsed