Comments (12)
- please review pr #46 , I have committed these changes :)
from memphis.py.
We need to add to our setup.py long_description attribute.
That can be a reference to the description file (examples here) or to add a text in the file - take numpy for example.
The text should be memphis decription as it is written in our README from line 26.
from memphis.py.
-- so, in simple terms, we need to add multi line comments in setup.py file!
from memphis.py.
@Adarsh-jaiss Yes, you're right! And there is always the option to refer to a file and then manage the changes in this file.
We will appreciate a contribution on this one, so our PyPi users will see the documentation as well!
from memphis.py.
-- can you please explain , the steps for fixing this issue because I am little confused :)
from memphis.py.
Sure!
In our PyPi repo there is no documentation. We want our users to see our python-sdk documentation on this page. In order to do so we need to update setup.py according to PyPa (Python Packaging Authority) requirements, which appear here.
To do so we need to update long_description field.
There are 2 ways to do so:
- To refer to README file. If we use this option we should pay attention to referring to a file that will be displayed properly on PyPI, you can find the requirements in the link to PyPa.
- To add a multiline comment as you mentioned and then refer to it in the long_description the same way as numpy did.
I always prefer to use the first way and manage a dedicated file for this purpose.
You can find the documentation that needs the adaptation here.
I will be happy to answer further questions. 💫
from memphis.py.
from setuptools import setup
# read the contents of your README file
from pathlib import Path
this_directory = Path(__file__).parent
long_description = (this_directory / "README.md").read_text()
setup(
name='an_example_package',
# other arguments omitted
long_description=long_description,
long_description_content_type='text/markdown'
)
and kindly review this :
from setuptools import setup
# read the contents of your README file
from pathlib import Path
this_directory = Path(__memphis.py/README.md__).parent
long_description = (this_directory / "README.md").read_text()
setup(
name='pypi',
# other arguments omitted
long_description=long_description,
long_description_content_type='text/markdown'
)
-- And here ,please choose one that i need to add in long_description_content type
1. long_description_content_type = text/markdown; charset=UTF-8; variant=GFM
2. long_description_content_type='text/markdown'
other than that please tell me what to write in long_description
and do i have to replace and add this whole syntax from file or i have to just add this syntax to that file ?
from memphis.py.
Thanks for the reply, I think adding these 2 lines will work, this file and README are in the same directory,
setup(
long_description = file: README.md
long_description_content_type = text/markdown; charset=UTF-8; variant=GF
)
We just need to ensure that our README.md is written according to PyPa requirements.
you can open a new branch and create a PR :)
from memphis.py.
Also here is a good example:
The Repo is here
And that's how it looks in PyPi
from memphis.py.
Thank you @Adarsh-jaiss for the contribution, it looks good!
Your PR will be merged during the next day and will be released on our next release.
Great having you with us :)
from memphis.py.
-- Thank you so much @SvetaMemphis for helping me in this whole contribution journey
-- I am in love with the Memphis community and I am looking forward for more such contributions
from memphis.py.
PR approved and will be released on the coming version, thanks a lot @Adarsh-jaiss you are rocking
from memphis.py.
Related Issues (20)
- [Discussion] Typing, tests, formatting, pre-commit HOT 4
- Stop consume functionality HOT 7
- Create formal documentation HOT 3
- Bug: Improve error description HOT 6
- Bug: Tries to access property of None instance HOT 2
- Bug: Missing method HOT 2
- Setup automated tests for PRs
- Bug: Review no-member error for ProtoBuf HOT 4
- Bug: Review no-member error for Exception status_code member HOT 6
- Re-enable E1101 message from Pylint
- Raise MemphisSchemaError rather then MemphisError HOT 1
- lint project using Ruff HOT 3
- Use separate connections for producers, consumers, etc.
- Inconsistent consumer name HOT 1
- Add examples to docstrings for consumer methods HOT 6
- Add task count limit to async produce
- Add error handling for async produce
- Drain or cancel waiting tasks when the producer is destroyed
- Support destroying existing consumers
- Change name of async producer parameter to "non-blocking"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memphis.py.