mepox/fitbuddy

FitBuddy is a workout tracker app made with Spring Boot

fitbuddy's Issues

Add tests for `HistoryController`

Add unit test for `HistoryConverterService.java`

Return an empty collection instead of null in `ExerciseController`

Sonar issue link

Compliant solution: return Collections.emptyList();

fitbuddy/src/main/java/app/fitbuddy/operation/controller/ExerciseController.java

Lines 56 to 66 in d8129e0

	@GetMapping
	public List<ExerciseDto> readAll() {
	Authentication auth = SecurityContextHolder.getContext().getAuthentication();
	AppUserDto appUserDto = appUserCrudService.readByName(auth.getName());
	if (appUserDto != null && appUserDto.getId() != null) {
	List<ExerciseDto> dtos = exerciseCrudService.readMany(appUserDto.getId());
	logger.info("Sending a list of exercises.");
	return dtos;
	}
	return null;
	}

Revisit `RoleCrudService` and `RoleCrudServiceTest`

Use the built-in formatting to construct this arguments in `RegisterController.java`

Link to Sonar issue

Compliant Solution example:
logger.info("The message text here: {}", registerDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/RegisterController.java

Line 32 in cb2be79

logger.info("Trying to register with: " + registerDto);

Remove auth null checks in `HistoryController` methods

Auth null check is unnecessary as the @PreAuthorize("authenticated") annotation should make sure the methods cannot be called by anonymous users.

Remove auth != null from all these:

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 48 in 5558b9a

if (auth != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 61 in 5558b9a

if (auth != null && strDate != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 82 in 5558b9a

if (auth != null && historyId != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 96 in 5558b9a

if (auth != null && historyId != null) {

Refactor `ConverterService` tests

• use nested classes
• use TestHelper class

Add unit test for `HistoryCrudService.java`

Fix SecurityConfig, `@PreAuthorize` annotations are not enabled..

@EnableGlobalMethodSecurity(prePostEnabled = true) should be added to the SecurityConfig to enable @PreAuthorize annotations 😅

Add test coverage for the create methods in `CrudServices`

Remove the extra semicolon in `ExerciseController`

Sonar issue link

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 30 in 66d095b

private final ExerciseCrudService exerciseCrudService;;

`RegisterService` should use `AppUserCrudService` and `RoleCrudService`

userRole can be null `RegisterService.java`

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/service/RegisterService.java

Lines 44 to 49 in 8e4e0ee

	// add user - with default role
	Optional<Role> userRole = roleRepository.findByName("USER");
	AppUser appUser = new AppUser();
	appUser.setName(name);
	appUser.setPassword(bCryptPasswordEncoder.encode(password));
	appUser.setRole(userRole.get());

Change the visibility of this constructor to "protected" in `GenericCrudService.java`

Sonar link issue

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/jpa/service/GenericCrudService.java

Line 12 in 06e7090

public GenericCrudService(CrudRepository<E, Integer> repository, TwoWayConverterService<D, E> converter) {

Add tests for `LoginController`

• Resolve #70 first

`LoginService` should use `AppUserCrudService`

Make sure only encoded passwords get saved to `AppUser` entity

For example when a new AppUser get created or updated.

A "NullPointerException" could be thrown in `ControllerExceptionHandler.java`

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/exception/ControllerExceptionHandler.java

Lines 20 to 21 in 8e4e0ee

	FieldError fe = ex.getBindingResult().getFieldError();
	String field = fe.getField();

implement `AppUserConverterService`

Remove these 'public' modifiers in `RegisterControllerTest`

Sonar issue link

fitbuddy/src/test/java/com/laszlojanku/fitbuddy/operation/controller/RegisterControllerTest.java

Line 30 in 40b1a87

public class RegisterControllerTest {

fitbuddy/src/test/java/com/laszlojanku/fitbuddy/operation/controller/RegisterControllerTest.java

Line 38 in 40b1a87

public void register_whenInputIsCorrect_shouldReturnOk() throws Exception {

fitbuddy/src/test/java/com/laszlojanku/fitbuddy/operation/controller/RegisterControllerTest.java

Line 54 in 40b1a87

public void register_whenNameSizeNotCorrect_shouldReturnBadRequest(String name) throws Exception {

fitbuddy/src/test/java/com/laszlojanku/fitbuddy/operation/controller/RegisterControllerTest.java

Line 65 in 40b1a87

public void register_whenPasswordSizeNotCorrect_shouldReturnBadRequest(String password) throws Exception {

Refactor user menu

• Refactor menu items placement
• Add collapse menu for smaller screens

Add contributors

Use the built-in formatting to construct this arguments in `LoginController.java`

Link to Sonar issue

Compliant Solution example:
logger.info("The message text here: {}", loginDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/LoginController.java

Line 30 in 80ea406

logger.info("Trying to log in: " + loginDto);

Add test for `RegisterController`

Add TestHelper methods for Entities to be used in tests

implement `RoleCrudService` with `RoleConverterService`

History cannot be updated

Implement `AppUserController` with tests

Add unit test for `ExerciseConverterService.java`

Fix CORS policy so it works on Heroku

Revisit `AppUserCrudService` and `AppUserCrudServiceTest`

Use the built-in formatting to construct this arguments in `HistoryController.java`

Link to Sonar issue

Compliant Solution example:
logger.info("The message text here: {}", historyDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 50 in f40fdaa

logger.info("Creating new history: " + historyDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 67 in f40fdaa

logger.info("Sending a history for " + strDate);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 81 in f40fdaa

logger.info("Updating history: " + historyDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/HistoryController.java

Line 94 in f40fdaa

logger.info("Deleting history: " + historyDto);

Fix empty history for newuser

implement `AppUserCrudService` update method

refactor `HistoryDto` to use exercise name only

Redesign the main menu (navbar)

Remove auth null checks in `ExerciseController` methods

Auth null check is unnecessary as the @PreAuthorize("authenticated") annotation should make sure the methods cannot be called by anonymous users.

Remove auth != null from all these:

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 47 in 5558b9a

if (auth != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 60 in 5558b9a

if (auth != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 74 in 5558b9a

if (auth != null && exerciseId != null) {

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 88 in 5558b9a

if (auth != null && exerciseId != null) {

Use `@PreAuthorize` annotation in `ExerciseController` and `HistoryController`

The diamond operator ("<>") should be used in `LoginService`

Sonar issue link

Use: new ArrayList<>();

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/service/LoginService.java

Line 52 in f4d5a81

List<GrantedAuthority> grantList = new ArrayList<GrantedAuthority>();

Add test for `ExerciseController`

Add unit test for `ExerciseCrudService.java`

Show the user's name on the user's main page

Use the built-in formatting to construct this arguments in `ExerciseController.java`

Link to Sonar issue

Compliant Solution example:
logger.info("The message text here: {}", exerciseDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 49 in 905869e

logger.info("Creating new exercise: " + exerciseDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 74 in 905869e

logger.info("Updating the exercise: " + exerciseDto);

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/ExerciseController.java

Line 87 in 905869e

logger.info("Deleting exercise: " + exerciseDto);

Basic account info page

Refactor `CrudService` tests

• variable names

Add unit test for `AppUserCrudService.java`

Return an empty collection instead of null in `HistoryController`

Sonar issue link

Compliant solution: return Collections.emptyList();

fitbuddy/src/main/java/app/fitbuddy/operation/controller/HistoryController.java

Lines 63 to 81 in 6a7c297

	@GetMapping("{date}")
	public List<HistoryDto> readAll(@PathVariable("date") String strDate) {
	Authentication auth = SecurityContextHolder.getContext().getAuthentication();
	if (strDate != null) {
	try {
	LocalDate.parse(strDate);
	} catch (DateTimeParseException e) {
	throw new FitBuddyException(DATE_NOT_VALID);
	}
	AppUserDto appUserDto = appUserCrudService.readByName(auth.getName());
	if (appUserDto != null && appUserDto.getId() != null) {
	List<HistoryDto> historyDtos = historyCrudService.readMany(appUserDto.getId(), strDate);
	logger.info("Sending a history for: {}", strDate);
	return historyDtos;
	}
	}
	return null;
	}

Return an empty collection instead of null in `AppUserConverterService`

Add @Valid annotation to the RequestBody parameter in `LoginController`

Example: public void login(@Valid @RequestBody LoginDto loginDto)

fitbuddy/src/main/java/com/laszlojanku/fitbuddy/operation/controller/LoginController.java

Line 29 in 06e7090

public void login(@RequestBody LoginDto loginDto) {

Add unit test for `LoginService`