mercurialpony/locks

The source code for Locks, a small, but unique Minecraft mod that introduces flexible and universal locks, a fun new lock picking mechanic and lots of other useful tools.

locks's Issues

custom pin number for locks

i feel like this mod is great for adventure maps but as far as we have static number of pins for every lock, school's classroom and weapon locker protected with identical locks every time. one of the possible solutions is to add tiered locks that can hold up to #{n} pins and just add pins to lock somehow, maybe just by adding golden nuggets to lock in crafting layout (routine way) or with a help of the special lock creation workbench (way of increasing complexity)

Crash an world loading (server)

https://pastebin.com/QXZ3DB6x

keys deleted

in 1.12.2 multi, the keys disappear so a little random in keychains, they are completely removed and must be remanufactured. if not before that it only disappear graphically but we can reappear by clicking on it.

[REQ] Key Ring Baubles Support

Either just basic compatibility to save space or go a little further and not have to have the key ring in hand to use it.

[1.12.2] Lockable Blocks config option not persisting after world reload

After adding modded blocks to the list of lockable blocks in the config, everything works as intended. However, upon exiting and re-entering the world, the same modded blocks can no longer be locked. The CUI still appears, and the sound of a lock clicking into place can be heard, but no lock is actually applied to the block.

[1.12.2] [Suggestion] Wildcards for the config

It would take an extremely long time to add all the doors, chests, gates, etc., to the config when playing a large modpack. My suggestion is a wildcard feature that lets you use an asterisk (*) as a wildcard.

Examples:

• engineersdoors:* would accept any block from Engineer’s Doors.
• extratrees:doors.* would accept any block from Extra Trees that has an item ID which starts with doors.
• forestry:*_chest would accept any block from Forestry that has an item ID which ends in _chest.
• * would accept all blocks in the game (which should not be used; it’s just an example).

Is this something you could implement? It would make it take much less time to add doors to the config! 💙

Biomes O' Plenty doors do not accept locks.

I've added the Biomes O' Plenty doors to the config, and yet they will not lock. I know there aren't any typos in the config because I copy and pasted the same names for the fence gates which lock just fine.
Locks 2.2.1

Shulker Boxes cannot be locked

Minecraft v1.15.2
Forge v31.2.31
Locks v2.4

Shulker Boxes are currently unable to be locked.

1.12.2 - Adding Door IDs to the Config

locks config.txt

Minecraft version: 1.12.2-forge1.12.2-14.23.5.2837
Mod version: Locks-2.2.1

I posted a comment about the mod automatically sensing doors from other mods like ConquestReforged due to the high amount of doors. HOWEVER, I went to their website and grabbed a bunch of the door IDs and did it anyway. When I reloaded my game, the doors still weren't working with the locks/keys. I am not sure if I did the IDs wrong, but I copied them and pasted them as is--and they look just like the minecraft IDs already in the config.

Here is a copy and paste of my config file [GitHub says it won't accept ".cfg" files?] I hope this helps your mod!

How to Access Lock Pick Strength Config Option?

I might just be dumb but I cannot find the lock pick strength config option in either the common or client config files. In the feature showcase video, the mod-maker accessed this option through a "Mod Options" button in the game menu, but I don't seem to have that option on my game.

For some reason my lock picks are very weak by default and break many times before i can even open one lock! Any help with this would be greatly appreciated :^)

The customizable lock length should have a minimum of at least 1

The title says it all, because setting the lock length to 0 and lockpicking results in a bug where ESC does not open the lock, and pressing A, W or D crashes the game.
https://paste.dimdev.org/okisuhacon.mccrash

Obviously you shouldn't be setting the length to zero, but I did this because I thought it would open the lock instantly (Yeah, pretty lazy, ik) rather then this funky stuff

carry on mod breaks lock when picked up

In single player on forge 2808, I tested and I was able to pick up chest and place it down for the lock to auto break.

[1.12.2] Lighting bug on locks when viewed from certain angles

Video 1.

Video 2.

As you can see in the video 1, the lock on the door turns black when viewed from side angles. However, as you can see in video 2, this doesn’t always happen. Even though it was the same door with the same lock, it just stopped happening for some reason, yet it still happens to another door somewhere else.

This was tested in an instance where the only mod installed was Locks; not a single other mod was installed.

Versions

• Minecraft: 1.12.2
• Forge: 14.23.5.2847 (latest for 1.12.2)
• Locks: 2.2.1 (latest for 1.12.2)

Keyring deletes keys when placed in offhand in MP

Related to #4 , placing the key ring in the offhand slot in a multiplayer game with this mod alone results in the keyring emptying, and unlike #4 , this deletes the keys, rather than just visually removing them. The keyring container seems to not be networked completely.

Some problems in 1.12.2

villager can ignore locks on the door.

in a open Lan game, other play's keyring not show keys correctly.

Mod Corrupts Recipes in Other Mods

After more experimentation, this mod is not the cause of this issue. Or at least, not the sole cause.

Installing the locks mod corrupts some recipes that use items from other mods. Not all recipes are affected.

Recipes listed in the recipe book do not seem to change, but certain items will not work in recipes or will yield the wrong item.

Example: (Patchouli book for the Japanese Food Mod results in Oak Planks)

2 Bugs/exploits

• You can place a chest next to a locked chest, that will convert it to a double chest and the freshly placed side can be opened as normal.
• You can place hoppers/any form of item transport to extract items from locked chests

Double chests are not supported...

The locked side is locked properly. the other side is unaffected.

Villagers can open locked doors

The expected behaviour is that Villagers just rattle the lock and walk away.

Feature Request: Text Feedback for Locked Blocks

So this is a bit of an odd one.

Currently when trying to open locked blocks you get an audio cue to indicate that the block is locked. It would be nice if you also (or by config?) got visual feedback using a status update like beds do. Something along the lines of 'The is locked' as someone may hear that cue but not realized what it means, especially since they may not see the lock. By making it a status update it wouldn't spam the chatbox, would fade away after a few seconds, and directly conveys why they can't open it.

I can´t find the config file

Where is the config file in which I can add blocks from other mods?

Levers can be used to open Locked Doors without a key.

If you place a lever near a locked door, and activate it, then the door will open regardless of if it is locked or not. I am in Forge version 2768 and am running Minecraft 1.12.2.

[1.12.2] Locks appear in the corner of Decocraft2 doors, rather than in the middle

Locks appear in the corner of doors from Decocraft2 rather than in the middle.

Here is my mod list.

Versions

• Minecraft: 1.12.2
• Forge: 14.23.5.2847 (latest for 1.12.2)
• Locks: 2.2.1 (latest for 1.12.2)
• Decocraft2: 2.6.3 (latest)

Security Craft & Iron Chest/Iron Shulker

This two mods are not supported.
is it possible to support the items of this two mods?

[1.12.2] Crash when attempting to lock a block

After updating to version 2.4 of the mod, the game is crashing with this error any time I attempt to place a lock:

java.lang.IllegalAccessError: tried to access method net.minecraft.world.World.func_175663_a(IIIIIIZ)Z from class melonslise.locks.common.util.Cuboid6i
    at melonslise.locks.common.util.Cuboid6i.loaded(Cuboid6i.java:126)
    at melonslise.locks.client.event.LocksClientEvents.lambda$onClientTick$0(LocksClientEvents.java:56)
    at java.lang.Iterable.forEach(Unknown Source)
    at melonslise.locks.client.event.LocksClientEvents.onClientTick(LocksClientEvents.java:54)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1119_LocksClientEvents_onClientTick_ClientTickEvent.invoke(.dynamic)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
    at net.minecraftforge.fml.common.FMLCommonHandler.onPreClientTick(FMLCommonHandler.java:344)
    at net.minecraft.client.Minecraft.runTick(Minecraft.java:1708)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1098)
    at net.minecraft.client.Minecraft.run(Minecraft.java:3942)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)

Locks Are Not Being Picked Up By Schematics or Structure Blocks

I REALLY love your mod, it is the first one that has done exactly the things I need it to as far as locking and unlocking blocks. My upcoming modpack has structures that spawn which will have buttons inside that must be unlocked before the player can progress. Unfortunately, for some reason your locks are not being picked up by the Schematic or Strucutre capture functions,. which are how I copy the structures to each world. I really hope there is something you can do to help me find out why they aren't being captured. Are the locks coded in a certain way that is not scanned properly?

I assume im doing something wrong

i am attempting to add the chest from iron chests but when i add in the cofig
iron_chest:diamond_chest
ironchest:diamond_chest
ironchest:diamondchest
etc it does not seem to work am i missing something very new to setting up server it's jsut for my kids but i need a chest lock function to save my sanity -.-
was trying in single player to start with normal chest lock fine

Key ring doesn't work (bug?)

Heya...
sorry for bothering you again but I really have a problem and I don't think I can fix that.
The key ring doesn't work properly. I'll show you a .gif what I mean.
https://s3.gifyu.com/images/2019-07-18_09-38-20.gif
The keys disappear and I can't open the lock on the correct locked chest. After I open the ring and click on the space where the key should be, the keys appear again and I can use them.

Tinkers Exploit/Possible Solution

I can't vouch for versions after 1.12.2, but the tinkers crafting table can still access a locked chest. So users in my mod pack using only 1 wood log can unlock any chest.

Looking into another issue, it would seem the chests are still accessible via other means too. I am unfamiliar with minecraft modding but I would assume you must prevent chests from being interacted with or recognized. As you said in the other post, you are unsure how to fix this. Could somehow moving the NBT data from the chest to the lock make it where ALL mods and such think the chest is "empty" until it is unlocked? Perhaps a "hopper" lock to disable this feature, for just locking chests in machines?

This solution however has the risk of losing items if something goes wrong, so some-kind of protection should be in place beforehand.

Doors are still affected by red stone.

So doors in this mod are still switched when red stone is applied. Meaning you can get past any door using a red stone torch.

Missing config option to set strength of lockpicks

The setting to change the chance of lockpicks to break seems to be missing from the config as of version 2.4
Is this an intentional design choice?

Bibliocraft

Heya :D

I think that would be nice if the bibliocraft chests could be locked. That would be awesome!

[Request] Multiple Lock Pick Types

One feature I would like is having multiple types of lock picks, which would have different breaking chances from one another. On my fork of the mod I added a second type of pick, and it should be generalizeable to other numbers (although the texture changing of the lockpick in the gui does't currently allow for it, it would be a very easy fix to do so).

Should I submit a pull request? I am unsure of whether my code would be the idiomatic way to add this feature.

World Load Crash

Minecraft v1.15.2
Forge v31.2.31
Locks v2.4

I created a new world in singleplayer and immediately crashed.
Crash Report

It doesn't load on 1.14.4

Here's the latest.log and debug.log

Minecraft 1.14.4
Forge 28.1.70
OptiFine HD U F4
Locks 2.3.1.1

[1.12.2] Not all new, randomly generated chests are generated with locks

With B:generate_locks set to true, I explored a new, randomly generated dungeon, and while most of the chests had locks, about 1-in-4 chests did not have a lock on it.

Versions

• Minecraft: 1.12.2
• Forge: 14.23.5.2847 (latest for 1.12.2)
• Locks: 2.2.1 (latest for 1.12.2)

Randomly generated locks do not obey configuration for lock length

Unless I'm misunderstanding the nature of the configuration option, it would appear that

https://github.com/Melonslise/Locks/blob/a91573c100dbba32badd9166bf7542bd373faa5b/src/main/java/melonslise/locks/common/event/LocksEvents.java#L120

uses a randomly selected size rather the value set in the configuration.

Alternately, if this was intended, it would be great if you could configure the upper and lower bounds of the locks.

problem with doors and hatches 1.12.2 multi

locked doors, make an opening quick closing when clicked on, if it is close to the door, the door opens implicitly making the closure indiscreet

No Crafting Recipe for Lock

I am unable to find a way to craft a lock in survival mode.

Locks don't generate on chests in superflat worlds

I tried with multiple superflat worlds in multiple Minecraft versions, and in the ones from Minecraft 1.14.4–1.16.1 I couldn't find literally any locked chest, even when I changed the "Generation Chance" config option to value "1.0" at some point, whereas in the ones from Minecraft 1.12.2 the lock generation worked correctly.

I was able to reproduce this issue on the following configurations:

• Minecraft versions: 1.16.1, 1.15.2, 1.14.4
• Locks versions: 2.4 for MC 1.16.1, 2.4 for MC 1.15.2, 2.4 for MC 1.14.4
• Forge versions: 32.0.75, 31.2.0, 28.2.0

[Help] Trying to edit the config file.

I am currently attempting to edit the config file to add some doors from the DecoCraft mod. However instead of just an item id decocraft also uses the block type tag to differentiate between items. As an example decocrafts vault door is like the other props in the mod props:props as the item id and the block type tag that differentiates it is 1444 does anyone know how to do this or if this is even possible.
Thanks.

Craft problem on 1.12.2

My game is crashing when I try to make a link between a lock and a key in my workbench. Here is more informations :

`
A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Client thread
Stacktrace:
at melonslise.locks.common.crafting.recipe.RecipeLockableCloning.func_77569_a(RecipeLockableCloning.java:70)
at net.minecraft.item.crafting.CraftingManager.func_180303_b(CraftingManager.java:226)
at net.minecraft.inventory.SlotCrafting.func_190901_a(SlotCrafting.java:72)
at net.minecraft.inventory.Container.func_184996_a(Container.java:303)
at net.minecraft.client.multiplayer.PlayerControllerMP.func_187098_a(PlayerControllerMP.java:565)
at net.minecraft.client.gui.inventory.GuiContainer.func_184098_a(GuiContainer.java:638)
at net.minecraft.client.gui.inventory.GuiCrafting.func_184098_a(SourceFile:131)
at net.minecraft.client.gui.inventory.GuiContainer.func_73864_a(GuiContainer.java:392)
at net.minecraft.client.gui.inventory.GuiCrafting.func_73864_a(SourceFile:101)
at net.minecraft.client.gui.GuiScreen.func_146274_d(GuiScreen.java:533)
at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:501)

-- Affected screen --
Details:
Screen name: net.minecraft.client.gui.inventory.GuiCrafting

-- Affected level --
Details:
Level name: MpServer
All players: 1 total; [EntityPlayerSP['DaelysVakel'/545025, l='MpServer', x=-1810.58, y=73.00, z=-2006.07]]
Chunk stats: MultiplayerChunkCache: 289, 289
Level seed: 0
Level generator: ID 02 - largeBiomes, ver 0. Features enabled: false
Level generator options:
Level spawn location: World: (-1832,18,-2358), Chunk: (at 8,1,10 in -115,-148; contains blocks -1840,0,-2368 to -1825,255,-2353), Region: (-4,-5; contains chunks -128,-160 to -97,-129, blocks -2048,0,-2560 to -1537,255,-2049)
Level time: 7804538 game time, 3639605 day time
Level dimension: 0
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
Forced entities: 41 total; [EntityCustomNpc['Hans Egede'/545160, l='MpServer', x=-1804.50, y=77.50, z=-2016.60], MoCEntityLeopard['Leopard'/545162, l='MpServer', x=-1798.99, y=117.00, z=-2077.91], MoCEntityPandaBear['PandaBear'/545088, l='MpServer', x=-1855.40, y=94.50, z=-2026.60], MoCEntityBlackBear['BlackBear'/545216, l='MpServer', x=-1751.00, y=72.63, z=-1959.98], MoCEntityBee['Bee'/545280, l='MpServer', x=-1732.70, y=67.88, z=-2016.61], EntityCustomNpc['Dave Olson'/545089, l='MpServer', x=-1842.50, y=77.00, z=-2007.50], EntityCustomNpc['Olav Sventsen'/545026, l='MpServer', x=-1810.50, y=73.00, z=-2003.50], EntityCustomNpc['Olvia Hasman'/545027, l='MpServer', x=-1811.00, y=77.56, z=-2005.50], MoCEntityMouse['Mouse'/545156, l='MpServer', x=-1797.50, y=34.00, z=-2015.50], EntityCustomNpc['Dan Fridley'/545157, l='MpServer', x=-1803.50, y=68.00, z=-1994.50], MoCEntityRoach['Roach'/545221, l='MpServer', x=-1761.43, y=92.00, z=-2053.42], EntityCustomNpc['Owen Daventri'/545113, l='MpServer', x=-1831.22, y=73.00, z=-1999.47], MoCEntityMouse['Mouse'/545114, l='MpServer', x=-1836.51, y=23.00, z=-1958.85], MoCEntityMouse['Mouse'/545115, l='MpServer', x=-1836.50, y=23.00, z=-1953.51], EntityPlayerSP['DaelysVakel'/545025, l='MpServer', x=-1810.58, y=73.00, z=-2006.07], MoCEntityDragonfly['DragonFly'/545116, l='MpServer', x=-1829.57, y=67.00, z=-1956.23], EntityRabbit['Lapin'/545117, l='MpServer', x=-1819.80, y=128.13, z=-2074.20], EntityCustomNpc['Henrik Brandt'/545119, l='MpServer', x=-1831.50, y=73.50, z=-2009.50], MoCEntityButterfly['ButterFly'/545108, l='MpServer', x=-1837.31, y=70.00, z=-1938.46], MoCEntityFox['Fox'/545109, l='MpServer', x=-1821.42, y=70.00, z=-1926.02], EntityXPOrb['Orbe d'expérience'/545110, l='MpServer', x=-1808.74, y=68.50, z=-1945.20], MoCEntityFirefly['Firefly'/545174, l='MpServer', x=-1799.10, y=67.00, z=-1956.46], EntityCustomNpc['Sara Liamja'/545111, l='MpServer', x=-1819.50, y=68.50, z=-1997.50], MoCEntityButterfly['ButterFly'/545175, l='MpServer', x=-1798.47, y=69.00, z=-1927.37], EntityCustomNpc['Leïna Helmar'/545128, l='MpServer', x=-1829.50, y=80.50, z=-2019.50], EntitySheep['Mouton'/545069, l='MpServer', x=-1877.27, y=111.88, z=-2016.50], MoCEntityRaccoon['Raccoon'/545070, l='MpServer', x=-1856.88, y=103.63, z=-2075.84], EntityRabbit['Lapin'/545071, l='MpServer', x=-1872.97, y=117.13, z=-2044.52], EntityCustomNpc['Lyron Aldforth'/545121, l='MpServer', x=-1824.54, y=69.00, z=-2011.14], EntityCustomNpc['Rengar Berwyn'/545122, l='MpServer', x=-1815.50, y=77.50, z=-2016.50], EntityCustomNpc['Rosa Markisum'/545123, l='MpServer', x=-1830.00, y=73.56, z=-1996.50], EntityCustomNpc['Anders Fleischer'/545125, l='MpServer', x=-1837.50, y=73.00, z=-1994.50], EntityCustomNpc['Keith Al'Mar'/545126, l='MpServer', x=-1825.00, y=80.56, z=-1994.50], MoCEntityBlackBear['BlackBear'/545211, l='MpServer', x=-1754.97, y=67.00, z=-2008.07], MoCEntityBlackBear['BlackBear'/545212, l='MpServer', x=-1754.50, y=94.00, z=-2057.50], EntityPig['Cochon'/545213, l='MpServer', x=-1766.50, y=80.00, z=-2032.55], EntityChicken['Poule'/545214, l='MpServer', x=-1752.65, y=73.00, z=-1943.79], MoCEntityBee['Bee'/545279, l='MpServer', x=-1737.62, y=68.38, z=-2018.64], EntityItem['item.item.egg'/545215, l='MpServer', x=-1752.28, y=73.00, z=-1944.00], MoCEntityMaggot['Maggot'/545072, l='MpServer', x=-1870.50, y=90.00, z=-1952.87], EntitySheep['Mouton'/545203, l='MpServer', x=-1784.52, y=112.00, z=-2062.77]]
Retry entities: 0 total; []
Server brand: fml,forge,sponge
Server type: Non-integrated multiplayer server
Stacktrace:
at net.minecraft.client.multiplayer.WorldClient.func_72914_a(WorldClient.java:532)
at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2748)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:418)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

-- System Details --
Details:
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_201, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 1514539072 bytes (1444 MB) / 3056054272 bytes (2914 MB) up to 4241293312 bytes (4044 MB)
JVM Flags: 7 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -XX:-UseAdaptiveSizePolicy -Xmn512m -Xmx4096m -Xmx4096m
IntCache: cache: 0, tcache: 0, allocated: 13, tallocated: 99
FML: MCP 9.42 Powered by Forge 14.23.0.2491 Optifine OptiFine_1.12.2_HD_U_E3 21 mods loaded, 21 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

| State  | ID                                           | Version                 | Source                                      | Signature                                |
|:------ |:-------------------------------------------- |:----------------------- |:------------------------------------------- |:---------------------------------------- |
| UCHIJA | minecraft                                    | 1.12.2                  | minecraft.jar                               | None                                     |
| UCHIJA | mcp                                          | 9.42                    | minecraft.jar                               | None                                     |
| UCHIJA | FML                                          | 8.0.99.99               | forge-1.12.2-14.23.0.2491.jar               | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| UCHIJA | forge                                        | 14.23.0.2491            | forge-1.12.2-14.23.0.2491.jar               | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| UCHIJA | com.elytradev.movingworld.common.asm.coremod |                         | minecraft.jar                               | None                                     |
| UCHIJA | bauercam                                     | 1.13                    | BauerCam-Mod-1.12.2.jar                     | None                                     |
| UCHIJA | bibliocraft                                  | 2.4.5                   | BiblioCraft[v2.4.5][MC1.12.2].jar           | None                                     |
| UCHIJA | conquest                                     | 3.0.2                   | ConquestReforged-3.0.2-mc1.12.2.jar         | None                                     |
| UCHIJA | blockpalette                                 | 1.5.0                   | ConquestReforged-3.0.2-mc1.12.2.jar         | None                                     |
| UCHIJA | connect                                      | 1.0.3-mc1.12.2-SNAPSHOT | ConquestReforged-3.0.2-mc1.12.2.jar         | None                                     |
| UCHIJA | customspawner                                | 3.11.4                  | CustomMobSpawner-3.11.4.jar                 | None                                     |
| UCHIJA | customnpcs                                   | 1.12                    | CustomNPCs_1.12.2(30Jan19).jar              | None                                     |
| UCHIJA | movingworld                                  | 1.12-6.342              | movingworld-1.12-6.342-full.jar             | None                                     |
| UCHIJA | davincisvessels                              | @DVESSELSVER@           | davincisvessels-1.12-6.337-full.jar         | None                                     |
| UCHIJA | mocreatures                                  | 12.0.5                  | DrZharks MoCreatures Mod-12.0.5.jar         | None                                     |
| UCHIJA | locks                                        | 2.2.1                   | Locks-2.2.1.jar                             | None                                     |
| UCHIJA | lunatriuscore                                | 1.2.0.42                | LunatriusCore-1.12.2-1.2.0.42-universal.jar | None                                     |
| UCHIJA | minema                                       | 3.4                     | Minema-Mod-Unofficial-1.12.2.jar            | None                                     |
| UCHIJA | moreplayermodels                             | 1.12.2                  | MorePlayerModels_1.12.2(18jan18).jar        | None                                     |
| UCHIJA | schematica                                   | 1.8.0.169               | Schematica-1.12.2-1.8.0.169-universal.jar   | None                                     |
| UCHIJA | variedcommodities                            | 1.12.2                  | VariedCommodities_1.12.2(15may18.jar        | None                                     |

Loaded coremods (and transformers): 

ShaderHookLoader (Minema-Mod-Unofficial-1.12.2.jar)
info.ata4.minecraft.minema.shaderHook_coremod.ShaderHookInjector
MovingWorldCore (movingworld-1.12-6.342-full.jar)

GL info: ' Vendor: 'Intel' Version: '4.5.0 - Build 24.20.100.6292' Renderer: 'Intel(R) UHD Graphics 630'
Launched Version: 1.12.2
LWJGL: 2.9.4
OpenGL: Intel(R) UHD Graphics 630 GL version 4.5.0 - Build 24.20.100.6292, Intel
GL Caps: Using GL 1.3 multitexturing.

Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: Conquest_1.12.zip
Current Language: Français (France)
Profiler Position: N/A (disabled)
CPU: 8x Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
OptiFine Version: OptiFine_1.12.2_HD_U_E3
OptiFine Build: 20181210-121000
Render Distance Chunks: 8
Mipmaps: 4
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
Shaders: null
OpenGlVersion: 4.5.0 - Build 24.20.100.6292
OpenGlRenderer: Intel(R) UHD Graphics 630
OpenGlVendor: Intel
CpuCount: 8

[20:37:26] [main/INFO]: [net.minecraft.init.Bootstrap:func_179870_a:553]: #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\Nathan\AppData\Roaming.launchmycraft\launchers\launcher234778\crash-reports\crash-2019-10-15_20.37.25-client.txt
AL lib: (EE) alc_cleanup: 1 device not closed
Java HotSpot(TM) 64-Bit Server VM warning: Using incremental CMS is deprecated and will likely be removed in a future release

Game crashed !

`

Locks always rattle regardless of whether a matching key is used or just a hand

When you have a locked block (e.g. a chest), and then you use a matching key to open the lock, you hear two overlapping sounds instead of only one. Surprisingly it seems that "lock.open.ogg" starts first, followed by "lock.rattle.ogg", or at least that's the order of the subtitles.

I think it should work as follows:

if isMatchingKey then
    play "lock.open.ogg"
else
    play "lock.rattle.ogg"

I was able to reproduce this issue on the following configurations:

• Minecraft versions: 1.16.1, 1.15.2, 1.14.4, 1.12.2
• Locks versions: 2.5 for MC 1.16.1, 2.5 for MC 1.15.2, 2.5 for MC 1.14.4, 2.5 for MC 1.12.2
• Forge versions: 32.0.75, 31.2.0, 28.2.0, 14.23.5.2854

Keyring makes keys disappear when you open a chest

when you put keys ona keyring and open a chest, the keys will disappear but if i open the GUI and click on a "invisible key", it reappears

[suggestion] Loot tables

You should add lock picks to loot tables like chests and mobs drops. And make the weight at which they drop configurable for mobs and chest. Additionally you could add in the configs a whitelist and blacklist so modpack developers can manually add in which mobs or maybe what blocks could drop lockpicks.

Store locked blocks inside of a saved structure

It would be great to be able to save locked blocks to structures via Minecraft's "Structure block" system since I would like to garantee that the block will be locked, but also allow all the other chests in the world to be non-padlocked by default.
(I am saving structures to be loaded in world-gen via another mod)
Having looked through the data, I do understand if it will be difficult (or flat out too hard) to implement since you've gotta store the cube that contains the locked blocks and all that. Maybe this could just be a long-term suggestion...

Although, as a quick off the top of the head suggestion/workaround-for-now, perhaps just adding a padlock to a chest that contains the NBT tag {Lock:""} would suffice... but then again, how would you deal with double chests in generated structures...?

One Time Use Keys?

Is there any way to make keys one time use?

[1.12.2] Strange rendering bug – Locks freaking out

Video.

As you can see, the locks visually jump around when I’m either moving or looking around. If I stand completely still and also don’t move my view, the locks are still as they should be, but once I start moving either my character or my view, the locks start freaking out again.

Such an obvious bug would probably have been fixed already, so I’m assuming this doesn’t happen if Locks is the only mod installed. There’s probably a mod conflict going on here. At first, I thought it was MalisisDoors since it completely changes how doors work, but then I noticed that this bug also occurs on locks placed on chests, and MalisisDoors doesn’t change chests, so it’s most likely a different mod conflicting.

Here is my mod list. I’ve got a lot of mods installed. I could try to narrow it down, but perhaps you might know what mod could be causing this?

(I am not using OptiFine.)

Versions

• Minecraft: 1.12.2
• Forge: 14.23.5.2847 (latest for 1.12.2)
• Locks: 2.2.1 (latest for 1.12.2)

Keys Disappear with Keyring

I saw a similar issue on the cure page, but decided to open a proper github bug report.

What I've been seeing is when using key(s) in the keyring, after a while the key will seemingly vanish. The keyring will look like a blank keyring, looking inside shows nothing. However if I click where the key was, and move it back to inventory, key comes back. I had this happen with 3 different keyrings (same key) over the course of a single 3-hour play session.

My friend on the other hand (same server) had an issue where his key just disappeared completely never to be seen again. Which is more like the reports on the curse thread. I tried to have him click to find an invisible key, but no such luck. It was gone gone.

So there is definitely something up with the keyring specifically where it is forgetting it has keys.

Minecraft: 1.1.12
Mod Version: Locks-2.2.1
Forge: 14.23.5.2815
Multiplayer: Yes

Found a few ways to get past the locked feature

In 1.12.2 version of this mod. If you find a locked chest underground, you can simply put the same type of chest next to it to create a double chest. It will make only one side locked and the other side can be open. It kind of defeats the purpose of trying to open them.

There is another mod called EpicSiegeMobs which allows mobs to dig and break blocks to get to you if they spot you. This also bypasses the locked chests being unbreakable by you. Since you can try to get a digging mob to break it open for you. Thought I let you know! This is a great mod and has a lot of potential. I am currently using this mod in a mod-pack that I've created so some of my players pointed out this exploit.