merith-tk/cc-restitched-unmaintained

CC: Tweaked ported for Fabric 1.16.x

cc-restitched-unmaintained's Issues

Cannot play music discs without crashing the server

Useful information to include:

• Minecraft version : 1.16.5/Fabric
• CC: Restitched version: 1.95.3-beta
• Detailed reproduction steps: This bit of code works in singleplayer but not multiplayer

drive = peripheral.wrap("top")
drive.playAudio()`

crash-2021-06-03_09.42.06-server.txt

[1.17.1] mod not working on server, crash on startup

Useful information to include:

• Minecraft version 1.17.1
• CC: Restitched version 1.97.1-beta-1

`mouse_up` event doesn't fire

MC Version: 1.16
CC Version: v1.19.2

The mouse_up event is not emitted, which breaks nearly all GUI applications.

Steps to reproduce:

lua
while true do print(os.pullEvent()) end

Click, and notice no mouse_up events.

Seems like https://github.com/Merith-TK/cc-restitched/blob/a80302c513c08229998fbeff9842e93df9a7da64/src/main/java/dan200/computercraft/client/gui/widgets/WidgetTerminal.java#L234 is never called.

turtle.getItemDetail with advanced flag does not return extra data

User Information

Minecraft version: 1.16.5
CC:R version: 1.95.3

Bug Information

In CC:T, running turtle.getItemDetail(anySlot, true) should give more advanced data about an item, including some nbt data for some things. However, this does not happen, and it returns the exact same result to turtle.getItemDetail(anySlot).

Images

The above images should have a lot more data, including a displayName field.

Links

The beginning of the short discussion on discord.

1.17

Screenshot from https://www.curseforge.com/minecraft/mc-mods/cc-restitched

Why are github actions failing?

Why are they failing?

All disks are white in the recipe book

All disks recipes show a white disk as result. This happens both in REI and in the vanilla recipe book.

License on Modrinth page is incorrect

You use a custom license, but on the Modrinth page, it shows ARR as the license rather than CUSTOM.

[Bug] Turtles do not return `mouse_up` event

Useful information to include:

• Minecraft version: 1.16.5
• CC: Restitched version: 1.96.0 hotfix 1
• Detailed reproduction steps: sometimes I can spot a bug pretty easily, but often it's much more obscure. The more information I have to help reproduce it, the quicker it'll get fixed.

turtles do not return mouse up event

Error when trying to use websocket

Useful information to include:

• Minecraft version: 1.16.5
• CC: Restitched version: 1.96.1-rc1
• Logs: https://gist.github.com/TheNolle/aa62595d183fb0005187aa4f099fbbfa
• Detailed reproduction steps: I just followed this tutorial: https://www.youtube.com/watch?v=ohVriD3xiqM

[On my server i enabled http and all so it should work]

Got this problem: bios.lua:51: bad argument (function expected, got table)
Can't find solution anywhere

If you can help, cause it should work normally

Shift right click to insert disk into disk drive doesn't work

It works on the forge version.

Code that isn't working: https://github.com/Merith-TK/cc-restitched/blob/9b77a4aaeecf4009151533600a442133e3181144/src/main/java/dan200/computercraft/shared/peripheral/diskdrive/TileDiskDrive.java#L74-L84

Printed Paper only faces North

Useful information to include:

• Minecraft version: 1.16.5
• CC: Restitched 1.96.1-rc1
• Detailed reproduction steps: paper in item frame, this works for paper bundles as well
• 

[BUG] Turtles Do not respect Land claim mods such as GetOffMyLawn and Flan

Useful information to include:

• 1.16.5
• 1.95.3 beta (whatever is currently used in the AOF3 modpack
• N/A
• Get the GOML mod, and open to LAN on a world with a friend. Allow the friend to make a claim anchor using GOML and then make yourself a mining turtle. Attempt to use the mining turtle in the claim (make sure you are not trusted in the claim).
• Expected Behavior: Nothing should be mined
• What actually happens: Blocks are mined, thus bypassing the claim

os.pullEventRaw doesnt work as expected

Useful information to include:

• Minecraft version 1.16.5
• CC: Restitched version 1.94.0
• Detailed reproduction steps: run this in lua: os.pullEventRaw"a"and try to terminate, it doesnt stop you.

Shaders Break Monitors

Useful information to include:

• MC: 1.16.5
• CC:R: 1.94.1-beta

Certain Shaders break monitors

• BSL 8.0.01
  • Colors are askewed, most notable with "black", turns grey
• Complimentary Shaders 3.11
  • Same as BSL
• SEUS Renewed 1.0.1
  • Monitors show background color, thats it.

Please do add onto this list with symptoms from other shaderpacks

[Bug][Unreproducable] crash when moved further than menu can remain open

Useful information to include:

• Minecraft version: 1.16.5
• CC: Tweaked version: 1.95.3
• Detailed reproduction steps: Leaving access range while inside computer causes crash

You know how when you are moved far enough away from something like a chest or crafting table, how you are pulled out of the menu?

yeah that dont happen. Buddy teleported me across dimensions while doing admin stuff, without warning (like he usually does, and yes it annoys me, but ive learned to deal with it), and I just crashed

https://mclo.gs/gELQgtU
crash-2021-06-02_14.09.56-client.txt

[Bug] Config File Incomplete

he config methods need a rewrite to make them work, PR's welcome

Improvements to the default resource pack

The default texture pack of CC:R is an overhaul of ComputerCraft's textures inspired by 3prm3's pack. It was made in a few days with not much thought put into it, so there is definitely a lot to improve. It also makes some bold choices, which I think should be discussed as they are now seen by everyone downloading this mod.

I have created a workflow with Python and Krita that allows me to iterate a lot quicker, so I will be able to respond to feedback and show mockups.

I made this issue so people can suggest changes and discuss the texture pack, so feel free to post your opinions!

Add the compatibility with dpaste

Add the possibility to use dpaste instead of pastebin.com
Like
https://dpaste.com/api/v2/
https://paste.mozilla.org/

Inspect not working

function InspectTest()
    local success, blockInfo = turtle.inspect()
    print(blockInfo.name)
    print(blockInfo.metadata)
end

I don't manage to get metadata. like getting wheat level

Crash when activating piston

Minecraft 1.17.1
CC: R 1.97.1-beta
Fabric API 0.40.8+1.17

Crash Report: crash-2021-10-14_01.21.48-server.txt
Log: latest.log

Reproduction Steps:

1. Activate a piston (i.e. power it with redstone)
2. Game crashes

[Bug] `getItemDetail(slot,true)` causes server crash

Useful information to include:

• Minecraft version: 1.16.5
• CC: Restitched version: 1.96.1-beta
• CrashLog: https://mclo.gs/l6v3osv
• ServerLog: https://mclo.gs/WInihym
• Detailed reproduction steps: in a turtle. on a dedicated server, put an item in a turtle inventory and then run getItemDetail(1,true),

this only happens on server environments

Turtles do not send Mouse Up event on Servers

Useful information to include:

• Minecraft version: 1.16.5

• CC: Restitched version: 1.96.1-rc1

• Logs: no errors in log

• Detailed reproduction steps:

while true do
 local ev = os.PullEvent()
 print(ev)
end