mestrona/aqbanking-php

A wrapper to use AqBanking CLI from a PHP, for example to fetch bank transactions via HBCI / FinTS

aqbanking-php's Issues

New Parameter disables to read from SepaTransfer

Hi,

this new line:

aqbanking-php/src/AqBanking/Command/RenderContextFileToXMLCommand.php

Line 20 in 576442b

. ' --transactiontype=statement' // we are only interested in statements, not notedStatement and so on

Actually disables to read the result set from a SepaTransferCommand. For both the sepa transfer and fetch balance statements the same RenderContextFileToXMLCommand is used to get the xml. I would like to remove this parameter and make SepaTransferCommand working again.

Add more non-problematic strings to ResultAnalyzer

In src/AqBanking/Command/ShellCommandExecutor/ResultAnalyzer.php

This should be added:

    '/===== Getting Certificate =====/',

This might as well be needed on some setups - it does not seem to be critical - but there might be problems with Unicode Characters. Maybe we need a strict- and not-so-strict-mode

    '/Plugin "aqebics" not found/',
    '/Could not load backend "aqebics"/',
    '/Plugin "de" not found./',
    '/BankInfo plugin for country "de" not found/',

Transaction <> Account

Transaction should not convert local* and remote* values into an Account entity.

1. Account is an AqBanking Account, with mandatory BLZ as bankCode, which is needed for requests.
2. "Account" from Transaction is more like a "BankingContact" without any mandatory "BLZ", eg. bankCode is the BIC an accountNumber the IBAN
3. The fetched fields depends on download mode. "CAMT" is different from "not CAMT"
4. What is specified as "localName" in Transaction has nothing to do with the real local "Account" oder "User", it is what the other party (remote) has entered in the "Empfänger" field
5. Some fields from a Transaction are omitted by parser, but should not, all fields should be there.

Possible solution:

• construct the Transaction with a array of key,values from transaction xml or direct from xml content.
  • Transaction::fromXML('xml content')
  • Transaction::fromArray('array<key, value>')
  • new Transaction('array<key, value>')
  • or similar
• use magic getters __get('key of transaction data')
• Do not convert local* and remote* values to an (AqBanking) Account entity.
• The true local* is provided by the accountInfo node
• turning value into a Money Object by its getter. getValue() => return Money …

Builds are failing

https://github.com/Mestrona/aqbanking-php/actions/runs/7100180749/job/19325710701

@grummbeer mind having a look :-) ?

Should SetAppropriateITanModeCommand removed?

Should the command SetAppropriateITanModeCommand be removed or deprecated?

As far i can see, this "command" makes no sense. I'am not sure if this is doing what expected.

• does not work, wrong command
• handle with HBCIVersion but set a itanmode?
• is not a aqbanking command. It is a collection of commands, more like a function of a (userland/api) controller.
• if an available ITanMode is set, is it the one the user wants/is ready to use?

for example

- 6910 (F910/V6/P2): HHD1.3.0 (chipTAN manuell) [available]
              ^
              This is recognized as "HBCIVersion"? Is it the HBCI-Version?

My HBCI Version is '300', so …

Is Account missing a IBAN property?

These two tests fail

aqbanking-php/tests/ContextXmlRendererTest.php

Line 17 in 67f80c3

public function can_render_transfers()

aqbanking-php/tests/ContextXmlRendererTest.php

Line 45 in 67f80c3

public function can_render_transactions()

Because ContextXmlRenderer::getTransactions() set the IBAN as accountNumber to the Account class.

• What is expected as the accountNumber? Kontonummer or IBAN?
• getTransaction() should not set the IBAN as accountNumber?
• Account needs a IBAN property which could used by getTransaction()?

@amenk do you have some suggestions?

Get Tests Running on Travis again / or use GitHub Actions

Now that @eporsche fixed the tests, we should run them automatically again

Compatibility with AqBanking 5.99.30beta

The recent AqBanking version has several changes in interfacing

• duplicate users can be created
• Commands expect the integer user ID, so after creating that one we have to fetch it
• to be continued ...

Deprecation warning

Getting this with PHP8.1 & aqbanking-php 4.0.0

/bin/php8.1 /home/amk/alex/mestrona/workspace/mbank/mbank default
Config code = default
Fetching all available transactions from the bank
Fetching ...
PHP Deprecated:  Optional parameter $valutaDate declared before required parameter $customerReference is implicitly treated as a required parameter in /home/amk/alex/mestrona/workspace/mbank/vendor/mestrona/aqbanking-php/src/Transaction.php on line 12

Deprecated: Optional parameter $valutaDate declared before required parameter $customerReference is implicitly treated as a required parameter in /home/amk/alex/mestrona/workspace/mbank/vendor/mestrona/aqbanking-php/src/Transaction.php on line 12

Make result analyzer print only faulty error messages

So it's easier to debug

Potential Bug: "-" are sometimes missing in the purpose field

I am using mbank and this library,
I have purposes like (send from the own account by myself)

2023-11-01 2023-11-02 2023-11-03 2023-11-04

but in my app seemingly random, some "-" are missing and replaced by a space.

2023-11-01 2023-11-02 2023-11-03 2023-11 04

In the webinterface of the bank it looks fine.

Did anyone else notice this behaviour?

@grummbeer maybe?

I will try to investigate further when there is time...