metabase/macaw

A Clojure wrapper for JSqlParser 🦜

macaw's Issues

Alias removal is over-eager; removes tables that are shadowed

(deftest tables-with-complex-aliases-test
  (testing "With an alias that is also a table name"
    (is (= #{"user" "user2_final"}
           (tables
            "SELECT legacy_user.id AS old_id,
                    user.id AS new_id
             FROM user AS legacy_user
             OUTER JOIN user2_final AS user
             ON legacy_user.email = user2_final.email;")))))

Use schema information from SELECT clause

If you have something like

select public.towns.id from towns

Macaw won't catch that towns must have a schema of public in :tables

Support renaming DB table schemas

(in the same way that you can rename columns and tables)

Add Malli schemas

Bryan made the cogent suggestion to add Malli schemas to function metadata as a means of documentation and we've been planning for a while to Malli-fy everything. All public functions and constants should have schemas.

Accept fully-qualified columns and tables for renames

Instead of just taking a column/table name, replace-names should take {:table "foo" :column "bar" :schema "baz"} maps

Support renaming aliases

Support parsing data-modifying statements in WITH

This is legal in Postgres

But fails

(deftest complicated-mutations-test
  (is (= #{"delete" "insert"}
         (mutations "WITH outdated_orders AS (
                       DELETE FROM orders
                       WHERE
                         date <= '2018-01-01'
                       RETURNING *
                     )
                     INSERT INTO order_log
                     SELECT * from outdated_orders;"))))

with

macaw.core-test
1 non-passing tests:

Error in complicated-mutations-test

expected: (=
	   #{"delete" "insert"}
	   (mutations
	    "WITH outdated_orders AS (
                       DELETE FROM orders
                       WHERE
                         date <= '2018-01-01'
                       RETURNING *
                     )
                     INSERT INTO order_log
                     SELECT * from outdated_orders;"))

   error: net.sf.jsqlparser.JSQLParserException: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "DELETE" "DELETE"
    at line 2, column 24.

Was expecting:

    "WITH"


	  

find columns in GROUP BY

SELECT
    count(id)
FROM
    orders
GROUP BY user_id

finds id but not user_id

Record which part of a query each column comes from

Handle case/quoting when replacing names

Similar to the work done in metabase/metabase#41781

When we call replace-names, we should handle case and quoting correctly. Currently it depends on an exact string match.

Finish repository setup

• Add secrets:
  • GITHUB_TOKEN
  • CLOJARS_USERNAME
  • CLOJARS_PASSWORD
• Set up Clojars
  • (secrets as above)
  • Uncomment deploy.yml, edit if needed