metov/openeditor

Edit files with your $EDITOR, like git commit does.

openeditor's Issues

edit_temp with no file name tries to edit directory

Running the following:

python -c "import openeditor; print(openeditor.edit_file())"

Results in IsADirectoryError. The problem is line

openeditor/openeditor.py

Line 34 in aae3cd3

tfpath = Path(td.name) / name or "tempfile"

. The intent was tfpath = Path(td.name) / (name or "tempfile") but the actual behavior is tfpath = (Path(td.name) / name) or "tempfile".

FileNotFoundError when using an editor command with spaces

The following works:

VISUAL="vim" python -c "import openeditor; print(openeditor.edit_temp('contents', 'myfile'))"

The following doesn't:

VISUAL="vim -n" python -c "import openeditor; print(openeditor.edit_temp('contents', 'myfile'))"

Instead we get FileNotFoundError: [Errno 2] No such file or directory: 'vim -n'

This issue is particularly a problem on OS X, where often subl -w (Sublime Text with the wait argument) is the preferred command. The problem is likely because https://github.com/metov/openeditor/blob/master/openeditor/lib.py#L20 expects the arguments to be chopped up, but we are doing the equivalent of subprocess.call(["vim -n", filepath], close_fds=True).

FileNotFoundError when editing a file without contents

The following succeeds:

python -c "import openeditor; print(openeditor.edit_temp(contents='hello'))"

but this gives FileNotFoundError:

python -c "import openeditor; print(openeditor.edit_temp())"