metricmike / simrep Goto Github PK

View Code? Open in Web Editor NEW

2.0 4.0 1.0 136.57 MB

Home Page: http://simrep.herokuapp.com/

Ruby 68.81% CSS 1.92% HTML 27.27% JavaScript 0.82% CoffeeScript 0.03% Shell 1.15%

simrep's Introduction

###A unified system for managing players, characters, and story assets in SimTerra.

SimRep is intended to model and automate actions that take place behind-the-scenes including:

learning skills
tracking event attendance
purchasing equipment
spending time units

This project is fueled by buzzwords, duct tape, and hype.

simrep's People

Contributors

Stargazers

Watchers

Forkers

gulbrandr

simrep's Issues

Posting bank transactions in admin view 500s

Redirecting to "bank_items" instead of "bank_accounts"

Greater Vitality changed cost

Rebuy is now +1 instead of +2

~24 need refunds.

style admin_character#edit/new for inlined table

activeadmin/activeadmin#1097

Deaths are loosely scoped to events

Right now they're based on weekend which is a pure date. This wasn't an issue with a single-chapter game, but the logic needs to be reviewed to ensure that it's compatible with multiple chapters.

Bonus Experiences are getting date_awarded wiped

See #95

Holurheim Starting XP?

I am not 100% about new characters. I believe they start counting at 71 xp, but they should start at 31 and have 40 added afterwards.

Waivers Upload

Allow SimRep to maintain liability waivers

Create folder in Google Drive
Add Refile (or whatever)
Add html to #users/edit

Default sorts on everything and also scope to current event

A LOT of associations are duplicated

Example:

Joel Adams contributed 3 times to the Bastion Embassy Project
Character.find(60).projects has 3 Bastion Embassy Projects, even though they all point to the same record.

New players sometimes don't make new users, and too many pages rely on a character having a user

Make a character without a user
Add that character to an event
Go to that event's admin page
Cry

Characters with < 3 events might be borked

https://rollbar.com/simrep/simrep/items/398/

Add a perm-chance over time chart to the character sheet

Lots of "But why am I still at 10%, my last death was a year ago" questions

Facebook / Email mismatches

User is created manually with an email from waivers.
User creates an account with Facebook with a different email.
User cannot see their character!

PaperTrail stores a create and an update on new characters?

See "Marty" / characters#269

npc shifts aren't paid when awarding event attendance

DateTimePicker requires a page refresh before it's active

Sort "table_for" in AA through associations

The following code should allow you to sort by character name when you click on a 'Character Name'.

ActiveAdmin.register Event do
  controller do
    def scoped_collection
      super.includes :characters, :character_events
    end
  end

  sidebar "Attending Characters", only: :show do
    table_for event.character_events.order(params[:order].to_s.gsub(/(.*)(_)(.*)/, '\1 \3')), sortable: true do
      column(:character, sortable: 'characters.name') { |t| Character.find(t.character_id).name }
      column :paid
      column :cleaned
    end
  end
end

Instead, AA throws a fit:

ActiveRecord::StatementInvalid - PG::UndefinedTable: ERROR:  missing FROM-clause entry for table "character"
LINE 1: ...HERE "character_events"."event_id" = $1  ORDER BY character....
                                                              ^
: SELECT "character_events".* FROM "character_events" WHERE "character_events"."event_id" = $1  ORDER BY character.name desc:

The character_events table has a character attribute, but the events table has a characters attribute. This is probably where the join table is getting mixed up.

Partial NPC Payments

Current workflow expects the following:

Character conducts an NPC Shift - opens and closes themselves.
Character allocates time as necessary.
Staff verifies accurate time, or adjusts as necessary.
Sunday of event, staff awards attendance.

character_event#pay_for_npcing will issue payment for total amounts. It assumes that no more NPCs will occur during that event.

Should have a partial system so payments can happen immediately, or some payments can be issued on Sunday and some can be issued on, say, Tuesday after reaching out to PC in order to complete records.

Reorganize Character[Attribute] and [Attribute] tables for better consistency

Atrius and Charis both buy the 'Added Perks' skill.
Atrius re-buys it.

There are now two rows in the Skills table that read:

id	Source	Name	Cost
1	General	Added Perks	1
2	General	Added Perks	2

Atrius has a CharacterSkill that points to the row1, Charis points to the row2.

This gets worse:
Sophie buys 'Added Perks' (she now has a CharacterSkill that points to row1).
Atrius re-buys 'Added Perks'. row1 now has a cost of 2.
Sophie has 2 Added Perks even though she didn't re-buy and now her skill total is all messed up.

The [Attribute] tables should be a canonical reference, with an additional boolean for re-buyable.
CharacterSkill should have character-specific modifications (cost modifier, times rebought).

Professions should automatically pay when awarding for event attendance

can't remove items from a bank in web interface

duplicate references on HMT tables

Talents used in Project Contributions get wiped after ranking up

Project#112, for example

Replace Project TU contributions with their equivalent CP

PDFs should not callback event attendance

Chroma zeroed out her paid and cleaned for January when she printed the Wednesday after.
Copper added himself to January when he printed the week before March (extra TU he shouldn't have).

Chapter Scoping

Simrep's Back Office/Admin doesn't QUITE scope everything on chapter, because most models are already linked to a scoped model.

For example, Projects are linked to a leader_id/character. A character has a chapter. But when ActiveAdmin loads up, it's Projects Page doesn't check for chapter associations.

A possible solution is adding a default scope to ActiveAdmin. At the time of this writing I haven't yet, but expect to implement something similar for User view.