Comments (6)
The file attachment (main.zip) isn't viewable in GitHub and there's no context explaining what that file is or why it is there.
from imagelab.
I think this is part of an epic, so that "parent" issue should be identified (probably as a Dependent).
from imagelab.
Since this specifically mentions "filters" in the heading, the body of the User Story (e.g., Outcome, Acceptance Criteria) should likewise reference the "filters" package.
from imagelab.
I'd like to be assigned to this issue
from imagelab.
I believe that the current project build meets the intention of all acceptance criteria for this user story; checkstyle reports no errors in the filters package, and each class in the package has appropriate javadoc comments. The third acceptance criteria, "Build runs without checkstyle errors" is not only beyond the scope of this specific issue (as there are other packages in the project), but is also contrary to the newly revised issue #32 which states that "TODO" checkstyle 'errors' are acceptable.
This is the result of running checkstyle against the current build of ImageLab:
As such, I believe that this issue can be closed.
from imagelab.
Great! Thank you for verifying the acceptance criteria!
from imagelab.
Related Issues (20)
- [UserStory] Fix issue with loose audio threads HOT 1
- [Bug] Attempting to open a non-image filetype will freeze the program HOT 3
- [Bug] Cancelling out of "Open Image" file explorer makes the program unresponsive HOT 2
- [UserStory] Document the libcanberra-gtk-module for the Program Dependency HOT 1
- [User Story] Halting of Music After the Image has Been Closed or a New Image is Played HOT 2
- [Bug] Program Cannot Be Closed When Music Is Playing HOT 3
- [UserStory] Add Documentation Detailing Product Features HOT 1
- Error when selecting cancel on the save image window. HOT 1
- [Bug] Issue running ImageLab on Linux using Java 11 HOT 4
- [UserStory] Add Documentation on Java Version Dependency HOT 1
- [UserStory] User doesn't want there to be a problem when canceling out of the save window. HOT 4
- [UserStory] The play() function from ImgProvider should be in it's own class HOT 1
- [UserStory] Notify Users of an unrecognizable file type and let user select a new file HOT 8
- [UserStory] Refactor "Play" function implementation HOT 5
- Commented-out Code on imagelab.java - Evaluate if there is intent or if it was a temporary measure HOT 2
- [UserStory] Fix checkstyle errors in all java files HOT 1
- Cannot Apply Filters to Image HOT 1
- [UserStory] UI Opens Images in Tabbed Frames HOT 1
- [UserStory] Development conventions HOT 7
- [UserStory] Make "Play" it's own option in the menu bar HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagelab.