mfenniak/go-osmpbf-filter

Filters OpenStreetMap PBF files using tag-based criteria

go-osmpbf-filter's Issues

Add support for maintaining and filtering on relations

Add support for filtering on node tags

Reading PBF w/ Osmosis & --write-pgsql option fails

After creating a filtered PBF file with go-osmpbf-filter, this error occurs with the file being used by osmosis. The error only appears to happen with --write-pgsql; notably, --write-pgsql-dump works fine. This is not a confirmed bug in go-osmpbf-filter, but given the ubiquity of osmosis over this tool, it's likely something in our code that triggers this error.

$ osmosis --read-pbf file=file.osm.pbf --write-pgsql
[ ... clip ... ]
SEVERE: Thread for task 1-read-pbf failed
org.openstreetmap.osmosis.core.OsmosisRuntimeException: Cannot begin reading in Add stage, must call complete first.
at org.openstreetmap.osmosis.core.store.RandomAccessObjectStore.initializeReadingStage(RandomAccessObjectStore.java:156)
at org.openstreetmap.osmosis.core.store.RandomAccessObjectStore.createReader(RandomAccessObjectStore.java:181)
at org.openstreetmap.osmosis.core.store.IndexStore.createReader(IndexStore.java:151)
at org.openstreetmap.osmosis.core.store.IndexedObjectStore.createReader(IndexedObjectStore.java:96)
at org.openstreetmap.osmosis.pgsnapshot.common.CompactPersistentNodeLocationStore.getNodeLocation(CompactPersistentNodeLocationStore.java:50)
at org.openstreetmap.osmosis.pgsnapshot.v0_6.impl.WayGeometryBuilder.createWayBbox(WayGeometryBuilder.java:155)
at org.openstreetmap.osmosis.pgsnapshot.v0_6.impl.CopyFilesetBuilder.process(CopyFilesetBuilder.java:187)
at org.openstreetmap.osmosis.core.container.v0_6.WayContainer.process(WayContainer.java:60)
at org.openstreetmap.osmosis.pgsnapshot.v0_6.impl.CopyFilesetBuilder.process(CopyFilesetBuilder.java:115)
at org.openstreetmap.osmosis.pgsnapshot.v0_6.PostgreSqlCopyWriter.process(PostgreSqlCopyWriter.java:95)
at crosby.binary.osmosis.OsmosisBinaryParser.parseWays(OsmosisBinaryParser.java:172)
at crosby.binary.BinaryParser.parse(BinaryParser.java:121)
at crosby.binary.BinaryParser.handleBlock(BinaryParser.java:68)
at crosby.binary.file.FileBlock.process(FileBlock.java:135)
at crosby.binary.file.BlockInputStream.process(BlockInputStream.java:34)
at crosby.binary.osmosis.OsmosisReader.run(OsmosisReader.java:37)
at java.lang.Thread.run(Thread.java:679)

Support for latest version of goprotobuf

I had an issue running against the latest version of Google Protobuf (version fcfd82ff952d)

I had to make several small changes to allow it to compile (see my branch as a reference)

Are you interested in updating your version to support these changes?