mgacy/mvvmc-splitviewcontroller

Example project with UITabBarController inside UISplitViewController using RxSwift and MVVM-C architecture.

MVVMC-SplitViewController

Description

Example project with UITabBarController inside UISplitViewController using RxSwift and MVVM-C architecture.

Loads example data from JSONPlaceholder

Coordinators

Screenshots

Requirements

• Xcode 12
• Swift 5
• iOS 12

Links

• Coordinators Redux
• Reactive MVVM
• Taming Great Complexity: MVVM, Coordinators and RxSwift
• CleanArchitectureRxSwift

mvvmc-splitviewcontroller's Issues

Handling coordination result when pushing view controller

Hello, first thank you very much for share you idea about MVVM-C!

I would like to use this approach, but I face such problem like handling coordination result when I push some view controller inside of navigation stack. If I would use present(_ viewControllerToPresent) of second view controller, I will handle cancel tab bar item action and emit some event likes CoordinationResult.cancel, but how I should handle situation with pushing?

Reacting on events from other coordinator

Hello, i'm back to this project after some time but have question about reacting between coordinators. How would you solve situation when i have my button clicked on some Coordinator1(VC-button > binded to viewModel), and i'd like to refresh let's say counting by +1 on another coordinator Coordinator2(VC-countingLabel > binded to viewModel)? This is first case, second one is when coordinators are deeper nested for example: Coordinator1 and Coordinator4 (1/2, 1/4 are nesting levels). So my only ideas are: via dependency, delegates (not the best option i suppose).
Thanks for any reply :)

Leak issue of SignUpViewController

Hi, thanks for a good example of MVVM-C architecture. However, in this demo, the SignUpViewController instance of the SignUpCoordinator did not deallocate when present/dismiss from the LoginCoordinator.

Migrating from Storyboard to view code

Hi @mgacy

Can you please help me with the migration from Storyboard to the view code. In the Reusable.swift file, how should I modify the instance() and instantiateViewController<T: UIViewController>() functions to migrate from using storyboard to using view code.

Thank you

Leak issue

Hello, first of all thank you for this "template", it's been very useful for me, but there is one issue with memory leak/retains. TabBarCoordinator did not deallocate at all with its descendants, when i'm loggin out it stays in memory, and loggin back create TabBarCoordinator again and again. I'm trying to figured it out but no clue at this point, any help? Thanks

Store and use access token with each network request

Hi @mgacy

In order to make my api work, I need to store access token which I get after calling login api. I am storing this access token in the UserStorageManager. Now, I need to use this token in every request (except Login and Signup requests)

For this to work, I would need to somehow obtain access token inside ApiClient, so that I can add it to the configuration of SessionManager. So, I have 2 questions regarding the same:

1. Correct way to obtain Access Token from UserStorageManager inside ApiClient.
2. Correct way to Add separate headers for Login/Signup requests and the rest of the api requests, inside ApiClient.

Thank you.