mhelmetag/gosurf

CLI Client for Surfline

gosurf's Issues

Units should be from the "associated" part of returned data

From Mexico, it seems like Surfline is inferring that I want to see height in meters (for surf and tide height).

gosurf f -r 58581a836630e24c44878fe5 -d 6
Fetching 6 day(s) of forecasts for Cabo...
+-----------+-------------+--------------+-----------+-------------------+
|   DATE    | TIME OF DAY |    RATING    |   RANGE   |     FORECAST      |
+-----------+-------------+--------------+-----------+-------------------+
| 7/9/2022  | AM          | Fair         | 0.9-1.5ft | Waist to head     |
|           | PM          | Poor to Fair | 0.9-1.5ft | Waist to head     |
| 7/10/2022 | AM          | Fair         | 0.9-1.4ft | Waist to shoulder |
|           | PM          | Poor to Fair | 0.9-1.4ft | Waist to head     |
| 7/11/2022 | AM          | Fair         | 0.9-1.2ft | Waist to chest    |
|           | PM          | Poor to Fair | 0.9-1.2ft | Waist to chest    |
| 7/12/2022 | AM          | Fair         | 0.6-1.1ft | Thigh to stomach  |
|           | PM          | Poor to Fair | 0.6-1.1ft | Thigh to stomach  |
| 7/13/2022 | AM          | Fair         | 0.6-1.1ft | Thigh to stomach  |
|           | PM          | Poor to Fair | 0.6-1.1ft | Waist to chest    |
| 7/14/2022 | AM          | Fair         | 0.9-1.5ft | Waist to head     |
|           | PM          | Poor to Fair | 0.9-1.5ft | Chest to head     |
+-----------+-------------+--------------+-----------+-------------------+

I believe this could be fixed by using the associated object returned in the conditions response. It contains the "units" associated to the data.

The Surfline API package this project is using, https://github.com/mhelmetag/surflinef, already supports that here: https://github.com/mhelmetag/surflinef/blob/957d7ec4177276c2b2719522b47cbeb42705b26f/v2/conditions.go#L26

Unkown -> Unknown

gosurf/cmd/forecast.go

Line 96 in 8750447

return "Unkown"

Interactive search doesn't work well for places outside of the US

I think this is because there's a different ordering/hierarchy between US and other places.

Here's an example for EU > France > Normandy.

gosurf search:

Surfline search:

Typo in readme

Sorry if this is not the correct spot or appropriate method. I'm very new to Git

Typo in readme

"To search for regions in Central America, specify regions as the place type (--pt regions) and then provide the area ID (--a 4710)"

(--pt regions)
should read
(--t regions)