Giter Site home page Giter Site logo

mhiz-martha-'s People

Stargazers

 avatar

Watchers

 avatar

mhiz-martha-'s Issues

Thanks for proposing a pull request!

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes) [I don't seem to have permissions for this]

Pull Request Details

Building the gaming services product from the Swift package in Xcode results in compilation errors, whether just building from the package or within the context of a package dependency in an application project. These are the result of missing dependencies for the core and sharing targets in the gaming target definition. Adding these dependencies fixes the issue and allows building the gaming services product.

facebook/facebook-ios-sdk#2194

Test Plan

Test Plan: I cannot do this, but would make sure all build infrastructure automation continues to function as expected, as the dependency graph for the gaming services product has changed.

Originally posted by @johnclayton in facebook/facebook-ios-sdk#2195

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.