mi-schi/phpmd-extension

Contains extra phpmd rules from clean code book and the best practices of my experiences.

phpmd-extension's Issues

SuppressWarnings for ControllerMethodName doesn't work if annotated above Method

it does work when its annotated above the class, but that means it will be suppressed for all methods within the controller. i only want to supress the warnings for a few methods in the controller. Please take a look into this. Thank you.

rulesets/cleancode.xml in phpmd.xml does not work.

by adding the line <rule ref="../../../../../../rulesets/cleancode.xml" /> to the phpmd.xml file, the tool breaks. if i remove this line from phpmd.xml everything works just fine.

please fix <3

Remove composer.lock

At the moment the phpmd/phpmd package is stuck on the 2.10.1 version due to the composer lock being committed to the repository. Would it be possible to remove it or at least update it?
From my understanding the packages which are being distributed shouldn't have lock file committed and versions should be forced by composer.json

Packagist repository

Hello

Do you consider adding this package to Packagist repository?

Reminder: Überdenken der returnStatement-Regel

Zur Erinnerung hier fesgehalten. Überdenken der Sinnhaftigkeit von folgender Violation:
A return statement line should only contains Variable,MemberPrimaryPrefix,Literal,FunctionPostfix,Array,ArrayIndexExpression,CastExpression,AllocationExpression,CloneExpression. It increase the reading rate.

Controller Action Naming

Don't add the Action suffix to the methods of the controller actions.This suffix became optional when annotations were introduced for controllers. In modern Symfony applications this suffix is neither required nor recommended .

PHP 7.4 support

Using typed properties:

<?php
class User {
    public int $id;
    public string $name;
}
?>

Results in:
Try to avoid public class variables. Use Getter to access the variable. It supports the principle of privacy.

combine phpmd-extension and git hook

Hello,

great work.
Is there a way to combine phpmd-extension with a git hook ?
I will define same standards and looking for a git hook.
I will use
https://github.com/edorian/php-coding-standard-generator
to define standards in the phpmd.xml.

Your sincerly

Stephan

rule for testing phpdoc

Hi Michael,

I'm looking for a role for phpmd.
This role should identify if a script has been sufficiently documented.
I think that the number of lines of a file in the relation of the comment lines must be evaluated. Can you help with an idea?

Greeting Stephan