Comments (7)
@devvmh where would be invoke :'rvm:use', ENV.fetch('RUBY_VERSION', 'ruby-2.3.1')
added then?
from mina-sidekiq.
I do no longer work on rails projects at the moment, but I would accept pull requests.
from mina-sidekiq.
mina
now has 2 tasks: local_environment
and remote_environment
. In other words, all tasks that depend on environment
are to depend on remote_environment
. If I understand you correctly.
Or maybe dependency on environment
task is to be removed altogether. Which is not clear from the docs.
from mina-sidekiq.
I think the idea is that in 0.3 you'd have a task in your personal deploy.rb that might look like
task sometask: :environment do
And since #569 you keep that task in your deploy.rb, you just remove the dependency on :environment.
task :sometask do
I would not say that the environment task is deprecated. We just don't use it anymore.
What issue are you having? I left the organization with the private repo I used mina-sidekiq in, but I was able to deploy fine with no changes to the current mina sidekiq. I just had to update our deploy.rb when upgrading to 1.x
from mina-sidekiq.
Ohh, I see where there might be a problem - mina has deprecated environment. I was thinking we were talking about a PR in mina-sidekiq.
Regardless, I was able to make it work last year using the existing mina-sidekiq code.
Do you have an issue that you're able to solve with #27 ?
from mina-sidekiq.
@devvmh sort of, it displays deprecation warning.
from mina-sidekiq.
OK, that makes sense. I'll help to review your PR
from mina-sidekiq.
Related Issues (17)
- Don't know how to build task 'sidekiq:quiet' HOT 2
- sidekiq_concurrency overrides concurrency in config sidekiq.yml HOT 1
- Request for a Release for Latest Fix : Do not pass sidekiq concurrency parameters by default HOT 2
- Sidekiq is not properly setup with bundler HOT 16
- undefined method `set_default' for main:Object (NoMethodError) HOT 2
- [Question] - Does pending jobs get deleted when we deploy new release of our Rails app? HOT 2
- Could not locate Gemfile or .bundle/ directory ( ERROR: Deploy failed. ) HOT 11
- sidekiq:quiet fails on first deploy HOT 5
- require environment HOT 11
- invoke :'sidekiq:restart' doesn't work in on :launch do block HOT 1
- Sidekiq 6.0 fail HOT 3
- Problem sidekiq 6 HOT 4
- Cannot restart sidekiq HOT 36
- Don't know how to build task 'remote_environment'
- How to enable sidekiq.yml HOT 4
- Sidekiq not started HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mina-sidekiq.