Giter Site home page Giter Site logo

Comments (7)

Mic92 avatar Mic92 commented on August 22, 2024

@devvmh where would be invoke :'rvm:use', ENV.fetch('RUBY_VERSION', 'ruby-2.3.1') added then?

from mina-sidekiq.

Mic92 avatar Mic92 commented on August 22, 2024

I do no longer work on rails projects at the moment, but I would accept pull requests.

from mina-sidekiq.

x-yuri avatar x-yuri commented on August 22, 2024

mina now has 2 tasks: local_environment and remote_environment. In other words, all tasks that depend on environment are to depend on remote_environment. If I understand you correctly.

Or maybe dependency on environment task is to be removed altogether. Which is not clear from the docs.

from mina-sidekiq.

devvmh avatar devvmh commented on August 22, 2024

I think the idea is that in 0.3 you'd have a task in your personal deploy.rb that might look like

task sometask: :environment do

And since #569 you keep that task in your deploy.rb, you just remove the dependency on :environment.

task :sometask do

I would not say that the environment task is deprecated. We just don't use it anymore.

What issue are you having? I left the organization with the private repo I used mina-sidekiq in, but I was able to deploy fine with no changes to the current mina sidekiq. I just had to update our deploy.rb when upgrading to 1.x

from mina-sidekiq.

devvmh avatar devvmh commented on August 22, 2024

Ohh, I see where there might be a problem - mina has deprecated environment. I was thinking we were talking about a PR in mina-sidekiq.

Regardless, I was able to make it work last year using the existing mina-sidekiq code.

Do you have an issue that you're able to solve with #27 ?

from mina-sidekiq.

x-yuri avatar x-yuri commented on August 22, 2024

@devvmh sort of, it displays deprecation warning.

from mina-sidekiq.

devvmh avatar devvmh commented on August 22, 2024

OK, that makes sense. I'll help to review your PR

from mina-sidekiq.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.