Giter Site home page Giter Site logo

require environment about mina-sidekiq HOT 11 CLOSED

mic92 avatar mic92 commented on August 22, 2024
require environment

from mina-sidekiq.

Comments (11)

Mic92 avatar Mic92 commented on August 22, 2024

I will have a look at this this evening.

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

Thanks!

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

One question on the side, when I deploy I see:

-----> Stop sidekiq
       Sidekiq is not running
-----> Start sidekiq

This is a bit confusing to me, I think sidekiq is actually running, but maybe it stops when we do sidekiq quiet on the start of deploy? Can you confirm this? The message is a little bit confusing since to me it indicates like something is wrong and sidekiq wasn't running before I started to deploy, but I don't think that's the case.

from mina-sidekiq.

Mic92 avatar Mic92 commented on August 22, 2024

The message is echoed, if the pid file was not found. I made the message a little more verbose. I implement everything but the processes id. Because this option conflicts with multiple processes (sidekiq_processes). You can override the sidekiq cmd, if you need this feature.

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

Hm it could actually be because you used a relative path for the PID param (-P), I can test it out when you're done with that.

I didn't understand what you meant though, what do you mean with this option conflicts... Which option?

from mina-sidekiq.

Mic92 avatar Mic92 commented on August 22, 2024

The gem provides an option called sidekiq_processes, which sets the number of processes that are spawned on a system.

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

Ah I see. Well I haven't changed the mina default, but I did set concurrency to 2 in my sidekiq.yml. However I am using JRuby so I'm pretty sure that just means two threads, since there is no reason to use multiple processes on JRuby.
What I'm trying to say is I don't think I have multiple sidekiq processes.

from mina-sidekiq.

Mic92 avatar Mic92 commented on August 22, 2024

The concurrency option always increase the number of threads, even on Ruby MRI.
Maybe I could increase the process id with each process spawned by the sidekiq_processes loop.
I think it is a safe assumption to say, that the sidekiq spawned by mina is the only sidekiq for an application on the target host.

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

I don't understand why it matters how many threads there are, if there is just one processes? Threads don't have PIDs..
It's probably always a good reference to look at how the capistrano recipe does it.

from mina-sidekiq.

Mic92 avatar Mic92 commented on August 22, 2024

done.

from mina-sidekiq.

mrbrdo avatar mrbrdo commented on August 22, 2024

Thanks! I'll let you know if I have any issues.

from mina-sidekiq.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.