michaelaltmann/get-your-refund

get-your-refund's Issues

squish: fails if sorting my assigned clients

So squish works on my "All clients" tab and my "Assigned clients" tab. When I sort them (by clicking the little headers at the top of the columns), squish still works on the "All clients" tab, BUT if I sort the "Assigned clients" tab, squish suddenly fails. Weirdly, if I go to the "All clients" tab and check "Assigned to me", I can sort them and squish successfully applies.

Since there's a workaround and it's not that important anyways, this isn't too big of an issue :) - Ashley, greeter

squish: Make header text-checking more robust

Should probably add

    let text = column_headers[ header_i ].innerText.toLowerCase().trim();

Originally posted by @BryceStevenWilley in #23 (comment)

squish: create a function for setting number of days

Minor, and optional: these 3 calls would probably be clearer (and easier to maintain) as a function, called 3 times.

Originally posted by @BryceStevenWilley in #23 (comment)

Make combo bookmarklet that will include all currently viable bookmarklets

I've done a bit of work on this in https://github.com/michaelaltmann/get-your-refund/tree/all_links, but haven't had the bandwidth to do more for a bit.

Image Gallery doesn't save filenames for doctype "Employment tax docs.."

Have had this issue for a bit. Image Gallery is awesome and a big time saver. I've noticed that when I'm trying to rename docs of type "Employment tax docs [...]", despite clicking save, sometimes the name doesn't save. Haven't had this problem for other document types (ID, 1099-bla, etc).

Og name:

New name (and have clicked save):

Result upon refreshing the page:

Easy workaround is to manually click "Edit" on each of the docs and rename them on that page rather than using Image Gallery, just takes slightly longer.

I don't know JS but just from scanning thru the code, the doctype in the dropdown (for ImageGallery and elsewhere) is called Employment tax documents (W2's, 1099, etc) but in the userscript it's ['Employment', "Employment tax docs (W2's, 1099)"]. But idk if that's relevant.

Request Info Template Swap

The request info text/email template leaves a bit to be desired. I usually change a lot of the wording to be more friendly, descriptive, and shorter (mostly for SMSs when necessary).

From what I understand it would be pretty easy to change the template on the site, but we don't seem to have eng support there, and lots of people might have differing opinions on what they want the template to say.

Would be nice if we can auto replace this template with some user defined text. I'm thinking maybe from a Github Gist, since it's easily editable by people, we can get the raw text easily, and we can't get local files.

Adjust `@match`es to remove `en`?

Our ==UserScript== section in our scripts has what looks like @match keys. I'm not sure what this section is or what that does, but our matches all include https://*.getyourrefund.org/en/. It looks like we can have wildcards in there. Can we use https://*.getyourrefund.org/*/ instead to be more permissive about the language of the page?

Problem: It's hard to see all the information you need at a glance

1. You have to trace each client across a whole row, which includes scrolling the client name out of view.
2. Some of the information is presented in ways that's hard to think about (like dates and times)
3. You often have to go into a client's page to see what it is that you need to do with them. It takes a bunch of clicks and wastes a lot of time.

Things that greeters say they want to see improved:

1. [business days may not be possible under current constraints] When waiting for a response, # of BUSINESS days since last response
2. Days in numbers in general as opposed to dates
3. Who is assigned to a client
4. Status of the client
5. General width of the page

See this doc for brainstorms.

Update assignment bookmarklet

(Should some of these be broken out into their own issue?)

• It should have 1-click assign-to and unassign. We think it may have broken with one of the eng changes
• Current Problem: the bookmarklet makes the greeter name appear 2x in the assignment dropdown
• Suggested updates:
  • Remove the double listing of greeter name in the dropdown
  • I believe the alphabetical component will also be excess code now
  • Consider whether we want to invest effort into fixing the 1-click functionality
    • Katie has noticed this is helpful to have, e.g. to assign 10 clients to yourself directly from the All Clients view
• Bug found by Katie: If you have it filtered as assigned to a user, and you want to un-filter for an assigned user, you can select “ “ at the top of the dropdown and Filter, but the assigned user remains filtered
  • Workaround: Use the “Clear” to remove all filters
• Flag Clients to not work on bookmarklet feedback
• Mary noticed a few that were not flagged appropriately

See doc.

Add clarifying comments about external script deactivated in squish.user.js

Should change this to be TODO: the feature hasn't been implemented because of XYZ

Originally posted by @BryceStevenWilley in #23 (comment)

Problem: Needs attention does not always get added

This is just an issue for historical record so people can see that we acknowledge it, but can't yet do anything about it.

Should be added whenever a client has sent a message and has not received a response. Unfortunately, it looks like that data is not on the assigning page, so a bookmarklet is not the right fit for this.

See issue in original doc.

Partner filtering not working

In one user's browser, tapping the bookmarklet does not trigger the change in the DOM. Has the DOM changed since that was written?

Problem: Greeters remain assigned to clients who are Ready for Review

When moving a client forward, you change the status and think you’re done, but you stay assigned to that client

• Impact: Partners who regularly filter for unassigned won’t see that client
• Workarounds: Greeters have to constantly check that they’ve been unassigned

Suggested in-the-moment solution:

Changing the status to Ready to Review should auto unassign yourself. Potentially could utilize the Take Action bookmarklet, and re-purpose it to unassign yourself on a status change to either Ready for Review, or Not Filing.

After-the-fact solution

May not be necessary with work on this and #11 so wait till the impact of those is assessed. If this is still relevant, make it into its own issue.

Icon warning about the status right next to name or the 'needs attention' dot on the 'Assigned' page and on the 'All clients' page.

See additional notes in doc.

Make sure that the URLs aren't on SMS boundaries

Would show the info right next to the SMS counter; just need a simple URL regex and to note if the 160 (?) mark falls between the regex start and stop. False positives aren't a huge deal.

Remove one 'Take Action' feature list item from page

Greeters are finding it confusing. One inferred that they should be changing all clients back to 'Not Ready'