michaelgwelch/bacnet

A Haskell library for encoding bacnet data

bacnet's Issues

In unfold there is use of exponentiation. Is there a better way?

Instead of (x ^ (256 * len)) would it be quicker and correct to do left shift by 8 bits * len

Switch to another parser framework

I saw suggestions to switch to other parsers (like attoparsec) for use in binary parsing. This was a result of a recent breakage due to changes in parsec.

Based on unit tests and BACnet.Tag.Writer I'm not done

Doesn't look like I made it thru all of the CS tags.

Warnings during compilation of unit tests

Here are the warnings:

Preprocessing test suite 'tests' for bacnet-encoding-0.2.1.0...
[18 of 19] Compiling BACnet.ReaderSpec ( test/BACnet/ReaderSpec.hs, dist/build/tests/tests-tmp/BACnet/ReaderSpec.o )

test/BACnet/ReaderSpec.hs:105:20: Warning:
    Literal 4294967296 is out of the Word32 range 0..4294967295

test/BACnet/ReaderSpec.hs:158:67: Warning:
    Literal 2147483648 is out of the Int32 range -2147483648..2147483647
    If you are trying to write a large negative literal, use NegativeLiterals

The Reader instances all fail on parse error which isn't very useful

Perhaps all Readers should return Maybes?

Probably the easiest although it may clutter up a lot of current definitions.