michannne/graphql-core

A wrapper library for GraphQL.NET that provides additional features to ease enterprise integration

graphql-core's Issues

Add support for all c# value-types and enum types

GenericType works for Model A, containing following member types:

• Int
• String
• Float
• Bool
• Double
• Long

But additional value types, such as char, decimal, byte etc, throw runtime error
Edit: Enum types also throw an error

Expected result
All C# value types are supported

Add support for Guid types

Creating a model such as the following:

    public class Book_WithValueTypes : Book
    {
        public Guid Identifier { get; set; }
        public char Category { get; set; }
        public decimal Dewey { get; set; }
        public byte OwnerCount { get; set; }
        public sbyte Modifier { get; set; }
        public short Value { get; set; }
        public uint Copies { get; set; }
        public ulong Pages { get; set; }
        public ushort AuthorCount { get; set; }
        public BookDescription Info { get; set; }
    }

fails to create Object node as Guid is not supported

Add unit tests for adding user-defined models

Full test coverage should be available for following features:

• Adding User-defined Models
  • Models with value-types
  • Models with enum-types
  • Models with enumerable types
  • Models with user-defined types

Each test must check for:

• Has a wrapper class been generated as a derived type of the GenericType instance of the user's model?
• Can the instance of the GenericType be retrieved from the service provider using the wrapper class type?
• Does the instance of the GenericType have fields? Do they correspond with the user model's fields?
• Is the GenericType queryable after adding it (user can write query statements resolving to the user's model)?
• Can other classes be built on top of the user-defined model? Are those classes resolving the property of the user-defined model correctly?

Add exception-handling

Self-explanatory

Stitching between two non-related models throws an error

Model A has a Model A ID
Model B has a Model A ID and a Model B ID
Model C has a Model B ID and a Model C ID

Stitching via Model A => Model B => Model C throws an Access Denied

Update README to include reference of a GraphQLController

User has been confused about app not working
No documentation showing in GraphiQL and Intellisense not working in GraphiQL

Problem was that user did not have a GraphQLController to handle requests

Expected Outcome
User should know to add GraphQLController to add references
Readme should reference the need to add a GraphQLController to their project
(Maybe this can be simplified?)

Add github.io page

Users should be able to reference a centralized github.io page to read more documentation, see more examples of usage and installation, and tips for usage of the framework.

Make config argument optional

(config) argument of .AddGraphQL() should be optional
If user passes in a configuration, AddGraphQL() should return a null object and build the config passed in
Otherwise, it should return a new builder which can be extended

Simplify Query Argument Syntax

Is your feature request related to a problem? Please describe.
Current query arg syntax is unwiedly, and involves the use of an extension method to convert a C# type into a graph type. Yes, it should be up to the user to supply the correct graph-type, but there should be an easier way so user does not have to think too much of the type or conversions before passing it in.

Describe the solution you'd like
Something simple, and easy for the user without giving up their control of the type being passed, but without conversion, such as:

services.AddGraphQL()
.Query<Author>(
    () => new Query()
    {
        Expression = "author",
        Args = new ArgList() {
			["authorId"] = (long authorId) => {
				DefaultValue = 0,
				Description = "The Author to be searched"
			},
			["bookId"] = (long bookId) => {
				DefaultValue = 0,
				Description = "The Book to be searched"
			},
			["bookName"] = (string bookName) => {
				DefaultValue = null,
				Description = "The name of the Book to be searched"
			},
		},
        Resolver = (context) => authorRepo.GetAll().Where(a => a.AuthorId == (long)context.Arguments["authorId"])
    })
.Build()

Describe alternatives you've considered
Improving the conversion syntax may also be helpful, but the real solution I feel is change how the arguments are added, in GraphQL.NET is equally painful

Add support for cyclical types

Class A references Class B
Class B references Class A

This situation throws a 'Duplicate type class' from app

Expected Outcome
If Class A is already registered, it should not be throwing a duplicate type error. Instead, it should use GenericType in the field prop and pass without looping again over A's properties

Allow virtual fields of GraphQL type to coexist with Stitched field

Stitched fields, which are present on models under a different name, throw error 'Access Violation'

Expected Result
Stitched field should add properly without issue and be resolvable as long as it does not have the same name as any existing field