mickeykay/better-font-awesome

[WordPress] A WordPress plugin that allows you to easily integrate the latest version of FontAwesome.

better-font-awesome's Issues

jQuery Migrate deprecation

Hi!
With WordPress 5+ and the "jQuery Migrate Helper plugin" active, the Helper plugin indicates that Better Font Awesome is dependent on the jQuery "ready" event. The error I get is...

/plugins/better-font-awesome/vendor/mickey-kay/better-font-awesome-library/js/admin.js:11:19: 'ready' event is deprecated

If line 11 in that file is replaced with

jQuery(function(){

I believe that all will be fine.

I hope that you can update your plugin quickly!

Thanks!

FontAwesome icon picker library causing conflict with Divi theme

See: https://github.com/mjolnic/fontawesome-iconpicker/issues/9

Switch to a Grunt/Composer flow for including dependencies (instead of Git submodules)

Switch to a Grunt/Composer flow for including dependencies including:

• Font Awesome fallback

Fatal Error immediately following activation

I havent done anything yet this is just the error i got from uploading, installing and activating beta on wordpress 5.5.1

Next an update for font awesome 1.7.1 was required and error seems to have went away

Beta Testing

Hi Mickey,

I did Basic Testing of your plugin running WP 3.9.1, twentyfourteen and genesis sample theme, all works fine with no issues - I also concurrently ran the plugin "WordPress Visual Icon Fonts" and both worked alongside each other.
Multiple classes applied to the icons works well with the 'fa-' prefix.

For bonus testing, I ran the plugin on WordPress 4.0-beta2-20140805 via VVV - again no issues.

The icon preview area is slightly larger in the visual editor which is a good thing.

Good job!

JsDelivr stopped serving api.jsdelivr.com

In the latest WP plugin v1.7.4 api.jsdelivr.com is still used.

Please consider releasing a new version.
Thank you.

Initialization hook causing conflict with Advanced Custom Fields Font Awesome plugin

The problem is that the BFAL is initializing on plugins_loaded but BFAL isn't initializing actual data until after_setup_theme. In the case of the Advanced Custom Fields Font Awesome plugin, the included BFAL library is being included on a hook right between the two, which means it's trying to grab icon data before any of it is initialized.

Status

• Updating BFA and BFAL to both just work on init (should'a done this from the very beginning - doh)
• Wrote to BFAFA author (@mattkeys) with a heads up. Will keep posted.

To Do

• Update @bgardner and anyone else using the BFAL.

Translation .pot

Hi again,

I've updated with the 1.02 version then I've added my better-font-awesome-fr_FR.mo but still no translation.
I can send my po/mo files to you if you want, just tell me where.

regards

Huge set of data inside $shortcode_tags global

Hi Mickey,

Checkout the $shortcode_tags global variable.

<?php
        global $shortcode_tags;
        echo '<pre>'; 
        print_r($shortcode_tags); 
        echo '</pre>';
?>

There are almost 3000 lines of bfa-code in there.

I'm guessing it impacts performance quite a bit. Is it possible to trim this down a bit?

WP.org release versions are different from GitHub release versions

better-font-awesome/better-font-awesome.php

Line 15 in 3d2cf3f

* Version: 1.7.6

https://github.com/MickeyKay/better-font-awesome/releases

Please advise.

Automatic 'testing' updates

@MickeyKay if you add the header GitHub Branch: testing to the testing branch then your beta testers will get automatic updates if they have the GitHub Updater plugin installed. 😉

Make sure your master branch either doesn't have this setting or it's set to GitHub Branch: master.