When calling indent again, re-use same region?

[jdtsmith]

When calling indent again, re-use same region?

[mickeynp]

This is now fixed in master, as it uses combobulate's proffer interface for presenting choices. (though that may indeed throw up other bugs!)

[mickeynp]

Can you supply an example where it "picks up" stray code?

[jdtsmith]

Sure:

def foo():
 [X]if True:
        x = 1
    if not True:
        x = 2

Hit Tab at the [X]:

def foo():
if True:
    x = 1
    if not True:
        x = 2

Hit Tab again and the bottom if block gets swept into the indent:

def foo():
    if True:
        x = 1
        if not True:
            x = 2

I note that the region is not active after each of these indent commands, despite combobulate-python-indent-mark-region=t. If I explicitly mark the region, it constrains the indent as expected. So perhaps the region not remaining active is the issue.

Couple other small points:

• By default, python-indent-line starts with "no change", which means Tab returns you to the current indentation if not already there, leaving indent unchanged. Maybe this could be construed is a mis-feature, but I bet a lot of people are used to it (including me).
• It would be preferable if indent commands preserved column position with respect to the text they are indenting. I.e. after the second Tab above, point is left at the beginning of the line (instead of at column 4, adjacent to the text it just indented). Again, this is the behavior of python-indent-line.

Thanks for your work on combobulate!

[mickeynp]

Huh, I never tweaked this behaviour before. Thanks for reporting it

I'll see about using the region properly; ditto the marking, which of course should work, whether it's visible or not.