Giter Site home page Giter Site logo

Comments (3)

FH-Inway avatar FH-Inway commented on May 7, 2024

Date/time colums used to be formatted as "yyyy-MM-dd H:mm", which would result in the correct order when sorting. However, according to #24 , some users receive the date/time information in a format (e.g. " 31/01/2019 01:10") which could not be deserialized into a DateTime. Which is why the data type for those columns was changed to string in 250cfbe and the data is shown in the ui as it is provided by LCS.

The date/time format is controlled by the language preference of the user in LCS. 2LCS uses Json.NET for parsing the JSON data returned from LCS. By default, Json.NET uses the invariant culture (which corresponds with the en-US culture, which is the "English (United States)" language preference in LCS).

One was to solve this would be to get the language preference of the user from LCS.
@TomekMelissa Is there an LCS API that could be used to do that?

Another way would be to provide a parameter in 2LCS were the user could set the language preference.

from 2lcs.

fraga avatar fraga commented on May 7, 2024

@FH-Inway maybe best way for now is to get system user settings really. In a way should be the same as the settings in LCS.

from 2lcs.

FH-Inway avatar FH-Inway commented on May 7, 2024

@fraga Thanks for the suggestion. Yes, I had a similar thought. I think we still would need a fallback, since probably many users have a non-us system setting, but never bothered with changing the language preference of LCS.
Even then, there could be an issue if a user has both a non-us system setting and LCS language preference, but both are not the same (I admit, a bit of a theoretic scenario).
My preference would be to get the language preference from LCS, maybe by scraping it if there is no API.

from 2lcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.