Comments (5)
Never mind I overlooked the implementation and when I did the async piece that should've left as sync and we would still use the Result as @DjLysy implemented is correct.
Looking forward, I think we need to refactor the backgroundworker and replace it with Task. Since this is all probably going to go away with One experience (one admin) I would leave it for now!
Thanks @DjLysy for the contribution!
PS: I'm always out of my depth with C# too, always learning!
from 2lcs.
Thanks for reporting the issue and providing the fix in pr #94 as well, much appreciated! I merged it and released 0.49.0.
I was not even aware that 2LCS could be used like that. Seems something that we should add to the documentation.
Just to provide context for the future, this functionality was added in #66, while the async stuff was added in #75
@fraga Let us know if you see any issues in undoing async for RDPConnect.
from 2lcs.
Hey this is great!
What if we add the sync version as it was and just wrap that in async instead of just removing the async? Let me know your thoughts.
from 2lcs.
Could you explain a bit more on how this could be done? I'm a bit out of my depth with C# and async.
From what I can tell, since BackgroundWorker
is used to call OnWorkerDoWork
, it already runs asynchronously?
Lines 57 to 73 in 4b89a4b
from 2lcs.
@fraga Thanks for looking into it. I agree, the LCS days are numbered and so is 2LCS. But while we still have it, it is work keeping it alive. Will keep the Task refactor in mind in case we revisit that part again.
from 2lcs.
Related Issues (20)
- Refresh all function HOT 1
- Crash when LCS is not accessible HOT 2
- .Net core
- Version 27 & 28 are unstable HOT 8
- change LCS login HOT 2
- Refresh instances for project - Not working on Self service environments
- RDP in full screen HOT 4
- Data region HOT 1
- New feature. Secrets expired
- LCS will start returning HTTP 429 Too Many Requests HOT 3
- Adding access to Database on Tier2
- Region support HOT 9
- This repo is missing important files HOT 1
- .NET core and Process.start HOT 3
- :bug: Date/time fields in grids are sorted alphabetically HOT 3
- :children_crossing: Improve visibility of application icon in Windows dark mode.
- Can't start or stop CHE instances HOT 5
- 🚸 Auto refresh cloud-hosted instance entry after start/stop until instance is Deployed/Stopped
- Can't get a list of packages for MS-hosted environments HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2lcs.