microsoft/accessibility-insights-windows

Accessibility Insights for Windows

Accessibility Insights for Windows

Accessibility Insights for Windows is the project for Accessibility tools on the Windows platform.

Installing Accessibility Insights for Windows

You can download and install the application from https://accessibilityinsights.io.

Building the code

You can find more information on how to set up your development environment here.

1. Clone the repository

• Clone the repository using one of the following commands

  git clone https://github.com/Microsoft/accessibility-insights-windows.git

  or

  git clone [email protected]:Microsoft/accessibility-insights-windows.git

• Select the created directory

  cd accessibility-insights-windows

2. Open the solution in visual studio

• Use the src/AccessibilityInsights.sln file to open the solution.

3. Build and run unit tests

4. Build the MSI project

The MSI project is used to package all the code into an installer that can be used to install Accessibility Insights for Windows. This is not a required step. By default the MSI project is not built in either configuration. Note: The MSI can only be built in the Release config.

• The MSI project requires WIX. WiX is a modern SDK that restore will automatically download from NuGet. Learn about the Wix toolset from http://wixtoolset.org/.
• To build the MSI locally, set build configuration to Release.
• Find the MSI project in the solution explorer under the packages folder.
• Right click on the MSI project and select Build.
• Once the build is complete, the MSI can be found at \src\MSI\bin\Release.

More Information

Visit the Overview of Accessibility Insights for Windows page.

Testing

We use the unit test framework from Visual Studio. Find more information in our FAQ section.

Contributing

All contributions are welcome! Please read through our guidelines on contributions to this project.

FAQ

Please visit our FAQ section to get answers to common questions.

Data/Telemetry

By opting into telemetry, you help the community develop inclusive software. We collect anonymized data to identify the top accessibility issues found by users. This will help focus the accessibility tools and standards community to improve guidelines, rules engines, and features.

This project collects usage data and sends it to Microsoft to help improve our products and services. Read our privacy statement to learn more.

Reporting security vulnerabilities

If you believe you have found a security vulnerability in this project, please follow these steps to report it. For more information on how vulnerabilities are disclosed, see Coordinated Vulnerability Disclosure.

accessibility-insights-windows's Issues

[BUG] Telemetry for creating bug does not distinguish GitHub/Azure DevOps

Please check whether the bug has already been filed.

Describe the bug
Telemetry does not distinguish when a bug is created if it was created to GitHub or Azure DevOps. Understanding usage of this feature is important for success metric of the new feature and can help in the future to take decisions.

Expected behavior
Telemetry distinguishes if a bug was filed in AzureDevOps or GitHub (no other information)

Insights can't gather all autosuggest items in Chrome or Teams

Repro Steps:

1. Launch Insights
2. Launch Chrome
3. Type "T" in the URL for Chrome
4. Press down arrow and navigate through all the suggestions (you can also use the mouse)
5. Verify that each item shows up in Insights

Note, you can see the same behavior in the Teams Desktop version in the Search box (Ctrl + E).

Results
When using the keyboard, Insights is not populating data for each suggestion item. For the mouse most of the suggestion items do not show up in Insights.

Expected
Insights should be showing data for every items in the suggestion drop down.

[BUG] ContentViewSplitButtonStructure should allow MenuItem

Current rule
The given element is expected to have the following structure: SplitButton and ( == 1 or == 2) and AllChildren(not(IsContentElement) or Button).

Proposed rule
The rule should allow MenuItem.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportsplitbuttoncontroltype#typical-tree-structure

[Feature Request] Improve patterns UX

Is your feature request related to a problem? Please describe.
Today, we receive anecdotal feedback that the patterns UX is not intuitive.

Describe the solution you'd like
We want to improve the overall patterns UX so that it's easy to use even for complicated patterns such as Text Pattern.

Describe alternatives you've considered
We can write extensive documentation, but this is just the first step.

Additional context

[BUG] AI-Win telemetry reports wrong OS versions

Describe the bug
The AI-Win telemetry reports only 2 values for the OS. It's either Microsoft Windows NT 6.1.7601 Service Pack 1 for Windows 7 SP1 (our lowest supported platform) or Microsoft Windows NT 6.2.9200.0 for everything else, meaning that we have no meaningful OS version data in our telemetry.

The fix
The fix is to uncomment the boilerplate supportedOS sections in the manifest files. That will cause the OS to report the correct OS info without any code change.

The risk
By uncommenting the supportedOS pieces in the manifest files, we also change some of our high DPI behavior. There's a good overview of this at https://walbourn.github.io/manifest-madness/. We had a lot of trouble getting high DPI support right, so if we enable this, we'll need to plan on testing (and maybe fixing high DPI issues) in at least the following areas:

• Highlighter overlay (live and in snapshot)
• Tabstop overlay
• Position and rendering of the snapshot button
• Proper activation of a scan by clicking the snapshot button

It's fine if we choose not to fix this, as long as we're also willing to live with the lack of usable OS info in the telemetry.

Tab stops test does not draw the first tab stop indicator.

Describe the bug
When running the tab stops test, the number (1) isn't shown on an element if it already has focus when you turn on the tab stops test.

To Reproduce
Steps to reproduce the behavior:

1. Open the Enterprise app.
2. In Customers, select + New.
3. In New customer, set focus in the First name field.
4. Turn on Record tab stops.
5. Press the Tab key once.

Expected behavior
The number (1) appears on the First name field.

Actual behavior
The number (1) appears on the Last name field.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. chrome, safari]
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

[BUG] EditSupportsOnlyValuePattern should return an error

The UIA spec (https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supporteditcontroltype) requires every edit control to support at least the Text control pattern. The Value pattern is supplemental. This rule should return an error.

[BUG] Structure rules should include IsContentElement/IsControlElement/pattern checks and increased unit test coverage

The structure rules have the following gaps:

• they run on elements regardless of whether IsControlElement or IsContentElement is true.
• unit test coverage is light on these rules
• in some cases, additional pattern guidance has been added in Microsoft documentation (example here). Our rules do not use the pattern when selecting elements to test

Because these are best-practice rules (evaluated as either Pass or Note), the user impact is not too high if the rules are unnecessarily run or scoped too loosely. However, we should be as close to the docs as possible.

We should consider making a full pass through the documentation to:

• ensure content rules and control rules only test elements if IsControlElement or IsContentElement is true
• add unit tests for each class
• where appropriate, ensure rules only test elements if the appropriate pattern exists

Update UI text for Issue Filing feature

Repro steps:

1. Clone the jalkire/github-feature branch.
2. Enable the bug filing extensions (Instructions to debug extensions.

Dialog when user hasn't signed in yet

Repro steps:

1. Run Accessibility Insights for Windows.
2. Run FastPass against the Wildlife Manager app.
3. Select File issue.

Expected behavior:
To file issues, select where you want to file issues.

Actual behavior:
To file issues, select an issue tracker and specify the desired location..

Screenshot:

Connection tab UI text

Repro steps:

1. Run Accessibility Insights for Windows.
2. Run FastPass against the Wildlife Manager app.
3. Select File issue.
4. Select OK in pop-up dialog.

Expected behavior:
Under Issue Filing, it reads: "To start filing issues, select where you want to file your issues. Learn more about issue filing."

Actual behavior:
Lorem ipsum.

Error Building Test Projects

I'm having trouble building the test cases. I get some 400 of errors. It's complaining about missing assembly references, but I haven't added any dependencies or things that would require new assembly references.

My Two Cents

It seems to me that I might not have access to some internal QA stuff on the Azure/Microsoft side of things. It is in particular complaining about Microsoft.QualityTools and perhaps a few other assemblies involving Fakes.

A Couple Error Messages

Error CS0234 The type or namespace name 'QualityTools' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) ExtensionsTests C:\Users\DemoUser\Source\Repos\accessibility-insights-windows\src\AccessibilityInsights.ExtensionsTests\ContainerUnitTests.cs 4 Active

Error CS0234 The type or namespace name 'Fakes' does not exist in the namespace 'System.IO' (are you missing an assembly reference?) ExtensionsTests C:\Users\DemoUser\Source\Repos\accessibility-insights-windows\src\AccessibilityInsights.ExtensionsTests\ContainerUnitTests.cs 8 Active

[BUG] Consider replacing UIA with UI Automation

Describe the bug
Currently, the app refers to UI Automation as UIA; looking at the UI Automation reference docs, UIA is not the correct acronym for the tech.

To Reproduce
Steps to reproduce the behavior:

1. Clone the repository.
2. Search for "UIA " in the code base.

Expected behavior
UIA is not used when referring to UI Automation.

Actual behavior
UIA is used when referring to UI Automation.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Add any other context about the problem here:

[BUG] ControlShouldNotSupportWindowPattern should return an Error

The UIA spec (https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportpanecontroltype#required-control-patterns) says a pane control should NEVER support the Window pattern.
This rule should return an error.

[BUG] Typo in ScannerResultControl_btnFileBug_Click_File_Issue_Configure

Describe the bug
The string resource identified as ScannerResultControl_btnFileBug_Click_File_Issue_Configure has a typo, leading to a confusing message.

To Reproduce
Steps to reproduce the behavior:

1. Start AIWin without any issue filing configuration
2. Scan an app with problems (WildlifeManager works fine)
3. Attempt to file a bug from the app
4. The following dialog is displayed:

Expected behavior
The error message should say To file issues, select where you want to file issues., but it's confusing since it's missing the first letter.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809
• Accessibility Insights for Windows Version: 1.1.835.1
• Target Application: Wildlife Manager

Additional context
Priority requested -
Add any other context about the problem here.

Migrate documentation from docs.microsoft.com to accessibilityinsights.io

Is your feature request related to a problem? Please describe.
Today, doc.microsoft.com hosts the How to Fix guidance, but the content is specifically customized for the purposes of Accessibility Insights users; updates and feedback will most likely come from Accessibility Insights users.

Describe the solution you'd like
Accessibility Insights should own the "View Code Sample" content in a documentation repository.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[Bug] Users installing Canary or Insider builds are in Production Channel

Problem
Users are in the Production channel by default, even if they're on a build that is still being treated as Canary or Insider. This is a potential for confusion, as the UI shows no prompt to let the user know that they're on a pre-production build. It also reduces the build validation benefit we get from having users choose to stay current with pre-production Channels.

Proposed solution
At startup, we should check to see if the currently version is newer than the version assigned to the user's selected Channel. If it is, we should check that version to determine the Channel currently assigned to that version, and ask the user if they'd like to change to that Channel (we should tell the user what channel they're on (typically Production), what channel is being proposed (Insider or Canary), and maybe include the existing descriptions of how the Channels compare. The user should have choices similar to

• Change to the XYZ channel now (where XYZ is the proposed Channel--the change will only change the ReleaseChannel setting, and will not trigger a version switch in the middle of the user's session)
• Ask the next time I start the app
• Ask the next time I change versions (For most users, this is the same as "don't ask me again"--only users who manually install new versions will get prompted more than once, and we want to try to remind these users who are manually managing their builds that we can do it for them)

Since this touches the UX, we need to get design input on the user interaction.

Considered/Rejected Solution
At one point, we released different sets of bits for different target audiences. We've intentionally moved to a model where we release only one set of bits per version. That's more consistent with typical OSS practices, and we don't want to go back to the old way.

[BUG] Color contrast foreground and background colors inverted.

Describe the bug
Color contrast tests do not have the correct foreground and background colors selected in the automated mode.

To Reproduce
Steps to reproduce the behavior:

1. Go to color contrast test
2. Click on any target application element
3. Look at the colors set as foreground and background in the color contrast test page
4. See error

Expected behavior
Foreground and background colors are correctly set

Actual behavior
They are inverted.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Min's suggestion was to change the text of Background and Foreground color to color 1 and color 2 (we had this before but changed it since then) since this is not something that really matters.

The LanmarkOneMain rule should be changed to return a warning instead of an error

This would give a4win parity with a4web, which treats this rule as a warning.
A4web also only reports an error when other landmarks exist on a page. I would like to get feedback from others as to whether we should make that change as well.

[BUG] Test reports null BoundingRectangle on ScrollBar button

Describe the bug
Automated tests identify one of the button children of a vertical scrollbar in the top or bottom position as having null BoundingRectangle. However, debugging the visual tree in Visual Studio, I find BoundingRectangle set for each of these buttons.

(If the scroll bar is in an intermediate position between top and bottom, the test passes.)

To Reproduce
Steps to reproduce the behavior:

1. Debug the repro app in Visual Studio
2. Scroll the vertical scrollbar to the top or bottom
3. Test the groupbox in Accessibility Insights for Windows

Expected behavior
The test should pass. Visual Studio's Live Visual Tree shows BoundingRectangle values on the ScrollBar's button children:

Actual behavior
One of the child buttons of the scroll bar is identified as having a null BoundingRectangle:
.

Desktop:

• OS: Windows 10 1809
• Accessibility Insights for Windows Version: 1.1.794.1
• Target Application: WPF ScrollViewer repro app

[BUG] Chrome menus can exceed parent bounding rects but AI-Win flags this as an error

Describe the bug
In Chrome, the settings menu pane does not clip based on the browser's size. Instead, the pane will exceed the size of the browser and always show its children. Because of this, ai-win flags the pane because its bounding rectangle is not contained within the bounding rectangle of its parent. The pane itself seems like a window. This rule should be revised to either omit the check in this case (using NativeWindowHandle + Pane control type + class name heuristics) or be changed to a 'best practice' rule.

To Reproduce
Steps to reproduce the behavior:

1. Open any website in Google Chrome.
2. Decrease the size of the browser so the following menu exceeds the browser size.
3. Select the browser in ai-win and start a test timer for 5 seconds.
4. Select the customize google chrome button (labeled '...') on the top right to open the menu.
5. View test results.

Expected behavior
The pane should not be flagged for an invalid bounding rectangle.

Actual behavior
The pane is flagged for a bounding rectangle that exceeds the size of its parents.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10 1809
• Accessibility Insights for Windows Version: 1.1.794.1
• Target Application: Chrome
• Target Application Version: 73.0.3683.86

[BUG] AI-Win does not save event details in event file

Describe the bug
AI-Win does not save event details in serialized event files. When loading such a file, the event details are blank.

To Reproduce

• Steps to reproduce the behavior:
• open Wildlife Manager or any app & ai-win
• Hover over window
• Listen to events
• Select any event configuration
• Record some events
• Make sure some of the events have "event details" in the bottom right of ai-win
• Save the event file
• Load the event file
• Notice the event details are empty

Actual behavior

• the event details should not be empty

Screenshots or .GIF

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version: Windows 10 1809
• Target Application: [e.g. chrome, safari] Wildlife manager

This issue should be fixed post-CSUN

Test settings tab - Remove custom rules?

We still have "custom rules (supported soon)" in the Test settings tab. Does this make sense to keep around?

[BUG] AI-Win fails to start on some machines

Describe the bug
When starting AccessibilityInsights on some machines, the app hangs, then crashes. Looking in the event viewer, it's throwing an Exception:

Application: AccessibilityInsights.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileNotFoundException
at AccessibilityInsights.SetupLibrary.MsiUtilities.GetInstalledProductVersion(AccessibilityInsights.SetupLibrary.IExceptionReporter)
at AccessibilityInsights.SetupLibrary.MsiUtilities.GetReleaseNotesUri(AccessibilityInsights.SetupLibrary.IExceptionReporter)
at AccessibilityInsights.Modes.StartUpModeControl..ctor()

Upon further investigation, the problem is that the Microsoft.Deployment.WindowsInstaller assembly needs to be in the app's main folder instead of installed with the AutoUpdate extension.

To Reproduce
Steps to reproduce the behavior:

1. Start AIWin on a susceptible machine (finding the susceptible machine is the hard part)

Expected behavior
App should start normally

Actual behavior
Splash screen displays, then the app just... stops. The Exception shows up in the Event Viewer.

Desktop (please complete the following information):

• OS: Windows 10 1903
• Accessibility Insights for Windows Version: 1.1.835.1

Automatic color contrast detection is odd in high contrast (white)

Describe the bug
When Windows is in high-contrast (white) mode, the colors auto-detected by the color contrast analyzers aren't correct.

To Reproduce
Steps to reproduce the behavior:

1. Configure system for HC-White
2. Start AIWin
3. Go to color contrast mode
4. Scan some controls
5. Compare auto-detected colors against actual colors

Expected behavior
auto-detected colors should closely match actual colors

Actual behavior
auto-detected colors are very different (see picture below). Confidence and color accuracy seem to have no correlation.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version: 1.1.786.1
• Target Application: Paint, OneNote
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

[BUG] Checkboxes in automated checks do not affect screenshot highlighting on first load

Describe the bug
The first time tests are run against an application, the checkboxes in automated checks do not change the visibility of the image highlighter. However, if you view the hierarchy tree and return to the automated checks screen, the checkboxes work properly.

To Reproduce
Steps to reproduce the behavior:

1. Run tests against Wildlife Manager or any app
2. Toggle any of the checkboxes in the automated checks screen
3. Notice that the red rectangles on the screenshot do not change visibility
4. Click on 'view results in UIA tree'
5. Return to 'Tests'
6. Notice that now the screenshot rectangle visibility does react to any checkbox on the automated check screen

Expected behavior
In step 3 above, the red rectangles should change visibility when the checkbox is toggled in the automated checks view

Actual behavior
The rectangles stayed visible

Screenshots or .GIF

Desktop (please complete the following information):

• OS: Windows 10 1809
• Accessibility Insights for Windows Version: 1.1.791.4
• Target Application: Wildlife Manager

Additional context
FYI, highlighter actions may be moving to SharedUX soon but functionality should be intact

[BUG] ControlShouldNotSupportValuePattern should consider Name property

Current rule
Currently looks for text controls that support the value pattern. Returns as uncertain instead of error.

Proposed rule

1. Look for text controls that support the value pattern.
2. Compare content of name and value.
3. Return error if name and value differ.

[BUG] Issue filing missing from recent builds

Describe the bug
Issue filing is completely absent from recent builds.

To Reproduce
Steps to reproduce the behavior:

1. Install and launch Canary Release: v1.1.0827.01
2. Note that there is no issue icon on the bottom left
3. Note that is no Connections tab in settings
4. Note that there is no File issue button anywhere in the ux.

Expected behavior
Issue filing should be available from the ux.

Actual behavior
Issue filing is not available.

Screenshots or .GIF

[BUG] Link to release notes always goes to Production

Describe the bug
The link to the release notes always points to the production release notes, regardless of release channel

To Reproduce
Steps to reproduce the behavior:

1. Go to the What's new screen
2. Click on "go to to the latest release notes"
3. See error

Expected behavior
This should go either to the release notes for the Channel or the specific Release

Actual behavior
This goes to the releases notes on accessibilityinsights.io (which is always production)

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10 1903
• Accessibility Insights for Windows Version: 1.1.0834.01

Additional context
Priority requested -
Add any other context about the problem here.

[BUG] Text suggestion for Color Contrast

The GetStarted page + What's new both say "Check color contrast: Investigate color contrast using Color Contrast." This sounds a bit repetitive, we should consider rephrasing.

Spelling in docs/NewProject.md

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
Read point 5.

Issue
"Products.wxs" should be "Product.wxs", remove the 's' at the end.

Screenshots or .GIF

Switching in left Nav

When in live inspect / events I cannot switch to "Test" mode unless I go back to live inspect mode first. (Can still go to color contrast test)

[Feature Request] What's new content hasn't been updated since initial release

Describe the bug
The content of the What's new dialog needs to be updated to reflect features added since the initial release

To Reproduce
Steps to reproduce the behavior:

1. Go to the What's new dialog
2. Look at the content

Expected behavior
The content should have reference to GitHub issue filing and release channels

Actual behavior
The content is unchanged from the initial release

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10 1903
• Accessibility Insights for Windows Version: 1.1.0834.01

[BUG] ControlViewSpinnerStructure should allow ListItem

Current rule
The given element is expected to have the following structure: Spinner and == 2 and <= 1 and AllChildren(not(IsControlElement) or (Button or Edit)).

Proposed rule
The rule should allow ListItem.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportspinnercontroltype#typical-tree-structure

Users aren't aware that they can go back to test mode after selecting "View results in UIA tree"

Describe the bug
When a user selects "View results in UIA tree" in Automated checks, the user is taken to Live Inspect's Test Results view with limited insight into where they are and how they can get back to the automated checks results.

To Reproduce
Steps to reproduce the behavior:

1. Start a screen reader.
2. Launch Accessibility Insights for Windows.
3. Run automated checks on an element/app.
4. In Accessibility Insights for Windows, select "View results in UIA Tree".

Expected behavior
All users should know that they've been taken to Live Inspect's Test Results view, and that they can get back to the automated checks results by navigating to the Test mode or via the breadcrumbs.

Actual behavior
User study feedback suggests folks are unaware that they can go back to the Test mode.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. chrome, safari]
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

[BUG] Color contrast algorithm returns NULL for certain images

Describe the bug
Color contrast algorithm returns NULL for certain images

To Reproduce
Steps to reproduce the behavior:

1. Pull the code from my branch;
2. Navigate to the test cases: AccessibilityInsights.DesktopTests.ColorContrastAnalyzer.ImageTests.SimplePurpleAndWhiteButton
   and
   AccessibilityInsights.DesktopTests.ColorContrastAnalyzer.ImageTests.SimpleBlueAndWhiteText
3. Run or debug these test cases
4. See error as mostContrastingPair is null

Expected behavior
the mostContrastingPair should return the most contrasting pair of the actual color of the image

Actual behavior
The mostContrastingPair value calculated from RunColorContrastCalculation function is null.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Priority requested -

The affected tests, SimplePurpleAndWhiteButton and SimpleBlueAndWhiteText should be uncommented after that issue is fixed

Suggestion: Add a rule to warn if items in a listbox have duplicated names

In its current form, AccessibiltyInsights for Windows raises no warning or error if items in a listbox all have the same name. This is a case that can make it more difficult to know the contents of the items.

Suggestion: Create a rule that runs on listboxes and checks for duplicated names between the list items. There are legitimate cases (such as pictures as the list items) that may limit this rule to generating only warnings, no errors.

[BUG] ControlViewSplitButtonStructure should allow Menu and MenuItem

Current rule
The given element is expected to have the following structure: SplitButton and ( == 1 or == 2) and <= 1 and <= 1 and AllChildren(not(IsControlElement) or (Button or Image or Text)).

Proposed rule
The rule should allow Menu and MenuItem.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportsplitbuttoncontroltype#typical-tree-structure

[BUG] Add more detail to automated checks role

Describe the bug
From user feedback, emphasize the role of automated checks in the tool: "that no automated tool can find even a majority of accessibility defects on a web page"

To Reproduce
Steps to reproduce the behavior:

1. Open Accessibility Insights for Windows
2. select continue on the What's new section

OR

1. Go to https://accessibilityinsights.io/docs/en/windows/getstarted/fastpass

Expected behavior
The Automated checks section of FastPass should clarify that it only finds some of the most common accessibility issues

Add a keystroke like ctrl + S to save a snapshot

[Feature Request] Add Ability to Expand Nodes from UI Inspection Tree

Is your feature request related to a problem? Please describe.
At the moment, if you have a UI element under inspection there is no way to dive deeper into its children nodes. You can get observe and navigate its top-level children, but nothing deeper.

Describe the solution you'd like
It would be nice to be able to dive deeper into children UI elements from the inspection window.

Describe alternatives you've considered
It is possible to inspect UI elements deeper in the tree on screen, but it will not let the user easily observe elements that may perhaps be hidden from the UI or collapsed.

[BUG] The maximize button on AI-Win doesn't change in maximized mode

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
Using build 1.1.0794.01:

1. Start AI-Win;
2. Hit "Get Started";
3. Click the maximize button on the top right

Expected result:
The maximize button should change to a restore button.

Expected behavior
The maximize button stays as the maximize button.

Actual behavior
What actually happened.

Screenshots or .GIF
In the screenshot below, the maximize button on the top right is still the maximize button:

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

Instruction text for Live Inspect's Events pane is not clear.

Describe the bug
The current instruction test for Live Inspect's Events pane is not clear.

To Reproduce
Steps to reproduce the behavior:

1. Open an app to test.
2. Open Accessibility Insights for Windows.
3. Open Live Inspect.
4. Set focus on an element and select Shift + F7. You can also use the context menu > Listen to events.

Expected behavior
In the Events pane, there's instruction text: "Select the events to listen to in the Configuration tab, and select Record [record button] to start recording. You can also press Shift + F7."

Actual behavior
"Select the Events you want to listen to in the Configure Events tab and press record to start recording."

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version: 1.1.786.2
• Target Application: Enterprise Database (Developer Sample)
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

• Larger UX discussion on the Configuration tab name should be considered before fixing this issue.

Rule change: when a spinner has children that are list items, the spinner should support the selection pattern.

This change should be added to the rule ControlShouldSupportSelectionPattern.
See https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-supportspinnercontroltype

[BUG] ControlViewTabStructure should allow Button

Current rule
The given element is expected to have the following structure: Tab and AnyChild(IsControlElement) and AllChildren(not(IsControlElement) or (Group or ScrollBar or TabItem)).

Proposed rule
Rule should allow Button.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supporttabcontroltype#typical-tree-structure

How about removing "on hover" from the toggle button control on top?

How about removing "on hover" from the toggle button control on top?
since CCA detects colors on hover and keyboard focusing, "On hover" would not be needed.
@risanaka ?

Originally posted by @neocln in #129 (comment)

@flyingUnderTheRadar: please update the toggle button as follows:
Toggle label: Auto detect color contrast ratio
Toggle tooltip: Hover over the element or set keyboard focus to auto detect color contrast ratio.

Design discussion for instruction text for Live Inspect's Events pane

Describe the bug
The name of Configuration tab and other things in Event Pane design should be revisited.
this is based on #146 issue.

To Reproduce
Please find out more detail information on #146

[BUG] ContentViewSpinnerStructure should allow ListItem

Current rule
The given element is expected to have the following structure: Spinner and NoChild(IsContentElement).

Proposed rule
The rule should allow ListItems.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportspinnercontroltype#typical-tree-structure

[BUG] Need to improve the startup sequence.

Describe the bug
The current startup sequence can take up to 2 - 3 seconds while it checks for new updates before showing the Welcome page or launching Inspect mode.

Users feel that the app is not responding during those few seconds, and we need to improve this experience.

To Reproduce
Steps to reproduce the behavior:

1. Launch Accessibility Insights for Windows in a location with poor WiFi.

Expected behavior
Users see a visual indicator that the app is launching.

Actual behavior
Nothing is displayed on the screen until Accessibility Insights for Windows finishes checking for updates.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Recommendation from Min: use the WPF splash experience.

[BUG] ControlViewCalendarStructure should allow ListItem

Current rule
The given element is expected to have the following structure: Calendar / (DataGrid and NoChild(Header) or == 1 and AnyChild(Header and (NoChild(HeaderItem) or == 7)) and NoChild(Button) or == 2 and ( > 0)).'

Proposed rule
The rule should allow ListItem.
See the documentation: https://docs.microsoft.com/en-us/windows/desktop/winauto/uiauto-supportcalendarcontroltype#typical-tree-structure

[BUG] Update the setup dialog's logo image

Please check whether the bug has already been filed.

Describe the bug
A clear and concise description of what the bug is.

When the user installs Accessibility Insights for Windows, Ada the cat is visible on the left side of the first install dialog. However, once you start the install dialog, there's a red box where the logo would be.

To Reproduce
Steps to reproduce the behavior:

1. Go to Accessibility Insights
2. Select Download for Windows.
3. Run the downloaded MSI.
4. Select Next in the Setup dialog.

Expected behavior
A clear and concise description of what you expected to happen.
There should be an Accessibility Insights logo at the top right.

Actual behavior
What actually happened.
There's a red square with a CD at the top right.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line) Windows 10 Version 1809
• Accessibility Insights for Windows Version: latest available for download
• Target Application: [e.g. Chrome, Wildlife Manager] not applicable
• Target Application Version: [e.g. 22] not applicable

Additional context
Priority requested -
Add any other context about the problem here.

According to WiX, it looks like this is the top banner and may be customizable (I haven't tried it)?

[BUG] Improve instruction text in Color Contrast Analyzer

Describe the bug
With the improvements made in #210, the color contrast analyzer has more things in its UI. We want to re-visit the instruction text, especially as it already links to a tutorial via the info icon.

To Reproduce
Steps to reproduce the behavior:

1. Launch Accessibility Insights for Windows.
2. Go to Color Contrast.

Expected behavior
Users know how to get started right away with the Color Contrast Analyzer and isn't overwhelmed by the amount of introductory content.

Actual behavior
The intro text can introduce scrollbars under certain sizes:

Intro text: To auto detect an element's contrast ratio, hover over the element within a target application or set keyboard focus on the element. The analyzer will update with the auto detected colors, the contrast ratio, and the confidence level.

To manually select two colors to test the contrast ratio, select each color using the Eyedropper. You can also select a color using the Color Picker box or enter its hex code.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
• Accessibility Insights for Windows Version:
• Target Application: [e.g. Chrome, Wildlife Manager]
• Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.