Compilation issues with Intel C++ 18 compiler

[microsoft]

Compilation issues with Intel C++ 18 compiler

[walbourn]

The instances of warning #1899: multicharacter character literal are easily fixed using the MAKEFOURCC macro I already use in dds.h.

[walbourn]

I'm suppressing some noise as well:

#ifdef __INTEL_COMPILER
#pragma warning(disable : 161 2960 3280)
// warning #161: unrecognized #pragma
// message #2960: allocation may not satisfy the type's alignment; consider using <aligned_new> header
// message #3280: declaration hides member
#endif

The first is due to use the of pragma prefast

The second wants me to use a C++17 feature

The third is a particular case that Visual C++ decided to stop complaining about

[walbourn]

The conformance issues in the code have been fixed in this commit

The Intel C++ 18 compiler (18.0.1) has some internal bugs with std::make_unique that need fixed before the code will safely compile.

error : assertion failed at: "shared/cfe/edgcpfe/templates.c", line 7609
effect = std::make_unique(device.Get());

These are fixed in the Intel C++ 18 compiler (18.0.3) which is in the Intel System Studio 2018 Update 2 and Intel Performance Studio-XE 2018 Update 3.