microsoft/dynamics365fo-appchecker

Repository supporting the Dynamics 365 for Finance and Operations app checker

dynamics365fo-appchecker's Issues

MissingMethodDocumentation.xq also triggers on tables

Do we want to execute this rule for "classes" representing tables as well?

public class <tablename> extends common
{
}

I'd propose not to do that or at least certainly not for staging tables (since they are generated by VS without comments)
This also seems to overlap with "developerDocumentation" and "Label" properties on the table.

"Unsaved Saved, exit anyway?" closes app even if user answers no

This means there is a potential loss of data in the query editors. The onClosing event is handled correctly (the Cancel flag is set) but the app still closes.

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Object reference not set or Database menu not functional

Got the latest version, running it as admin, but somehow its not functional. The query button is greyed out.

Rule TableIndex.xq should be executed only for Sql Tables (Regular/TempDb), not InMemory

We are getting errors on tables with no clustered index, but with Table Type property set to InMemory. What's the benefit of having a clustered index there, since they are not persistent on the database.

Tested Sample Rules, found the following 4 rules failing

I have tested X++ Sample rules from Visual Studio.
Added them to: K:\AosService\PackagesLocalDirectory\bin\AppCheckerRules\X++

It turns out the tool does not like spaces in the rule file name. The following rules stopped App Checker due to that:

1. Enum Compatibility.xq
2. Mismatched Labels.xq

Removed the space and it worked like a charm.

The following rules failed on execution:

1. BulkEnumerationReferences.xq, 7/36:
   [XPTY0004] Cannot convert empty-sequence() to xs:string: ().

2. RecursiveMethods.xq 5/26:
   [XPST0003] Unexpected end of query: '>
   ...'.

I hope this helped.

XQuery 3.0 keywords are not colorized correctly

The xquery 3.0 standard defines new keywords (as showin docs.basex.org/wiki/xquery_3.0). The new keywords are:

tumbling, window, group, (by), (count), allowing, empty try, catch, switch, case, default

Recursion detected does not make sense

Recursion detected: I think this rule do not make sense because a modern programming language it should be possible to use recursions. The argument for banning recursions is "...we had recursion related problems in production environments to often...". For me this is also no agreement for putting the recursions on a "black list". I think it would make more sense to add runtime checks to restrict the recursion depth.

The version number that is set in the Assembly Info should be updating for each build...

This is what is shown in the about box.

TableIndex rule is throwing an error when the table uses SurrogateKey as Clustered Index

BalancedTtsStatement.xq does not allow conditional abort

Is the following code pattern allowed?

{
ttsbegin;

if (condition) 
{
   ttsAbort;
   return;
}

ttsCommit;
}

Now the BalancedTtsStatement.xq rule complains about it.