microsoft/fmu-bonsai-connector

A connector for integrating FMU models with Microsoft Project Bonsai.

fmu-bonsai-connector's Issues

FMUConnector setup should not use the name microsoft-bonsai-api

In FMUConnector/setup.py, it sets name="microsoft-bonsai-api".

I don't understand the details of how the setup function works in a Python package, but shouldn't the setup info be about the FMUConnector package itself?

FMU Not Closing Properly

I don't think close_model in FMU_Connector.py is ever called. Or if it is, it isn't called in a try/catch block if there is a keyboard interrupt or any error. This leaves the process running in memory, which requires a ctl-alt-del to start task manager and kill it manually. This is also the only way to remove the expanded .zip content as the process has a lock on it. Thank you!

environment.yml and requirements.txt have different packages/versions

The environment.yml and the samples/vanDerPol/requirements.txt files seem like they have similar purposes. But they include a different set of packages and the same packages have different versions.

Could we just use one or the other of these files? Or both these forms are included for convenience of setting up environments then can we give them the same packages with the same versions?

FIRST_TIME_RUNNING setting is error-prone

It is easy to forget to set FIRST_TIME_RUNNING = False when creating a docker container and then your simulator won't start. Or it's easy to temporarily change this value and then check it in when you didn't mean to.

Can we eliminate this setting? If a conf.yaml file already exists then we use it and assume its settings are correct. If the config file doesn't exist then we prompt and create it?

FMU connector prints: Model hasn't been initialized or has already been terminated

Each time an episode starts, the FMU connector prints [_terminate_model] Model hasn't been initialized or has already been terminated. Skipping termination.

In _terminate_model, self.fmu.terminate() is never called because self._is_terminated is never set to false.