microsoft/kiota-authentication-azure-dotnet

Kiota authentication provider implementation with Azure Identity

Kiota Azure Identity authentication provider library for dotnet

The Kiota Azure Identity authentication provider library for dotnet is the authentication provider implementation with Azure.Identity.

A Kiota generated project will need a reference to a authentication provider library to authenticate HTTP requests to an API endpoint.

Read more about Kiota here.

Using Azure Identity authentication provider library for dotnet

dotnet add package Microsoft.Kiota.Authentication.Azure --prerelease

Debugging

If you are using Visual Studio Code as your IDE, the launch.json file already contains the configuration to build and test the library. Otherwise, you can open the Microsoft.Kiota.Authentication.Azure.sln with Visual Studio.

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.

When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Trademarks

This project may contain trademarks or logos for projects, products, or services. Authorized use of Microsoft trademarks or logos is subject to and must follow Microsoft's Trademark & Brand Guidelines. Use of Microsoft trademarks or logos in modified versions of this project must not cause confusion or imply Microsoft sponsorship. Any use of third-party trademarks or logos are subject to those third-party's policies.

kiota-authentication-azure-dotnet's Issues

AzureIdentityAccessTokenProvider.GetAuthorizationTokenAsync

Method AzureIdentityAccessTokenProvider.GetAuthorizationTokenAsync will add the current uri to the instance variable _scopes. This is not thread-safe and might cause InvalidOperationExceptions because of collections that are modified concurrently. It also uses the current method parameter uri to initialize the instance variable. Next time, when a different uri is used, scopes might be wrong.

My exception:

System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.
at bool System.Collections.Generic.HashSet.AddIfNotPresent(T value, out int location)
at async Task Microsoft.Kiota.Authentication.Azure.AzureIdentityAccessTokenProvider.GetAuthorizationTokenAsync(Uri uri, Dictionary additionalAuthenticationContext, CancellationToken cancellationToken)
at async Task Microsoft.Kiota.Abstractions.Authentication.BaseBearerTokenAuthenticationProvider.AuthenticateRequestAsync(RequestInformation request, Dictionary additionalAuthenticationContext, CancellationToken cancellationToken)
at async Task Microsoft.Kiota.Http.HttpClientLibrary.HttpClientRequestAdapter.GetHttpResponseMessage(RequestInformation requestInfo, CancellationToken cancellationToken, Activity activityForAttributes, string claims)
at async Task Microsoft.Kiota.Http.HttpClientLibrary.HttpClientRequestAdapter.SendAsync(RequestInformation requestInfo, ParsableFactory factory, Dictionary> errorMapping, CancellationToken cancellationToken)
at async Task Microsoft.Graph.Users.UsersRequestBuilder.GetAsync(Action requestConfiguration, CancellationToken cancellationToken)
[...]

Current implementation:

        if(!_scopes.Any())
            _scopes.Add($"{uri.Scheme}://{uri.Host}/.default");
        span?.SetTag("com.microsoft.kiota.authentication.scopes", string.Join(",", _scopes));
        var result = await this._credential.GetTokenAsync(new TokenRequestContext(_scopes.ToArray(), claims: decodedClaim), cancellationToken);

Idea to fix this is to not modify _scopes instance variable but use a local array:

        string[] scopes = _scopes.ToArray();
        if (scopes.Length == 0)
            sopes = new string[] { $"{uri.Scheme}://{uri.Host}/.default" };
        span?.SetTag("com.microsoft.kiota.authentication.scopes", string.Join(",", scopes));
        var result = await this._credential.GetTokenAsync(new TokenRequestContext(scopes, claims: decodedClaim), cancellationToken);

do not require https for local host in azure identity provider

reflection of microsoft/kiota-authentication-azure-go#102

AzureIdentityAccessTokenProvider incorrect docs

AzureIdentityAccessTokenProvider incorrectly proclaims it's association with IAuthenticationProvider, to the detrement of trying to use it.

In short, the docs are wrong

namespace Microsoft.Kiota.Authentication.Azure;
/// <summary>
/// Provides an implementation of <see cref="IAuthenticationProvider"/> for Azure.Identity.
/// </summary>
public class AzureIdentityAccessTokenProvider : IAccessTokenProvider, IDisposable

It does, in fact, not provide an implementation of IAuthenticationProvider for Azure.Identity. I don't know which is supposed to be right, the code or the docs, so I'm leaving it in your capable hands to decide.

Thanks, Lena

Error: "un handled case, might be object type or array type"

Even with --ll trace, I do not get some useful information

Command line: kiota.exe -d openapi_v3json -o ./ApiClient -l CSharp --ll trace

OpenApi Spec: openapi_v3.zip