microsoft/lis-rpm-build-pipeline

RPM build script for lis-next, used for pipeline

lis-rpm-build-pipeline

lis-rpm-build-pipeline's Issues

Question/Help: RHEL_RELEASE_CODE is not defined

Hallo,

I try to build the LIS package myself since we need it for a custom kernel.
I'm not experienced in Kernel module building, I apology for the possible newbie question.

To build the project I use the LS rpm source package downloaded from here: https://aka.ms/lis

One of the first error messages I get is "RHEL_RELEASE_CODE is not defined "
Do I miss something obvious? Do I have to define parameter?

rpmbuild -ba -D "kernel_version $(uname -r)" lis-rhel7.spec 

n file included from /root/rpmbuild/BUILD/hv/obj/default/arch/x86/hyperv/hv_init.c:21:0:
/root/rpmbuild/BUILD/hv/obj/default/arch/x86/include/uapi/lis/asm/hyperv.h:159:5: warning: "RHEL_RELEASE_CODE" is not defined [-Wundef]
 #if(RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(7,0))

thank you for your help.

This repo is missing a LICENSE file

This repository is currently missing a LICENSE file.

A license helps users understand how to use your project in a compliant manner. You can find the standard MIT license Microsoft uses at: https://github.com/microsoft/repo-templates/blob/main/shared/LICENSE.

If you would like to learn more about open source licenses, please visit the document at https://aka.ms/license (Microsoft-internal guidance).

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

RHEL8/CentOS8 support

Will we be seeing RHEL8/CentOS8 support?

For RHEL6.x tool hv_set_ifconfig should be copied to usr/libexec/hypervkvpd/ like RHEL7.x

May be always copy the 3 scripts to /usr/libexec/hypervkvpd/, unless the building system defines KVP_SCRIPTS_PATH (please see tools/hv/hv_kvp_daemon.c).