microsoft/mlads2018-quantumml

Introduction to Quantum Machine Learning tutorial: Building a quantum perceptron using Microsoft Quantum Development Kit

mlads2018-quantumml's Issues

Inconsistency between documentation and code

The version of ClassicalDriver.cs in the repo refers incorrectly to the already implemented QuantumClassifier_SuccessRate_Easy and not to QuantumClassifier_SuccessRate, so when you run the code for the first time it already works, contradicting the readme notes.

Error generating data angles

The version of the code as-is always generates values (considering that the seed of the random generator is fixed at 123) between Min -0.978941001912466 and Max 4.94084872741803.

However the code of the driver states:

// Do a ternary search on the classification angle (we know that the angle is between 0 and 2*PI).

and then the boundaries are set at:

double l = 0.0, r = 2 * Math.PI;

I'd either fix the code to generate values in the correct range, or fix the comment and ranges.

Wrong definition of SaveAsCsv

It is:

static void SaveAsCsv(double[] data, int[] labels)

should be:

static void SaveAsCsv(double[] data, long[] labels)

Generates a compilation error when uncommenting the SaveAsCsv call.