microsoft/pagetour-sdk

A lightweight Typescript SDK for making tours on a web page

pagetour-sdk's Issues

tour dialog is showing in the wrong direction

Tour step configuration:-

Actual position of tour step:-

Expected:
It should be displayed at the right of input element.

Sample App section in README.md pointing to wrong directory path

Open sample-app section in README.md file
https://github.com/microsoft/PageTour-SDK#sample-app

It says, got to PageTour-SDK/sample run npm install and then npm run start

sample folder is inside apps folder, so shouldn't it be PageTour-SDK/apps/sample?

Also there is a spelling mistake (got should be go)

After invoking the 'Close(x)' button in the take tour, Keyboard tab focus is not moving to triggered control.

Test Environment:
OS Version: 22H2 OS Build 22621.674
Browser: Chrome Version 96.0.4664.110 (Official Build) (64-bit)
#URL: Reactour Demo Template [live] - CodeSandbox

Repro steps:

1. Open URL: Reactour Demo Template [live] - CodeSandbox
2. Focus lands on the code editor as soon as page gets opened
3. Press Ctrl+f6 key from keyboard then press 1 tab, then again press CTRL+M from keyboard and then press 1 tab to move focus out of editor pane.
4. Press 6 tabs to land on ‘Try It’ control and press it. Pop-up gets displayed.
5. Press 11 tabs to navigate to the close control and press it.
6. Verify whether once after invoking the close control focus is landing on the triggered control or not.

Actual Results:
After invoking the 'Close(x)' button in the take tour, Keyboard tab focus is not moving to triggered control.
Observation: After invoking 'Close(x)' button, keyboard tab focus loss is observed and on pressing tab key, focus is not moving anywhere.

Expected Results:
After invoking the 'Close(x)' button in the take tour, Keyboard tab focus should move to triggered (i.e., Tack a tour) control.

Attachments:

Issue-202163-After.invoking.the.Close.x.button.in.the.take.tour.Keyboard.tab.focus.is.not.moving.to.triggered.control.mp4