microsoft/pal

Platform Abstraction Layer (both SCXCoreLib and SCXSystemLib)

pal's Issues

Path containing whilespaces

We are facing this bug in OMSAgent just when we added nokogiri library. Because nokogiri has a dependency on mini_portile2 gem that has 2 filepaths containing whitespaces:

mini_portile/test/assets/patch 1.diff
mini_portile/test/assets/test mini portile-1.0.0/

I can reproduce it by including a filename with whitespace in Build-OMS-Agent-for-Linux/omsagent/installer/datafiles/ruby.data :

${{RUBY_DEST}}/lib/ruby/gems/2.4.0/doc/my test.txt; ${{RUBY_DEST}}/lib/ruby/gems/2.4.0/doc/my test.txt;; 644; root; root

Error:

root@abder-pad:~/OMS/Build-OMS-Agent-for-Linux/omsagent/build# python /root/OMS/Build-OMS-Agent-for-Linux/pal/installer/InstallBuilder/installbuilder.py \
 --BASE_DIR=/root/OMS/Build-OMS-Agent-for-Linux/omsagent \
 --TARGET_DIR=/root/OMS/Build-OMS-Agent-for-Linux/omsagent/target/Linux_UBUNTU_18.04_x64_64_Debug \
 --INTERMEDIATE_DIR=/root/OMS/Build-OMS-Agent-for-Linux/omsagent/intermediate/Linux_UBUNTU_18.04_x64_64_Debug/installer_tmp \
 --STAGING_DIR=/root/OMS/Build-OMS-Agent-for-Linux/omsagent/intermediate/Linux_UBUNTU_18.04_x64_64_Debug/staging \
 --BUILD_TYPE=Debug \
 --BUILD_CONFIGURATION=Linux_UBUNTU_18.04_x64_64_Debug \
 --RUBY_INT=intermediate/Linux_UBUNTU_18.04_x64_64_Debug/ruby \
 --RUBY_ARCH=x86_64-linux \
 --RUBY_ARCM=x86_64-linux \
 --PFARCH=x64 \
 --PFDISTRO=UBUNTU \
 --PFMAJOR=18 \
 --PFMINOR=04 \
 --VERSION=1.8.1 \
 --RELEASE=370 \
 --VERSION_IDENT="20190206 Developer_Build" \
 --DATAFILE_PATH=/root/OMS/Build-OMS-Agent-for-Linux/omsagent/installer/datafiles \
 --OUTPUTFILE=omsagent-1.8.1-370.ubuntu.18.x64 \
 base_omsagent.data linux.data ruby.data linux_dpkg.data

chown: cannot access '/root/OMS/Build-OMS-Agent-for-Linux/omsagent/intermediate/Linux_UBUNTU_18.04_x64_64_Debug/staging/opt/microsoft/omsagent/ruby/lib/ruby/gems/2.4.0/gems/mini_portile2-2.4.0/test/assets/test': No such file or directory
chown: cannot access 'mini': No such file or directory
chown: cannot access 'portile-1.0.0/configure': No such file or directory
Unable to chown /root/OMS/Build-OMS-Agent-for-Linux/omsagent/intermediate/Linux_UBUNTU_18.04_x64_64_Debug/staging/opt/microsoft/omsagent/ruby/lib/ruby/gems/2.4.0/gems/mini_portile2-2.4.0/test/assets/test mini portile-1.0.0/configure.

As a workaround, I've removed these 2 paths since its only related to testing, but we need to fix this issue.

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Errors when using Python 3

Error when using Python 3:

Traceback (most recent call last):
  File "/home/ubuntu/a_latest/build-omi-script-provider/pal/installer/InstallBuilder/installbuilder.py", line 3, in <module>
    import datafileparser
  File "/home/ubuntu/a_latest/build-omi-script-provider/pal/installer/InstallBuilder/datafileparser.py", line 310
    sectionPriority = m.group(1)
    ^
IndentationError: expected an indented block

and

Traceback (most recent call last):
  File "/home/ubuntu/a_latest/build-omi-script-provider/pal/installer/InstallBuilder/installbuilder.py", line 4, in <module>
    import linuxrpm
  File "/home/ubuntu/a_latest/build-omi-script-provider/pal/installer/InstallBuilder/linuxrpm.py", line 2, in <module>
    import scxutil
  File "/home/ubuntu/a_latest/build-omi-script-provider/pal/installer/InstallBuilder/scxutil.py", line 21
    print "Symbolic link: " + srcname + " -> " + dstname
                          ^
SyntaxError: Missing parentheses in call to 'print'

In Python 3, mixing tabs with spaces is a syntax error.
Also, it's required for print to have parenthesis around the string which will be printed.

None of these changes affect Python 2 in any way.

Typo in GetOsLinux.sh

s/Softare/Software/

Beware https://github.com/Microsoft/pal/blob/master/test/code/scxsystemlib/common/getlinuxos_test.cpp
tests for this typo too.