microsoft/powerbi-visuals-strippetsbrowser

Strippets Browser custom visual for PowerBI

Strippet Browser Custom Visual

Debugging

1. Install ssl certificate by running npm run install-certificate and following the steps from: https://github.com/Microsoft/PowerBI-visuals/blob/master/tools/CertificateSetup.md
2. Enable Developer Tools in PowerBI: https://github.com/Microsoft/PowerBI-visuals/blob/master/tools/DebugVisualSetup.md
3. Run npm start to start development.

Building

1. Run npm install to download the dependencies.
2. Run npm run package to package the visual.

A .pbiviz file will be generated in the dist folder

Testing

Run npm test

powerbi-visuals-strippetsbrowser's Issues

Nothing happen when I try to make some customizations (CSS, ...)

Hi,
I'm unable to customize the look of the strippet browser with the current release 0.2.15.
I tried to modify the capbilities.json file in order to change the display name of the Source Image attribut

Before
{
"name": "sourceImage",
"displayName": "Source Image (url)",
"description": "URL for an image to display in the top-right corner of the thumbnail",
"kind": 0
},

After
{
"name": "sourceImage",
"displayName": "Source Image (url) TEST",
"description": "URL for an image to display in the top-right corner of the thumbnail",
"kind": 0
},

I run npm run package, all thing works fine but when I import the "essex.widget.strippetbrowser.pbiviz" file into powerbi, nothing changed ...

I also tried to modify css file to modify the card-icon sizing, same problem, nothing changes..

Is there anything else to do ?

[COMPONENTS] CSS uses IDs to style elements.

The CSS in the Thumbnail components references #thumbnails-panel by ID, this could cause conflicts in PowerBI when not in sandbox mode.

Promise leak when loading thumbnail images

To reproduce: create a strippet browser in pbi (I'm using the dev visual to do so). Bind at least Document Id and Title Image. Switch to outlines mode. Switch back to Thumbnails mode. The following appears in the debug console:

Warning: a promise was created in a handler at webpack:///./src/StrippetsVisual.ts?:1096:43 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (webpack:///./~/bluebird/js/browser/bluebird.js?:2805:14)
    at Thumbnail._loadImage (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.thumbnail.js?:224:12)
    at Thumbnail._loadImages (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.thumbnail.js?:158:25)
    at Thumbnail._init (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.thumbnail.js?:99:11)
    at new Thumbnail (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.thumbnail.js?:47:7)
    at eval (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.js?:143:25)
    at Array.forEach (native)
    at Thumbnails._render (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.js?:137:10)
    at Thumbnails.loadData (webpack:///./lib/@uncharted/thumbnails/src/thumbnails.js?:211:7)
    at eval (webpack:///./src/StrippetsVisual.ts?:1096:43)
From previous event:
    at StrippetsVisual.updateThumbnails (webpack:///./src/StrippetsVisual.ts?:1095:44)
    at StrippetsVisual.showThumbnails (webpack:///./src/StrippetsVisual.ts?:1018:38)
    at HTMLDivElement.eval (webpack:///./src/StrippetsVisual.ts?:780:26)
    at HTMLDivElement.dispatch (https://msit.powerbi.com/13.0.1700.1070/scripts/jQuery.js:4732:27)
    at HTMLDivElement.elemData.handle (https://msit.powerbi.com/13.0.1700.1070/scripts/jQuery.js:4544:28)

Revoke private key or add comment indicating the reason it has been committed

It is a security best practice to never commit a secret, especially within a publicly viewable repository. However, the following file has been committed to your repo:

• PowerBI-visuals-StrippetsBrowser/certs/PowerBICustomVisualTest_private.key

To resolve this issue, either revoke this key and remove it from the repo, OR add a comment indicating both why it is necessary to have this private key and why it is not a security risk.

"githubUrl" needs to be filled out in pbiviz.json

Entity name highlighting doesn't work at the end of the sentence

Say you have this text:

"Pies, Pies, and more Pies"

The first two will be highlighted, but the last one will not.

Culprit:

PowerBI-visuals-StrippetsBrowser/src/StrippetsVisual.ts

Line 875 in 79c9431

filterRegex = new RegExp('(?:^|\\s|[<\\[\\({"\'])' + StrippetBrowser16424341054522.escapeRegex(entity.text) + '(?:^|\\s|[.,;:!?\\]}>\\)\'"])', 'ig');

The end part of the regex uses (?:^, the ^ matches the beginning of a sentence, it should be changed to $

Directions Needed

I am unsure how to get strippets to work with a url.

It works well with my sharepoitn list but wanted to add an industry news site to a new strippets visual and it isn't working.

Not working

Spent the full weekend trying to get ootb developper source to work but it would not pbiviz start

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

"Source Date" in card view incorrect

When displaying a source date in card view the date shown in the collapsed, summary-type view is one day before the actual source date (screenshot 1).
Once clicked and the card expands the source date is then correct (screenshot 2).

Outlines tooltip sometimes chooses wrong alignment and size

Long entity tooltips sometimes align right when they should just align left.
Long right-aligned tooltips are sometimes clipped at their left edge, when they should be shrunk to fit.