Comments (3)
Can you provide a repro step?
Thanks.
from roosterjs.
Essentially, if you change the font color of a piece of text which is underlined, then the font color of the text will change BUT the underline color will not change (as pictured). You see in the screenshot the text is green but the underline is black. Once you highlight the text again and change the color, then the underline will swap to the new font color.
from roosterjs.
Afaict this has to do with the order of the and elements
If the underline is a parent of the style, it will be the parent text colour (in this case black)
if the underline is a child of the style, it will be the child text colour (in this case green).
Possible fixes as I see it
- Introduce ul normalization (e.g. if a ul has only one child, switch their orders so the child is the parent of the ul
- when setting ul on an element, if the selected text is an entire inline element, make the ul a child of the inline element instead of a parent.
Thoughts @JiuqingSong ?
from roosterjs.
Related Issues (20)
- Copy/cut will fail if trustedTypes default policy filters comment out HOT 4
- [Content Model] The style on SelectionMarker is not up to date after setFontSize more than one time HOT 5
- ContentModel: Existing format on SelectionMarker is not applied to the new entity
- [Content Model] New line didn't create a new bullet item if the div has style "direction" in bullets/numbing HOT 3
- Read-only entity element can't be deleted by pressing backspace key when using Android IME HOT 3
- SPFx (Sharepoint Framework) and Rooster React HOT 7
- If content is assigned through initialContent property of Editor a br element is getting added HOT 3
- Add unit tests to roosterjs - react HOT 1
- Copy pasting a table loses some formatting HOT 1
- Content Model: General block element is not transformed to dark mode HOT 5
- Cannot access ambient const enums when 'isolatedModules' is enabled HOT 3
- Content Model: Setting Rooster content div innerHTML equal to a variable containing html inserts quotes around element property values HOT 1
- Is there a way to set the default paste type? HOT 1
- Bulleted and numbered list sometimes can't be added when an input box is empty HOT 3
- Text from the Watermark plugin is shown for a few miliseconds when indent is changed and input box is empty HOT 3
- 'Align center' doesn't work when copy and paste the text HOT 5
- Watermark plugin's text value can't be updated or localized HOT 5
- AttributeSanitizers are not applied to the child elements
- Only number 1 is shown for list items in the numbered list instead of a sequence HOT 5
- Use border shorthand CSS property and hex colors for table editor HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roosterjs.