Giter Site home page Giter Site logo

Comments (3)

JiuqingSong avatar JiuqingSong commented on May 19, 2024

Can you provide a repro step?

Thanks.

from roosterjs.

jesomekh avatar jesomekh commented on May 19, 2024

Essentially, if you change the font color of a piece of text which is underlined, then the font color of the text will change BUT the underline color will not change (as pictured). You see in the screenshot the text is green but the underline is black. Once you highlight the text again and change the color, then the underline will swap to the new font color.

from roosterjs.

Adjective-Object avatar Adjective-Object commented on May 19, 2024

Afaict this has to do with the order of the and elements

If the underline is a parent of the style, it will be the parent text colour (in this case black)
if the underline is a child of the style, it will be the child text colour (in this case green).

Possible fixes as I see it

  • Introduce ul normalization (e.g. if a ul has only one child, switch their orders so the child is the parent of the ul
  • when setting ul on an element, if the selected text is an entire inline element, make the ul a child of the inline element instead of a parent.

Thoughts @JiuqingSong ?

from roosterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.