microsoft/tas-client

tas-client

This repo is home to three separate projects:

• tas-client - base module for interacting with a treatment assignment service endpoint.
• tas-client-umd - UMD version of tas-client.
• vscode-tas-client - consumer of tas-client providing some VS Code-specific implementation.

READMEs for each are under their respective folders.

Contributing

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.

When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Trademarks

This project may contain trademarks or logos for projects, products, or services. Authorized use of Microsoft trademarks or logos is subject to and must follow Microsoft's Trademark & Brand Guidelines. Use of Microsoft trademarks or logos in modified versions of this project must not cause confusion or imply Microsoft sponsorship. Any use of third-party trademarks or logos are subject to those third-party's policies.

tas-client's Issues

Error accessing source map from npm package

When running vscode web (serverless) I get the following warning about a source map not found:
GET /static/build/node_modules/tas-client-umd/lib/tas-client-umd.js.map 404 0.720 ms - 9

Either add the map file to the npm package, or, better, disable source maps when building for production to avoid the reference

To reproduce:

• git clone https://github.com/microsoft/vscode-test-web.git
• npm i && npm run sample, open dev tools network tab, in VS code web open some files

Error logged to dev tools in VS Code

Hello 👋 in VS Code we've been seeing:

(node:88228) [DEP0128] DeprecationWarning: Invalid 'main' field in '/Users/tyleonha/Code/Microsoft/vscode/extensions/github-authentication/node_modules/vscode-tas-client/package.json' of './out/index'. Please either fix that or report it to the module author(Use Electron --trace-deprecation ... to show where the warning was created)

and one for tas-client as well. This seems to be because of this:
https://nodejs.org/api/deprecations.html#DEP0128

and the reason is that your main set to ./out/index is invalid and should be just index.js based on the package contents:

or on the flip side, update the build script to keep the out folder? which I'm guessing is happening here:
https://github.com/microsoft/tas-client/blob/main/vscode-tas-client/gulpfile.js#L69

`vscode-tas-client` package include .map and test file

Repo

1. npm install vscode-tas-client

Bug

The installed package includes .map files as well as a test directory. Both of these should be excluded from the published build

Consider not depending on axios

I was looking at vscode-tas-client here:
https://bundlephobia.com/package/[email protected]

and I noticed that the composition is 61.4% axios:

axios is nice, but on the web, we have fetch built in (and in node, you can use node-fetch). If you switch to using fetch (and node-fetch only in node), this module can be much smaller.

We load this module as a part of the GitHub Auth extension in VS Code and so it contributes about 8kb to the size of that extension.