Giter Site home page Giter Site logo

Comments (5)

RyanCavanaugh avatar RyanCavanaugh commented on April 27, 2024

Narrowing can't narrow X<A | B> to A or B when X is nondistributive like NoInfer is. You need to write NoInfer<ParametersOf<Task>> | NoInfer<GetParametersOf<Task>>

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on April 27, 2024

Aside: I'm also trying to figure out why you're using NoInfer in the first place here.

from typescript.

matheusvellone avatar matheusvellone commented on April 27, 2024

Aside: I'm also trying to figure out why you're using NoInfer in the first place here.

I removed the place where I define an array of TaskCombos[].

const combos = [
  {
    task: TASK_NAMES.Task1,
    parameters: { task2: true }, // This is wrong
  },
] satisfies TaskCombos[]

I want to avoid TS telling me that I'm passing the wrong task, because in this case the task "locks" the type and parameters should respect it (not inferring from it)

I'll close the issue, since making it NoInfer<ParametersOf<Task>> | NoInfer<GetParametersOf<Task>> works.

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on April 27, 2024

That's also an error without using NoInfer, though?

from typescript.

matheusvellone avatar matheusvellone commented on April 27, 2024

Yes, without NoInfer the error still appears, but in more complex cases, with more parameters and more tasks, I feel that the error is better presented when using NoInfer and also makes more sense from the developer experience sight

In my project, there are around 80 tasks, each one with its parameter type.
But some tasks parameters are very similar, which tricks (i think) TS into showing that I'm using the wrong task for that parameters in some cases.

In this case, NoInfer makes sense to me, because I'm telling TS to avoid inferring the Task from the Parameters and only trust the task prop

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.