Giter Site home page Giter Site logo

Comments (5)

whzx5byb avatar whzx5byb commented on May 5, 2024

What about

type TestType =
  | {
      as: "link";
      id: string;
    }
  | {
      as: "div";
      id?: undefined
    };

from typescript.

C0RR1T avatar C0RR1T commented on May 5, 2024

Strictly speaking, this could be a breaking change when not implemented correctly. Based on this question on StackOverflow, JS discrimates between implicitly setting a property to undefined vs. setting it implicitly as undefined (by not defining it). So there is the possibility that this could be breaking, for example in this code:

type TestType = {
  as: 'div';
  id?: undefined;
}

const test = (props: TestType) => "id" in props;


// true
console.log(test({as: 'div', id: undefined}));

// false
console.log(test({as: 'div'}));

I don't have an idea to on how this could be implemented without breaking prior code. Im also not sure if the code above has actually been written before since I don't see how the code above could be useful.

from typescript.

C0RR1T avatar C0RR1T commented on May 5, 2024

What about

type TestType =
  | {
      as: "link";
      id: string;
    }
  | {
      as: "div";
      id?: undefined
    };

Lol, haven't thought of that, thanks for your comment. Maybe id?: never would be even better.

Imo, this code doesn't express the intent as good as id: undefined would, but I mean, it works. What do you guys think?

from typescript.

whzx5byb avatar whzx5byb commented on May 5, 2024

Maybe id?: never would be even better.

Yeah, if you want ts report error on test({as: 'div', id: undefined}) you can replace id?: undefined with id?: never and please make sure to turn on exactOptionalPropertyTypes: true

from typescript.

C0RR1T avatar C0RR1T commented on May 5, 2024

Alright, thanks alot @whzx5byb! Im gonna go ahead and close this feature-request since this would be a breaking change for a small (and arguable) improvement. Consider the solutions provided by whzx or me :) .

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.