migaku-official/migaku-editor-addon

Migaku Editor is an Anki add-on that makes it quicker and easier to edit cards while reviewing. If you have an issue please report it in the "Issues" tab. Reponses to issues can be slow on GitHub, for faster support consider joining our Discord server through our Patreon page.

migaku-editor-addon's Issues

Conflict with "Extended Tag Add/Edit Dialog" Addon

Migaku Editor addon conflicts with the Extended Tag Add/Edit Dialog addon.
If both is install and you try to edit a card with Migaku Editor addon it will throw this error:
TypeError: 'QWidget' object is not callable

[Feature Request] MIA editor on the preview window

would it be possible to use the MIA editor on the preview window to edit the cards from the browser as well?

Replacement issue with nested div tags in card templates

I am not sure if I brought this issue on because I tinkered with my card template, or what. However, I found that the text replacement fails if card fields are nested. That is, if div tags are nested, the regular expression fails to match them correctly.

This problem is not surprising, however, because regular expressions aren't actually capable of paren-balancing (extended regexes can, but it's messy). You need at least a stack-based solution, I think.

Since you have balanced tags it's really similar to a calculator. An outline of how to build the modified text would be:

1. Check each character in the template (or word, whatever) and insert it unless it meets point 2 below.
2. Finding an opening div tag means push the changed version (the one with the new JS) onto the stack plus a unique token, and insert the changed, unfinished version with this token instead of the field name we need.
3. When you find a matching fieldname, find the div tag on the top of the stack, get its token, and find that token in the text you've already accumulated and replace it with the fieldname. Push the fieldname onto the stack. Insert the fieldname.
4. When a closing div tag is found, pop the top two elements off the stack and insert them into the text along with the closing div tag.
5. All other text is just inserted into the replacement text as normal.

If I understand the goal correctly, this solves the problem and shouldn't be too slow. Considering that the size of the template text is only maybe a thousand characters, searching character-wise shouldn't be an issue. It can maybe be improved by splitting the text on "<div", but I bet Python does a character-wise search anyway.

Conflict with cloze overlapper

Here is the issue glutanimate/cloze-overlapper#43

When a card is made using cloze overlapper the front is shown, but for the back the error "Invalid HTML on card: TypeError: Cannot read property 'innerHTML' of null" appears

Image scaling feature

Hey,
first of all, great addon, it makes editing a whole lot easier.
But i wanted to ask if there is a way to turn off the "Quick Image Resizing" because it shuts off other addons which affect images?
Thanks for your help!

Templates as class attributes issue

Type:

• bug
• feature
• enhancement
• question

Environment:

• OS: MacOS (but I imagine others as well)

Going to open a PR:

• yes
• no

Description:
Using templates as class attributes results in unexpected behaviour. For example, if we had a monolingual card indicator that was only visible when the card had the tag "jp-jp" then the relevant HTML might look like <span style="opacity: 0" class="{{Tags}}">JP-JP</span> with the CSS span[class*="jp-jp"] {opacity: 0.6 !important;}. With this bug, this code no longer functions, and an additional "> appears on the card.