mijick/timer

Modern API for Timer

timer's Issues

Issues with progress observing

Without using publish method we get several problems:

1. Method onTimerProgressChange will cause infinite calling in completion with time 0.0
2. Method onTimerActivityChange will call completion only once on start

try? MTimer
            .createNewInstance()
            // .publish(every: time) { _ in } // i don't use it 
            .onTimerProgressChange { print($0) }  // causes a loop 
            .onTimerActivityChange { print($0) } // will be called once on start 
            .start(from: .zero, to: time)

No control over runloop modes

The code as I write this, creates the internalTimer with scheduledTimer(). on macOS, that means the timer won't run when the mouse is down in a menu item or other tracking loop. Instead, create the timer unscheduled, and schedule it on the runloop with the correct mode. See NSRunLoop's add(timer: mode:)

At least there should be a comment warning programmers of the problem.