mikebrady/alac

Apple Lossless Codec and Utility with Autotools

alac's Issues

alac.spec

Hi Mike,
How about add alac.spec file in your repository like following. I just modify a little bit from your shairpot-sync.spec file.

Name:           alac
Version:        0.0.7
Release:        1
Summary:        A clone of the Apple Lossless Audio Codec.

Group:          Applications/Multimedia
License:        GPL
URL:            https://github.com/mikebrady/alac
Source0:        https://github.com/mikebrady/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

BuildRequires:  autoconf
BuildRequires:  automake
BuildRequires:  libconfig-devel

%description
This is a clone of the Apple Lossless Audio Codec (ALAC) repository at http://alac.macosforge.org with added files to enable it to be built using GNU autotools. Use it to build and install the ALAC library libalac.

%prep
%setup -q

%build
autoreconf -i -f
%configure
make %{?_smp_mflags}

%install
make install DESTDIR=%{buildroot}


%files
%doc AUTHORS LICENSE README.md
%attr(0644, root, root) "/usr/include/alac/"
%attr(0644, root, root) "/usr/lib64/libalac*"
%attr(0644, root, root) "/usr/lib64/pkgconfig/alac.pc"


%changelog
* Mon Mar 6 2017 Sanghoon LEE <[email protected]> 0.0.7-1
- Initial spec file

Issue installing

I get the following error when install your ALAC

aclocal: warning: couldn't open directory 'm4': No such file or directory

Both on my Raspberry Pi3 and my Pi Zero

autoreconf -fi fails with 'autoreconf: automake failed with exit status: 1'

On Raspbian Stretch, installation fails on first run:

pi@soverommet:~/brutepi/alac $ autoreconf -fi
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '..'.
libtoolize: copying file '../ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:40: installing './compile'
configure.ac:63: installing './config.guess'
configure.ac:63: installing './config.sub'
configure.ac:20: installing './install-sh'
configure.ac:63: error: required file './ltmain.sh' not found
configure.ac:20: installing './missing'
Makefile.am: installing './INSTALL'
codec/Makefile.am: installing './depcomp'
autoreconf: automake failed with exit status: 1

The offending line being libtoolize: putting auxiliary files in '..'. - so it tries to put ltmain.sh a directory up from where it's supposed to be.

On running autoreconf a second time (when m4 already exists), it appears to put the files in the correct location, and configure appears to work as intended

Fix transposed values in documentation

You're missing this upstream commit that fixes an error in the documentation:

macosforge/alac@3814718

Severe Remote Code Execution vulnerability (from upstream)

Several vulnerabilities exist on the decoder, see macosforge/alac#22

Submitted a limited incomplete patch macosforge/alac#22 (comment) which doesn't fix the issue completely, fuzzing still discovered other deeper issues in how decoding is handled.

Test ALAC decoding

How can I test if shairport is using ALAC to decode the audio after installation and setting it up in config?

configure fails with error: cannot find input file: `codec/Makefile.in'

Tried this on Raspberry Pi Model 3B with STRETCH LITE 2018-06-27.

Output:
...
./configure: line 5027: LT_INIT: command not found
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: error: cannot find input file: `codec/Makefile.in'

Any suggestions would be appreciated :)

cheers