mikemorenodsp/ep-mk1

EP-MK1 is a real-time physical model plugin of an Electric Piano built with Pure Data and Camomile.

ep-mk1's Issues

Instrument out of tune ( 147 cents too high )

On my system (Arch Linux with Ardour) the instrument is out of tune.
When I play A3 on the keyboard it actually plays A#3 +47cents, which is 147 cents too high.

Pitch issue at 48kHz

It seems the pitch is not good if I set my audio server (JACK) at 48kHz. The pitch is too high by more than a half tone. Setting 'Base MIDI' to 70 and 'Base' to 428.5 can resolve it but it is not very user friendly.
No problem at 44100Hz.
I use the last release (EP-MK1 v2.2) linux version on Debian Buster.

Ep-MK1 camomille

Hi

First thanks for this great software - this rhodes is up to par with the commercial ones I own . Well done.

When playing the A3 note on my controller the rhodes sustains. Is that a setting I have missed or a bug? I do not get the same behaviour in other plugins - have checked that :-) No other tones accros my 48 key controller gives this behaviour

it seems that its the tone bar setting that is active for this one note because when I move the params of this the tone changes.

Its A3 or A4 - Its says A4 in the small keyboard conttoller windowd in carla, but A3 on my physical keyboard controller

Edit: relaunching the plug in carla fixed the problem, so cant isolate this problem to this plug.

Unable to load scales on Windows

First let me express my gratitude, for this is the best microtonal plugin on the internet so far. Simple yet robust. Just this bug bars me from loading any custom scale.

So when I load a scale text the log reads:

tried D:\Program Files\VSTPlugins\VSTPlugins 64bit\EP-MK1/D:\Program Files\VSTPlugins\VSTPlugins 64bit\EP-MK1\Young 1799.txt and failed
D:\Program Files\VSTPlugins\VSTPlugins 64bit\EP-MK1\Young 1799.txt: can't open
D:\Program Files\VSTPlugins\VSTPlugins 64bit\EP-MK1\Young 1799.txt: read failed

Apparently it tries to load but the path is somehow messed up, wherever I place the file. And I don't see if I could input the path manually.

No response to 'All Notes Off" message

When used as a VST2 plugin on linux, the EP-MK1 does not turn all the notes off when it receives an 'All Notes Off' control signal.

Use a standard license

License file is here:
https://github.com/MikeMorenoDSP/EP-MK1/blob/master/License.txt

But GitHub detect as custom other license:
https://api.github.com/repos/MikeMorenoDSP/EP-MK1/license

This is problematic when using the GitHub API to categorize plugins by license type. Compare to a standard license API request:
https://api.github.com/repos/asb2m10/dexed/license

If you could use a standard license from either:
https://choosealicense.com/

OR the list here:
https://api.github.com/licenses

Would be much appreciated!

crash when adding VST2 to zrythm (GNU/Linux)

this is using the latest binary from the releases page here

Thread 1 "zrythm" received signal SIGSEGV, Segmentation fault.
0x00007ffff6f6e420 in post () from /usr/lib/libgvc.so.6
(gdb) bt
#0  0x00007ffff6f6e420 in post () at /usr/lib/libgvc.so.6
#1  0x00007fff9ca65764 in libpd_init () at /home/alex/.vst/EP-MK1/EP-MK1.so
#2  0x00007fff9c9f7910 in libpd_multi_init () at /home/alex/.vst/EP-MK1/EP-MK1.so
#3  0x00007fff9c9eacdf in pd::Instance::Instance(std::string const&) () at /home/alex/.vst/EP-MK1/EP-MK1.so
#4  0x00007fff9c9cba17 in CamomileAudioProcessor::CamomileAudioProcessor() () at /home/alex/.vst/EP-MK1/EP-MK1.so
#5  0x00007fff9c9cd24b in createPluginFilter() () at /home/alex/.vst/EP-MK1/EP-MK1.so
#6  0x00007fff9c75ab4b in createPluginFilterOfType(juce::AudioProcessor::WrapperType) () at /home/alex/.vst/EP-MK1/EP-MK1.so
#7  0x00007fff9c720c73 in VSTPluginMain () at /home/alex/.vst/EP-MK1/EP-MK1.so
#8  0x00007ffff6a6eec3 in  () at /usr/lib/carla/libcarla_host-plugin.so
#9  0x00007ffff6a70f0f in CarlaBackend::CarlaPlugin::newVST2(CarlaBackend::CarlaPlugin::Initializer const&) () at /usr/lib/carla/libcarla_host-plugin.so
#10 0x00007ffff69c33f7 in CarlaBackend::CarlaEngine::addPlugin(CarlaBackend::BinaryType, CarlaBackend::PluginType, char const*, char const*, char const*, long, void const*, unsigned int) () at /usr/lib/carla/libcarla_host-plugin.so
#11 0x0000555555f2562d in create_plugin (plugin=0x555582cb8850, type=PLUGIN_VST2, error=0x7fffffffc980) at ../src/plugins/carla_native_plugin.c:551
#12 0x0000555555f268ab in create_from_setting (plugin=0x555582cb8850, error=0x7fffffffc980) at ../src/plugins/carla_native_plugin.c:1088
#13 0x0000555555f268d9 in carla_native_plugin_new_from_setting (plugin=0x555582cb8850, error=0x7fffffffc980) at ../src/plugins/carla_native_plugin.c:1108
#14 0x0000555555f34742 in plugin_new_from_setting (setting=0x5555897337b0, track_name_hash=2928975600, slot_type=PLUGIN_SLOT_INSERT, slot=0, error=0x7fffffffca50) at ../src/plugins/plugin.c:577
#15 0x0000555555e93f32 in create_track (self=0x555582eed600, idx=0, error=0x7fffffffcd40) at ../src/actions/tracklist_selections.c:807
#16 0x0000555555e9488b in do_or_undo_create_or_delete (self=0x555582eed600, _do=true, create=true, error=0x7fffffffcfc8) at ../src/actions/tracklist_selections.c:1002
#17 0x0000555555e9883a in do_or_undo (self=0x555582eed600, _do=true, error=0x7fffffffcfc8) at ../src/actions/tracklist_selections.c:2121
#18 0x0000555555e9890d in tracklist_selections_action_do (self=0x555582eed600, error=0x7fffffffcfc8) at ../src/actions/tracklist_selections.c:2149
#19 0x0000555555e99910 in undoable_action_do (self=0x555582eed600, error=0x7fffffffcfc8) at ../src/actions/undoable_action.c:291
#20 0x0000555555e9b701 in do_or_undo_action (self=0x5555829e2980, action=0x555582eed600, main_stack=0x555582de1710, opposite_stack=0x555582f25e90, error=0x7fffffffcfc8) at ../src/actions/undo_manager.c:119
#21 0x0000555555e9c14d in undo_manager_perform (self=0x5555829e2980, action=0x555582eed600, error=0x7fffffffd100) at ../src/actions/undo_manager.c:315
#22 0x0000555555e93acb in tracklist_selections_action_perform
    (type=TRACKLIST_SELECTIONS_ACTION_CREATE, tls_before=0x0, tls_after=0x0, port_connections_mgr=0x0, track=0x0, track_type=TRACK_TYPE_INSTRUMENT, pl_setting=0x5555898dd3d0, file_descr=0x0, track_pos=7, pos=0x555582af1e78, num_tracks=1, edit_type=EDIT_TRACK_ACTION_TYPE_SOLO, ival_after=-1, color_new=0x0, val_before=0, val_after=0, new_txt=0x0, already_edited=false, error=0x7fffffffd100) at ../src/actions/tracklist_selections.c:694
#23 0x00005555560335e5 in on_drag_data_received (widget=0x555583171dd0, context=0x5555898e93f0, x=138, y=42, data=0x7fffffffd8c0, info=1, time=295213723, self=0x555583171dd0) at ../src/gui/widgets/drag_dest_box.c:239
#24 0x00007ffff761ceec in  () at /usr/lib/libgtk-3.so.0
#25 0x00007ffff7202030 in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#26 0x00007ffff72023ca in g_signal_emit_by_name () at /usr/lib/libgobject-2.0.so.0
#27 0x00007ffff79004b1 in  () at /usr/lib/libgtk-3.so.0
#28 0x00007ffff76194f7 in  () at /usr/lib/libgtk-3.so.0
#29 0x00007ffff7202030 in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#30 0x00007ffff72023ca in g_signal_emit_by_name () at /usr/lib/libgobject-2.0.so.0
#31 0x00007ffff7802f36 in gtk_selection_convert () at /usr/lib/libgtk-3.so.0
#32 0x00007ffff79033cc in  () at /usr/lib/libgtk-3.so.0
#33 0x00007ffff7772dbf in gtk_main_do_event () at /usr/lib/libgtk-3.so.0
#34 0x00007ffff74d17f3 in  () at /usr/lib/libgdk-3.so.0
#35 0x00007ffff7521614 in  () at /usr/lib/libgdk-3.so.0
#36 0x00007ffff7ebb10c in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#37 0x00007ffff7f0eba9 in  () at /usr/lib/libglib-2.0.so.0
#38 0x00007ffff7eb8871 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0
#39 0x00007ffff72f88b6 in g_application_run () at /usr/lib/libgio-2.0.so.0
#40 0x0000555555e736dc in main (argc=1, argv=0x7fffffffdd38) at ../src/main.c:52
(gdb) 

Limit of Tremolo Rate too high and limit of Tremolo Depth too low

The upper limit of tremolo rate is 20000 Hz.
When controlling the plugin with generic controls or with a midi controller it is impossible to select a sane number between 0 Hz and say 16 Hz ( actually 10 would be enough for my taste : )
My proposal would be to set the upper limit somewhere between 10 Hz and 16 Hz.

Also the lower limit of tremolo depth is too low to use it with a controller. A more practical lower limit would be -30 dB.

And thank you Mike for this wonderful instrument! It's a gift that should be more renowned!

What is the license?

Hey there!

Loving this plugin and figured I'd try to package it up for the Arch Linux AUR, but to "correctly" package it, I need to list a license - so far, I don't see any obvious hints at a license in the repo (looked for COPYING, LICENSE, etc. files as well as in a few README-esque files, came up empty-handed).

I'm assuming that, given this is on GitHub, an AUR package which simply pulls a tag from GitHub and compiles the plugin is OK, but I'd still like to properly set the license field on the resulting package if at all possible (if even only to appease the Arch Linux packaging standards).

Cheers!

Wrong midi mapping with scale from Scale workshop

I'm trying to use this scale on EP-MK1, but I don't think the midi mapping it gives me is right. For example, C-F should be around a 4/3 (494.118c), but on EP-MK1 it sounds closer to 11/8.

I tried it both with the vst and directly in pd.
(in the vst I had this issue also)

vst3 version for Linux

vst2 is deprecated by Steinberg, so a vst3 version for linux would be awesome for the future.

No pitchbend wheel reaction

Hi.
Thanks a lot for this very good instrument !
Would it be possible to add pitch variation with the pitchbend wheel ?

no reaction to sustain pedal

i have to map the sustain pedal (midi cc 64) manually to the sustain pedal button. Could the mapping be permanently?

PS: i love the posibillity of „# of divisions“ for its creative potential!